From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DED25A0540; Wed, 21 Sep 2022 11:57:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91A3D40697; Wed, 21 Sep 2022 11:57:42 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2054.outbound.protection.outlook.com [40.107.244.54]) by mails.dpdk.org (Postfix) with ESMTP id 7F55A4014F for ; Wed, 21 Sep 2022 11:57:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TWP2nOOfnEuJiMEIBDkZy+BShEmKZTUU4gl0tuXB7LqHgNDOmFFTIJ4GLaR+kNYWlZvZBqJH4cH0OC85VZ0EuyLw//L/47y2CvpW2lxCbylFJvRJnpSBnEhSRin+z8lGrgXbyivHCzjeaSlJtbgnpfYym6D1fdRFtJPJ66H7WSPaGoMXZNOqFVGppagZqydrSB0tu3wNt9Y4UEZI1AbMRYURCvhDz3l4DFgBq4prGV5MEfBKKwnlt/Togy5duX8MLl6XSF6YfJYCH6QLRR36G4qHfTV0rI0CSTC2BlIDcEiK5eB5xFD/J140A4yn6w9r4hJ5tS65jjPDbQ6QpHa+Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SaZ9IKKKy63Qogk6Utui7x/xkZvbG5Dm4mpP2aVI4Pg=; b=R+3+JZu3bP12O7rRpscG9Epuz2kFREmvY13Z8F+WeJOzbFf1kP/e7zh7LDRh3AlFYJ1OJis+VqO02CYlhfabVw/rKXCOZV3jWQjDnqnVtRWp04CPnDW+dCT1BAfsz1gFOzV+FBcOhQ0Zdm2oVF8Q3hBFKeIGjQTkZLUcjFyjKF+Z/BXCUVQaE2fOqZykf5+0E1kmhivFOpUyRIeCOXeBW681ZUvUMtCHGQeq4Y6eIa4cENYGAzxPGL5U1k7xqer9bFDdz6eMLip4gHbNejHlLheFDMcd0iOcwVLseQShIsuF9CmBH8Obhcco8g4UtjK5mIf9Idz7FmOMF9r7JcXUQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=redhat.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SaZ9IKKKy63Qogk6Utui7x/xkZvbG5Dm4mpP2aVI4Pg=; b=fK/kxysFWyup2auMp8WKqPqUqQFCDQcncACHZynOlZbDvYAiS0IcFlavGL2p/lSb2iCVCKgEhH7WGEAdiZ0v3KMY56nKYuJiaawMUFDLcNvXeWaJuoVPA0g7ZLHnANK4xvFEq4yN09tlbX0td84fUAjvgHo3or6NeFXfpneDAL8= Received: from SN7PR04CA0217.namprd04.prod.outlook.com (2603:10b6:806:127::12) by MN2PR02MB6927.namprd02.prod.outlook.com (2603:10b6:208:203::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Wed, 21 Sep 2022 09:57:38 +0000 Received: from SN1NAM02FT0009.eop-nam02.prod.protection.outlook.com (2603:10b6:806:127:cafe::16) by SN7PR04CA0217.outlook.office365.com (2603:10b6:806:127::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Wed, 21 Sep 2022 09:57:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0009.mail.protection.outlook.com (10.97.4.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Wed, 21 Sep 2022 09:57:37 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 21 Sep 2022 10:57:36 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Wed, 21 Sep 2022 10:57:36 +0100 Envelope-to: rjarry@redhat.com, dev@dpdk.org, olivier.matz@6wind.com, bruce.richardson@intel.com Received: from [10.71.194.74] (port=60996) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oawU4-0003Xv-JN; Wed, 21 Sep 2022 10:57:36 +0100 Message-ID: <6fe7e052-0ff3-e228-9348-2cc7ed2e47c1@xilinx.com> Date: Wed, 21 Sep 2022 10:57:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v4] usertools: rewrite pmdinfo Content-Language: en-US From: Ferruh Yigit To: Robin Jarry , CC: Olivier Matz , Bruce Richardson References: <20220913105811.84384-1-robin@jarry.cc> <20220920104212.476889-1-rjarry@redhat.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1NAM02FT0009:EE_|MN2PR02MB6927:EE_ X-MS-Office365-Filtering-Correlation-Id: 536be755-34d6-4669-d934-08da9bb7b707 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3kp+FvsaXw4hiPN4i5XFho2B/6dS3uU4Fb1haY8gYnra3srMjMbeFohPQzQkCezGVeF6psIhxTXeCpBxWMhP6DWYRLw91W81s/p1nH3rL6eYmtBtN0v8mbQq277NyxKw2gPPlrkHi2DznesGOE0CuQovRBGz0t3Z64uWm0tpt6WbzIYlE3Jr743KCHGu9bTMACWRu71nul6nARvDcOoIVXHllAi04VDi/Alz1rbrkckBjFivrj+ZyU8FXPob04uaEEeJyoOExPXC5Ac4NgRWNQ5WQuw0hkj4UTbcQlXSrY42vH658UYhRTTNlaemioOzWFMh5iIM3EqyIi1bVY3YQIseFMKr2daAnwMfe4vR/cDdYaSnfPuBS+TqH6Sg0W2KFyQgxMw++3w+PPkeyyCz4TRUW8Yjur/9x9Bke1qxWKDscZnQkPNLYSJStVLV9IYOW6JgPQERM5snIiODeZNzkkEZhdUByJSHhDKKNqep3bW6udeDcaQ1M4oPTHgs1aym5jDuiq+6YDtP5rnhKlGiEfix5oFbaCO3mWe1Fi48nsx6M9mrlopXWjjC6KpOJgerZXD+0dLNNHPB4zpgVgHfgKyHqEIE50Z3LSQRhXLTC6JMuJZ0SI7sclXhgxx/vdRmt7VOibrBwrrxP3TDqxs+XApwfLxYjJ3CMC/rHGYvfDH9bjGfJStcCtRBbOHK9iJ6ogptyI67usLWtW8PDWSf26EUestfgosC7ubLNjNjGssBPIMHgugZkWFZcQFojVyLCNOrG0DYWxBoxgK3efHlioYtlGDa0WOvmkghaParDQpu0ZT1qhenZdgkjB5l6bxNC/h80YCy2QYyoMMEEZBRRg== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(376002)(136003)(39860400002)(346002)(451199015)(46966006)(36840700001)(40470700004)(82740400003)(336012)(31696002)(2616005)(356005)(426003)(186003)(41300700001)(5660300002)(36860700001)(47076005)(40480700001)(83380400001)(9786002)(40460700003)(8936002)(44832011)(4744005)(54906003)(70206006)(70586007)(7636003)(4326008)(8676002)(82310400005)(2906002)(26005)(53546011)(110136005)(36756003)(478600001)(31686004)(316002)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 09:57:37.5755 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 536be755-34d6-4669-d934-08da9bb7b707 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0009.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR02MB6927 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/21/2022 8:58 AM, Ferruh Yigit wrote: > On 9/20/2022 8:15 PM, Robin Jarry wrote: > >> >> Ferruh Yigit, Sep 20, 2022 at 19:48: >>>> +* The ``dpdk-pmdinfo.py`` script was rewritten to produce valid >>>> JSON only. >>>> +  PCI-IDs parsing has been removed. >>>> +  To get a similar output to the (now removed) ``-r/--raw`` flag, >>>> you may use the following command:: >>>> + >>>> +     strings $dpdk_binary_or_driver | sed -n 's/^PMD_INFO_STRING= //p' >>>> >>> >>> Empty line is missing (in case there will be a new version for some >>> other reason). >> >> What do you mean? >> > > just nit picking, there needs to be two empty lines before "ABI > Changes", I assume committer can fix it while merging if there won't be > any new version. Also looking twice, this release note update is in "API Changes" section, I think that is not correct place, "New Features" section can be better place.