From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB7B745DB6; Wed, 27 Nov 2024 13:18:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9584E402AB; Wed, 27 Nov 2024 13:18:41 +0100 (CET) Received: from fhigh-b4-smtp.messagingengine.com (fhigh-b4-smtp.messagingengine.com [202.12.124.155]) by mails.dpdk.org (Postfix) with ESMTP id EC6C34025D for <dev@dpdk.org>; Wed, 27 Nov 2024 13:18:39 +0100 (CET) Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfhigh.stl.internal (Postfix) with ESMTP id 357BE2540110; Wed, 27 Nov 2024 07:18:39 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Wed, 27 Nov 2024 07:18:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1732709919; x=1732796319; bh=2SpSbiE3HoFz1x+wY4KOFbsDRNamE8imBXMjUosNe2U=; b= S4uOY304ylYAJIitNfuuVTHvfEIYYw4bXpOTUpst6rawkk0QtLOND3kfKqLgyR3D iJICKXb3WoCnMtOWo63C3HCoRVIgI8Sgts0fUTpDtZmN9xLf19pQqKRUFk6JYGRy 8nrMzurKmbYx3v9+IGdVdwOav30QNWZTv3snEOJTFQvt+wCoBUeo2UuKP0WHPMNo RKD4LtWhkgpIavbjob2pl+SdM1UxRvDQpu7wfEPamlsngdcjrsj4NFM+z6+K8fY0 FXVy/fDf3YFgDs5JIrNSWnAneiWWDXWlLxLCpLXeKdU4s+Y6VVMAxa4GKkrd9cbo MFGnWkwLAJVHf8tO2PWTPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1732709919; x= 1732796319; bh=2SpSbiE3HoFz1x+wY4KOFbsDRNamE8imBXMjUosNe2U=; b=i wS72W1QidZ5LUATPyodeyj7PKZOTKplzm/qWH5xHfG1ULYCPECgNBxp3uQRI68BC dI2zJbVOWbCycg/7qiNjqUVvhrcnVcxW8hkYrN2npko4w3b4Ot9WJ2TQn0n+7sqc /GvRROjnQEQ2fH45NOrPv/6ZwQHpEcfugn2nCD+Ee4yVhuWC88sZPgl+979G/SSo UWuWnvnn1pKriGrZpLkIak9zU5SF73PL5xNlRVc8jPu3Lm+MDpGM9cmpMc7P6HLx ViwwpOLkVXWYzYoSlc1HcNoW4k393Okbff628J3vFHRIbrpyckHR/dclkLHSApLT aFNk5CGEJceaW3smsyESQ== X-ME-Sender: <xms:Hg5HZwl8rCKyknfhvs638XvzsYKRyqFWO-DwHF72_iKumS5Qpk1sbw> <xme:Hg5HZ_0BIylupLUgc5wih17ZLs_uWXdXl7Zm7A90sMbSRYSk9cWR4zQZGRRhh8y98 7IMVq_3yHYB2RVd2Q> X-ME-Received: <xmr:Hg5HZ-p-TSodeBWWrsYao3T-oGdPE4o69qjvmmriNB8VlbV6Al0st1khi3n-Or1O8HbYvcBV9wujmpR3mpGJ254> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrgeelgdefhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecu hfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlh honhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeu veejffejgedtgeegkefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgs pghrtghpthhtohepiedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepvhhirggthh gvshhlrghvohesnhhvihguihgrrdgtohhmpdhrtghpthhtohepuggvvhesughpughkrdho rhhgpdhrtghpthhtoheprhgrshhlrghnugesnhhvihguihgrrdgtohhmpdhrtghpthhtoh epmhgrthgrnhesnhhvihguihgrrdgtohhmpdhrtghpthhtohepshhurghnmhhinhhgmhes nhhvihguihgrrdgtohhmpdhrtghpthhtohepshhtvghphhgvnhesnhgvthifohhrkhhplh humhgsvghrrdhorhhg X-ME-Proxy: <xmx:Hg5HZ8mxoNP1sWemXi9U__tAEKa9GOTHMjmzrB_1rzqY2NhLHm3lLQ> <xmx:Hg5HZ-0MtuokALEPAF6vYM9JIF65v8j_qtRuF55xGwOBidvsm_F9GA> <xmx:Hg5HZzsLg3BwZNgonm1eyekfZr3nxqRURrFWMD77QuHRPfWu1BI99g> <xmx:Hg5HZ6Vb5JpXoTBHEasrd41TpsNUhPdFxi3cZaqki4U63OYphoML6g> <xmx:Hw5HZ4r1RGYeaReM9EKz2jpDD0jGWY193iEvMs1fscZwbS8jh7HTOR3v> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Nov 2024 07:18:36 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Viacheslav Ovsiienko <viacheslavo@nvidia.com> Cc: dev@dpdk.org, rasland@nvidia.com, matan@nvidia.com, suanmingm@nvidia.com, Stephen Hemminger <stephen@networkplumber.org> Subject: Re: [PATCH v2] doc: add mlx5 xstats send scheduling counters description Date: Wed, 27 Nov 2024 13:18:31 +0100 Message-ID: <7007215.cEBGB3zze1@thomas> In-Reply-To: <20241126163658.12682008@hermes.local> References: <20241028085708.0060bc6f@hermes.local> <20241031080438.1701634-1-viacheslavo@nvidia.com> <20241126163658.12682008@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 27/11/2024 01:36, Stephen Hemminger: > On Thu, 31 Oct 2024 10:04:38 +0200 > Viacheslav Ovsiienko <viacheslavo@nvidia.com> wrote: > > > The mlx5 provides the scheduling send on time capability. > > To check the operating status of this feature the extended statistics > > counters are provided. This patch adds the counter descriptions > > and provides some meaningful information how to interpret > > the counter values in runtime. > > > > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com> > > --- > > doc/guides/nics/mlx5.rst | 59 ++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 59 insertions(+) > > > > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst > > index b5522d50c5..5db4aeda1b 100644 > > --- a/doc/guides/nics/mlx5.rst > > +++ b/doc/guides/nics/mlx5.rst > > @@ -2662,3 +2662,62 @@ Destroy GENEVE TLV parser for specific port:: > > > > This command doesn't destroy the global list, > > For releasing options, ``flush`` command should be used. > > + > > + > > +Extended Statistics Counters > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > + > > +Send Scheduling Extended Statistics Counters > > +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > It is great to see description of counters, it would be good if all drivers did > this for xstats. There are some issues with the documentation that should be > addressed in later update. > > The section number is wrong. It ends up as a subset of the "Testpmd driver specific > commands". It should be in the Statistics section. I've moved it and converted the bullet list to a definition list. > The section headings overall for this NIC guide need to be reorganized/reworded. > Kind of mess now. Yes this guide will be reworked. Applied, thanks.