From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id EAAF15A6F for ; Mon, 19 Jan 2015 10:13:32 +0100 (CET) Received: by mail-wi0-f169.google.com with SMTP id bs8so15135377wib.0 for ; Mon, 19 Jan 2015 01:13:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=6Pniaz6EaYYe7dJF5J0zjqz0vASE0nugXjj/H1GzYZs=; b=fG4hlbNfONwIWJ70yX/OvWptsLN3WELGJUDCL+qI1G0s+hydSnAHKjFw4qX2LFoz4a DOFqRkqZvRzoX1b3x1XwXp4LMtbaVGuAhmEH/Lr3YXIZz68nMwVy5fL292G9IpTJXQLH RObhV+rZGJpWl6rZD0UN8pxnx/Txu8xfH9T6tsP+YaMgMpycy3agY4fmNf2tJ3pObKea 5/HrFq/H3WFjMmnfHzdqBzzwsyHFJ8Dr2NjmBHGzuqGoiX3lY2iWt425erWbDRjhwgM7 bCKtB2Nvn9LVJxUhIQ3qD9ICU9kKn+ABayqQkdnxWY+pJ38e0mByMESB1+aiDqFp0Nu6 We4Q== X-Gm-Message-State: ALoCoQkbOD0SZE3U8Uwm2ece9jjTdik9V8pu+tpCCZRDIvcwcmq8VKb3OwFpzcjmaiAWLZDK27SO X-Received: by 10.181.12.112 with SMTP id ep16mr34050372wid.38.1421658812794; Mon, 19 Jan 2015 01:13:32 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id fp2sm13404446wib.8.2015.01.19.01.13.31 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Jan 2015 01:13:32 -0800 (PST) From: Thomas Monjalon To: David Marchand Date: Mon, 19 Jan 2015 10:13:10 +0100 Message-ID: <7022282.sJULtgJP1R@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: <1419694115-1892-1-git-send-email-rkerur@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] Fix rte_is_power_of_2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jan 2015 09:13:33 -0000 2015-01-19 08:21, David Marchand: > On Mon, Jan 19, 2015 at 3:45 AM, Zhang, Helin wrote: > > > It seems that your fix result in cannot launching applications. > > I don't suspect the correction of your fix, but somewhere else needs to be > > corrected together with your fix. > > > > Logs: > > /************************************************************ > > RING: Cannot reserve memory for tailq > > I have a quick fix for this one (rte_malloc_socket refuses 0 alignment), > but looking at the change, I would say there are a lot of places to be > checked. > Were those places checked during review ? http://dpdk.org/browse/dpdk/commit/?id=2fc8d6daa4c7a This case demonstrates that an Acked-by line is not always sufficient to apply a patch. > Kerur, did you run a make test ? > All tests fail for me because of rte_malloc_socket. My dream would be to have a machine receiving patches, applying them in a sandbox, run some basic tests and reports failures. It should be fixed now: http://dpdk.org/browse/dpdk/commit/?id=8e3e06501660 -- Thomas