From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98C1044090; Wed, 22 May 2024 22:44:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 690A2402BB; Wed, 22 May 2024 22:44:56 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2063.outbound.protection.outlook.com [40.107.237.63]) by mails.dpdk.org (Postfix) with ESMTP id 77467400D6 for ; Wed, 22 May 2024 22:44:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ejdPXMASW4TPrnF49ABIj7taveVOp3XItHeH3sJN755MQCT/AuQ83M+vOVEe3NcUhIVcpjnoEx2+u8k7z9tBeGQ3u10UnQELxfIywBeX1tnI7BEzhwK8+myKXPjzvIAkZ9+XynPmLRtpzKxxRJie+LdoahPaSxLltYiqlY2yvCB91qj3gjYVTt8Ekj+TJhXfBX9tO31TX1pEwghEvMf0u2Sx1p8kstX33BEOAtpgylY9ZcCj4zNet0WON28YZTAH5yFgBn9enZ4BupRBKQGwiBdkirzZuODzYVUvB5bNFDntoCm/hwtPUCKUHbrh9dA3Cnb0s/gGrxiIGEzu64rISg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1Ap607cX1tMwx22Cx7rrjLsdnupMzfSZmMSuBuFg8ZU=; b=FFSRKcAnDHVpVck2rn3haKRVkmiwkoA2uRAD+hesJv32fWFhDerEQMVMbWLfNIC5zu15IgsZiyz/dLokv/YfbHDAqB5kqM1G1nwNgSAMnqZlY0y6Sx2gtmpKCdhEaMO6IGpLPal/b5hrRQDoYRcIgtlDZjd5zxhlZm67HGrN95Gy1u8t+K4sjRjoKKSmY7pNFuJ5vIpXJGzP5en9rCUCYUNtV5aJpv7fO5F7rUWbsmjQQGDpaThVo4YTnPmk3VXTGUNDXtvIkMEO9wb7qOqIkYvKSstjsvQa7OUVdr06EPO2xHfS4mE3o14OXqba7CmU6IzYvVcpedySO/Q8rpeORg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1Ap607cX1tMwx22Cx7rrjLsdnupMzfSZmMSuBuFg8ZU=; b=2O7hoz11/QhA8qkK8+zxsoF/xvEeB1Er5ty3Cc4BZZClcVd9vE0KG10IV9ja/5yZKrwDUk9gIKEGK+jJlT8cMZWSzjmMwAQK6VIBhJb7KMj6LWmu8Rag3MHzEyDKg7o0n95w+iu31BRmm7G1MMilhyS+qSVlO2mk72Ukyr8mby4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB8115.namprd12.prod.outlook.com (2603:10b6:a03:4e3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.19; Wed, 22 May 2024 20:44:52 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%5]) with mapi id 15.20.7611.016; Wed, 22 May 2024 20:44:52 +0000 Message-ID: <7028d418-20b5-4e87-98c8-25e3bc686552@amd.com> Date: Wed, 22 May 2024 21:44:45 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] ethdev: support setting lanes To: Damodharam Ammepalli , Thomas Monjalon Cc: huangdengdui , Ajit Khaparde , "lihuisong (C)" , roretzla@linux.microsoft.com, dev@dpdk.org, aman.deep.singh@intel.com, yuying.zhang@intel.com, andrew.rybchenko@oktetlabs.ru, stephen@networkplumber.org, jerinjacobk@gmail.com, liuyonglong@huawei.com, fengchengwen@huawei.com, haijie1@huawei.com References: <20240312075238.3319480-4-huangdengdui@huawei.com> <5d2ab42c-4b56-4a40-8e0c-3ac9a5e34ec6@huawei.com> <4326199.QLehXeTyEo@thomas> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0120.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB8115:EE_ X-MS-Office365-Filtering-Correlation-Id: 9b50f935-e291-431f-481f-08dc7aa0075e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|7416005|376005|1800799015|366007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?STBaRGJvc2hpQ0RnWTczOUE4U2tuRDJhZUZ3RmQwaWw3M1cxU0NCYnhYc3Mz?= =?utf-8?B?UEwwMWV5cmtCcVdPM1VVeElZc21uaGNPVzROVUtybS9Ud0J3bGZJNWpJN3lj?= =?utf-8?B?cG1jSkhRTlc1VzlQemxSWFZrRjhaWkJDeTdraE9nc3lUQzRORjhHZjBMZ0Rj?= =?utf-8?B?N2xkKzVhbEJGUWd4aEhKMUVFaldPeURWN0l4VmtmSFRUTGtOd3dJSTAwR0Jz?= =?utf-8?B?dGZhZ1JMeWlpeEVFZTZCMUxDaGZhK1ZQRElIOUpMZ2pIdFgxdWhUV25VVGV1?= =?utf-8?B?YnlnMUZLS3EzN0l4ZU5EcmRyZERZUmNzQVg5Ym9RV3FPcjZEcGtWbmNwU1Na?= =?utf-8?B?N0Rqd1V1dU5YVTZIcnJJNUJrWlpaRUU5bGdnVVI2bU4xZ09WU0dqK05Xcm1S?= =?utf-8?B?OGs1ZWV4MTVCa2tUZVFFcndQTEZSMDN1bW1xTW5KcERXalloUit6RkJHU3VX?= =?utf-8?B?WFpKaUEyUFRGbEh2YXRmOStiVXI1a0dnVGF5TVlmM1BPVlhmUTQvdjQyNzNJ?= =?utf-8?B?QjVsKzByV05rR1hOS3NzWG84ZUVZSnVDSWdHeE43ZzRPUlBMd0plbjBoWWtn?= =?utf-8?B?NUMzaTY5cE01WmhtWmF1NnRWNmtaemlmSW9KNzZ6R2pPOW5YUGwrUkpHaVl3?= =?utf-8?B?QlhteUZNem5BN28wQVJ2YWVkSVJPWlp1ZHlhNDBVaFBSTGVtNzN3TVlXcTZO?= =?utf-8?B?bGx5TzFFdUt4L3lEcDJvcVdMRzJqN0N0Q091bGRBczQrRHlCVmdXVUZ6dXJO?= =?utf-8?B?N3lWS0FCUEw2dmZaNGlEZURIM21yRGd2Qktxb3pyVytQemZYZDlYdnVrMW1k?= =?utf-8?B?dlpwZGd0QXp0bkJ2YmJHc1k1WHhjbFN6S09jL3pRdlVpVzQxS3NJaDVMOFpw?= =?utf-8?B?RzN5UndUY1V5OE5KWGZxOG9PMWwyb3dPR3Y4R3l5WnFqcUtQWlB4aGRZK1M1?= =?utf-8?B?bVozNUw3dHNBd0RRT0NKaWtYbllrZEhOUnRVU3NXZmFtWmUyUVZSaW12V1E3?= =?utf-8?B?WkZTVEVuNkc1VDFmOFhpODFSTXZiTVB6bmZHQ3hOVU9RSVFwUW9WbjNyVExJ?= =?utf-8?B?UktRSzFrQ2ZHN01DZVZjdEc4L0VMNlhCNFdsUE0xSXp5ZnNlTnAvQUl0RFpP?= =?utf-8?B?bFRFOFhyRmZwb3ptUXMwL2tXVFRkajZ2eDlQYkdGTlhvT09ReUozVDh6K1dx?= =?utf-8?B?V1F6WWJZOHpMYk42dkVaYzk2akFMYklaQnN4VFhHL1BydFMwbzdnU2o2TXV6?= =?utf-8?B?OFVNYzFlNTZoSFlEcHR0V0hBYUQ0dnlwSlZNdzVBMFN5TUFVZWJuMS9CVUMw?= =?utf-8?B?Rkl2akc4YjBwYXprTE1WVTlobkY1cnBjNGFua0NNTXBFSS9kOFhJczZ1STdz?= =?utf-8?B?L1AzWHJIaGJHZDFCSW1KUEYxS3JWaFFhVGZ4TmtWdHlTZmQ4Y1Z2bVhnTUI5?= =?utf-8?B?Q3E4Qm1QeFFhWVBrVy9nVkRKYzZWQlZkc1VWWGZROGZySlRHTFE0blNZUEgr?= =?utf-8?B?dGVwZHhhK0tmb3A3VHRTcGlWS3pOQUFROHJOTW9EZ05oR0l1ellOMTdUYnUw?= =?utf-8?B?MU5BNlI3YkNwL2t3ZGN2QTAyZHN2NFluT2t3bUJBQjAwTTFjL1ovNWdab2hX?= =?utf-8?B?ZkZLaGFhcGJWcjMydkJZZUZWYjNPUllsR0F5cW0yazl4UWtYSExMYjBXK0p5?= =?utf-8?B?aXd6M0xyODZXMDc4RkFLU3N4bFhVYW8rOS9xY0czVE9YVE11WUEyczlBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(7416005)(376005)(1800799015)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHdXcGdDZGk2ZGtaSm85bStJVnlJVG1DVnRqUWpaVWlVUTl4ckVLbnBGY3Qz?= =?utf-8?B?L2xKNzZHaXRYc0VGSXVBYkt0SUZZS0l6TFlraTRhY2I5YnhvY0tPUVd6NU16?= =?utf-8?B?ZDdLS05CNHpOckFBeEpSclIvR3lScWxraDJGT0wwWHE2Z3RtQ3J6S1dJUXpL?= =?utf-8?B?U2lheGtySlhiOGtjQVR1Z1g1c3lqdVRUQURIaVlKVW43VHU5N05NdUNxZmgy?= =?utf-8?B?K3dFUVZiWE1FN09uQzU0SE9vOFBCbFB5RUNieG1SZVNyYW9BdVg2LzJVZlhD?= =?utf-8?B?bWpWUktsM0dpb2cveTUvSnkydC9nSDRWQlg4R25ndzJXYWw0MmZUL1ZOM1hi?= =?utf-8?B?QWcxdDBEd0JOLzRXRUxYSS9WU1ZsRTNHNWRxRE1WZlpRQnl3TFZRWlNXaXVK?= =?utf-8?B?K1I3bmZrZ1ZsU3BTT2hQSGtSVTIzTWNLbU9BdTczNjFQN01tdGdldzAvU3g2?= =?utf-8?B?M0tkMWhCVXNrYkFDbXBKOEJXTHV6bjI0b0RWcFUyNjRTSlU0WENidTZOa3dZ?= =?utf-8?B?OTI5UzhLVGhlSWY2a3Zta2VHY1VuQ1FxblhFMHdQdmJVRHcxUFl1eW54eEl1?= =?utf-8?B?cFdlTFhWdE9FY2U0R242MlUzMVFmRGhYMER4N1Y5Z2YyUElncnlGdG5RSWN5?= =?utf-8?B?eW1MdUNwdHgrUVM1WWdrck1PNk5GRDZGZUY1R2p2NExVOVdEV0VpL0U2ZkJQ?= =?utf-8?B?dGhKU1RDbllKZk52S1h1ZzNsa2M3SEhrUko5cFZUd3NHMHlWMkpuRjF6RTc1?= =?utf-8?B?MVZZYXNCK3hyRHo2dFBka08vNTlTS0FDTUVWT3BxQ3VoUGIvNHhVK2RKbGlB?= =?utf-8?B?cFUvU3lFcFYxeUJiNnJCdlFqN3A4eUZMRUJ3VHVIUmNuN0FzM3pyc1dGL25i?= =?utf-8?B?Z1ZFQjNXZ2x0S2s0bXRJZFpSQVN2V1Jrais4ZDZCa0IwVmFDQWptVVB0TkRD?= =?utf-8?B?S3VNTXlVRkpJRXVCQlpZNklwV3JNUWh2dlRqdXhWVWlUdG5QUDJpdDAyYXFo?= =?utf-8?B?NzZkUFBpRWp6ZXRPbzR0aVhOY1lBYlBXNVdrd2UrVUNOVUpPWDV0ZUMyUTRM?= =?utf-8?B?R213K2Zacy9CUzE0SXR3bWZ5WTRXTzRBT2dLNEw4VnB6Qk1mVzF3eWdKcllH?= =?utf-8?B?M0dESFh4YWRqaTBmYThqeVo5cnhWTlFZNzdWQjZtS2NNUmdUcXNoOG1QQzA1?= =?utf-8?B?NXRJYTFaN25GWmlyNXpYaS9yckpNU2NSOHI2cExhajFQOVRFSG9aRnRTRUZ0?= =?utf-8?B?akFMeUFSU01vK1o3OGwwN25VTlBzTHlFbGJtZ3NaRWFmaHNBVXZob3RuYlhm?= =?utf-8?B?MWVDdXp6b0xiSXcvcXp3TmV4OUprTWdNTEFyQ0ZORHdLWFdmemFnZVdWRWpt?= =?utf-8?B?Uzg2WlVHNUFIQWhsUlRtL3RoSTFDOHFpSmU5WERvbFo3czJ6ZCtwRzJmUDh3?= =?utf-8?B?TFJVK1ovblQzZ1hhVGFBWjl1RTZwQVhMK1h4Q0gzd09QaTR4SzhHK3NzdXBK?= =?utf-8?B?SmRWYVB0dm1mcG9wakU0STZVR0EyelJRV3FVSWlndlptaVUvNCtwRFhsTk9v?= =?utf-8?B?RmtrVlFXcnlVV1hhenlHQXltTVV6MHcwMXRROEN4bThzUE9UcWdFWllHRTRx?= =?utf-8?B?c3R0YUVLWm5zdWRteFBzUHpMY0xLWUZrQUdtRlh5cUpxQXVCYi8zL0VUbmw3?= =?utf-8?B?NFFWY3A3dVovbmJQa2d4dmcrUWE0S1VSUWxneEI3aGdSMnBtYmdudWxjN0lK?= =?utf-8?B?K2RQcFNicVVBYWRWL0N2WTZKM0dJV2Z0aHhjZlMyZlE4SmJ4ZDBOTWY1RGVH?= =?utf-8?B?TzVUcW5wSUFJV0IrV0szRTRveUFtS25UT2ZNNnNnZ3ovWm0yMmZwZDJCNFRp?= =?utf-8?B?UnVtRWxhZ1Z2clZKK0VRSUpvRjhyeXZQL2Q4WTZPaFQycUpoWCtZY2JkYVJm?= =?utf-8?B?cmFZRTdDOTkvWGRJWW1RVUg4V0dXK2xuUk5HYldOL0ZOVzJicFFMbEttUjJC?= =?utf-8?B?VjRPQURneXgyQ25mZlBLUndoMXNJRHVaZS94Nk9zSzVyVHF6bFRCb09IRWZL?= =?utf-8?B?LzVMU2ZwSkJEdnJKVStueFBjQW9JM05NTm0zT1hKVzlxVjRnSGJFN3hmYXdV?= =?utf-8?Q?BblG+xze+89HXI4MJZ4kN8xXi?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b50f935-e291-431f-481f-08dc7aa0075e X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 20:44:52.0192 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7YRx5v+EkVJ+4UV3sF7KTiotuLo31WpgkBjH3MuTl5jVJYxaoNby4tu9Fv8JHl3B X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB8115 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/1/2024 11:29 PM, Damodharam Ammepalli wrote: > On Mon, Apr 1, 2024 at 1:07 PM Thomas Monjalon wrote: >> >> 30/03/2024 12:38, huangdengdui: >>> But, there are different solutions for the device to report the setting >>> lane capability, as following: >>> 1. Like the current patch, reporting device capabilities in speed and >>> lane coupling mode. However, if we use this solution, we will have >>> to couple the the lanes setting with speed setting. >>> >>> 2. Like the Damodharam's RFC patch [1], the device reports the maximum >>> number of supported lanes. Users can config a lane randomly, >>> which is completely separated from the speed. >>> >>> 3. Similar to the FEC capability reported by a device, the device reports the >>> relationship table of the number of lanes supported by the speed, >>> for example: >>> speed lanes_capa >>> 50G 1,2 >>> 100G 1,2,4 >>> 200G 2,4 >>> >>> Options 1 and 2 have been discussed a lot above. >>> >>> For solution 1, the speed and lanes are over-coupled, and the implementation is too >>> complex. But I think it's easier to understand and easier for the device to report >>> capabilities. In addition, the ethtool reporting capability also uses this mode. >>> >>> For solution 2, as huisong said that user don't know what lanes should or can be set >>> for a specified speed on one NIC. >>> >>> I think that when the device reports the capability, the lanes should be associated >>> with the speed. In this way, users can know which lanes are supported by the current >>> speed and verify the configuration validity. >>> >>> So I think solution 3 is better. What do you think? >> >> I don't understand your proposals. >> Please could you show the function signature for each option? >> >> >> > testpmd can query the driver, and driver can export latest bit-map say in, > rte_eth_speed_lanes_get()->supported_bmap > > 0 1Gb link speed > 1 10Gb (NRZ: 10G per lane, 1 lane) link speed > 2 25Gb (NRZ: 25G per lane, 1 lane) link speed > 3 40Gb (NRZ: 10G per lane, 4 lanes) link speed > 4 50Gb (NRZ: 25G per lane, 2 lanes) link speed > 5 100Gb (NRZ: 25G per lane, 4 lanes) link speed > 6 50Gb (PAM4-56: 50G per lane, 1 lane) link speed > 7 100Gb (PAM4-56: 50G per lane, 2 lanes) link speed > 8 200Gb (PAM4-56: 50G per lane, 4 lanes) link speed > 9 400Gb (PAM4-56: 50G per lane, 8 lanes) link speed > 10 100Gb (PAM4-112: 100G per lane, 1 lane) link speed > 11 200Gb (PAM4-112: 100G per lane, 2 lanes) link speed > 12 400Gb (PAM4-112: 100G per lane, 4 lanes) link speed > 13 800Gb (PAM4-112: 100G per lane, 8 lanes) link speed > 14 For future > Dengdui & Huisong mentioned that in HW, speed and lane is coupled, when we have two different APIs for speed and lane, user may end up providing invalid configuration. If lane capability report is tied with speed, this will enable user to figure out correct lane for speed. We already have similar implementation for FEC, for similar concern: ``` rte_eth_fec_get_capability(port_id, struct rte_eth_fec_capa *speed_fec_capa, num); struct rte_eth_fec_capa { uint32_t speed; uint32_t capa; } ``` @Damodharam, can you please check 'rte_eth_fec_get_capability()'? If we can have similar lane capability reporting per speed, user can provide lane value based on this. And rest of the validation can be done by driver. I will comment on your RFC. > In cmd_config_speed_specific_parsed() > if (parse_and_check_speed_duplex(res->value1, res->value2, &link_speed) < 0) > return; > + /* validate speed x lanes combo */ > + if (!cmd_validate_lanes(res->id, link_speed)) > + return; > > Driver can validate the rest of other internal link parameters in > rte_eth_dev_start() before > applying the config to the hardware. >