From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E476A0C47; Tue, 12 Oct 2021 10:16:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04CD6410E5; Tue, 12 Oct 2021 10:16:51 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 0186F4067C for ; Tue, 12 Oct 2021 10:16:49 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id A53367F519; Tue, 12 Oct 2021 11:16:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru A53367F519 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1634026608; bh=TKpEh1ogXX+D22uCqjN7rfcahQ00EsSjnjni0eNB5no=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=Mjwj18Uj0N2e/1AeUHpjD960OQCEG8WDNfokcVRAeZ+3NCZxQ3rPE3JeNAAf4IEVO YPel2k9kYC+ZLKboFHGyCrPQdT1riAVgE65mYsMZjh+OjQpvHLHUaLzE6fGKwjbvMv aj40XJs75AIQQy0CL9ZHp0F1MCpp8+J6v3Izb248= To: Viacheslav Ovsiienko , dev@dpdk.org Cc: rasland@nvidia.com, matan@nvidia.com, shahafs@nvidia.com, orika@nvidia.com, getelson@nvidia.com, thomas@monjalon.net References: <20210910141609.8410-1-viacheslavo@nvidia.com> <20211012080631.28504-1-viacheslavo@nvidia.com> <20211012080631.28504-2-viacheslavo@nvidia.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <702952b2-c3f9-3c8a-261f-9e97787f99cd@oktetlabs.ru> Date: Tue, 12 Oct 2021 11:16:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211012080631.28504-2-viacheslavo@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: update modify field flow action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/12/21 11:06 AM, Viacheslav Ovsiienko wrote: > The generic modify field flow action introduced in [1] has > some issues related to the immediate source operand: > > - immediate source can be presented either as an unsigned > 64-bit integer or pointer to data pattern in memory. > There was no explicit pointer field defined in the union. > > - the byte ordering for 64-bit integer was not specified. > Many fields have shorter lengths and byte ordering > is crucial. > > - how the bit offset is applied to the immediate source > field was not defined and documented. > > - 64-bit integer size is not enough to provide IPv6 > addresses. > > In order to cover the issues and exclude any ambiguities > the following is done: > > - introduce the explicit pointer field > in rte_flow_action_modify_data structure > > - replace the 64-bit unsigned integer with 16-byte array > > - update the modify field flow action documentation > > Appropriate deprecation notice has been removed. > > [1] commit 73b68f4c54a0 ("ethdev: introduce generic modify flow action") > > Fixes: 2ba49b5f3721 ("doc: announce change to ethdev modify action data") > > Signed-off-by: Viacheslav Ovsiienko > Acked-by: Ori Kam Acked-by: Andrew Rybchenko