From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE9EE43EE9; Tue, 23 Apr 2024 12:07:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B8CE40E54; Tue, 23 Apr 2024 12:07:20 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 19FE5402AB for ; Tue, 23 Apr 2024 12:07:19 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8614A339; Tue, 23 Apr 2024 03:07:46 -0700 (PDT) Received: from [192.168.50.86] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 790023F7BD; Tue, 23 Apr 2024 03:07:17 -0700 (PDT) Message-ID: <7031d5c4-af27-435d-9451-50e40cc43356@arm.com> Date: Tue, 23 Apr 2024 11:07:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/4] node and inheritance improvements Content-Language: en-GB To: =?UTF-8?Q?Juraj_Linke=C5=A1?= , thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, jspewock@iol.unh.edu, probb@iol.unh.edu, paul.szczepanek@arm.com, npratte@iol.unh.edu Cc: dev@dpdk.org References: <20240423091252.62924-1-juraj.linkes@pantheon.tech> From: Luca Vizzarro In-Reply-To: <20240423091252.62924-1-juraj.linkes@pantheon.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 23/04/2024 10:12, Juraj Linkeš wrote: > There are two areas that are unified: > The super() calls, where the arguments were removed as they're not > needed in single inheritance. > The classes derived from object don't need to explicitly state that. > > The tg node execution setup and teardown was omitted and is fixed in > this series. > > And probably the most important part if the cleanup of execution and > build target setup and teardown. Build targets are relevant only for sut > nodes, so it's been moved there, same for vdevs. The execution > setup/teardown code was modified so that subclasses use super() to > extend the base methods. Hi Juraj, Thank you for your submission and improvements. It all looks good to me! Best, Luca