From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 790F3A00C3; Wed, 7 Dec 2022 16:43:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5DEFB410D2; Wed, 7 Dec 2022 16:43:55 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2073.outbound.protection.outlook.com [40.107.244.73]) by mails.dpdk.org (Postfix) with ESMTP id 1ED8040156 for ; Wed, 7 Dec 2022 16:43:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mOOedYGfCK2s3WglGzakDYiLjKXHvUMNu5iYQinSUHzUdWHoNssC3+mF/iZjcmuWMn7UZWAC7a4heM4CuJPrvElmQ4xEs8RNshimAjr3lxozpKEhFs/WafkG29V5ARuSd3lwAp4MZpATHBZ4lM1bY5Q7uUvUmKW4Ew0lDlga+K62jcu2yb0nT44tEhIl1g6SsyeFpSz96ovggpNVdMyu+QSiKjdr6uSQFUJQfORGQDLJtRta0hDqnAJA4j97+N1A01cKRwwfKZlF2y9JBf7pMNta8sTXCB+xrKMTk8eQtjzrNgYeYoUWzpwUp6GtdrdfBx0QqG+m7acaAdyQKJp+AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+nYKjzOnHmg6EL3vrtRBylPsI7g0eJN2CgLbTtsJmCs=; b=FQbmiFQSi2WXJht6FYvR89Qzd51kwOE15BgnE/FjpwjBCc7PnXTmZH85sXeaZQgy0BXl8jGUaFfQGrzX3XXD0N7iPHimuDRZoul6j3skHqHuZ0CebvVHLITdLCBZGx/PyYF5pSoJjpK2YhbdYsBhpW4sFP/V4l0zlSoWPVB7EPv7xhJPldF/7gPCCG8Zg4jE065LPPXIUtOVv78LIQb0FJOhkY7hqjvDp0eZnh25dkM4ES/BgIeKtg+dq9Y2tsx2AAgXC6Eeuc42rBTfHLXmpdwOLOtyFBplVRFtNQOU58Y2gwTm/G2LylC754NAkCtdH52p0yJi+nIjN+cScSyHfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+nYKjzOnHmg6EL3vrtRBylPsI7g0eJN2CgLbTtsJmCs=; b=rE8UyI4DJV/rJ20REpqle0wRK9X00pF6FjW/jf1uWvyggq6Uksd+YlmjyVO8Nyzso1Ssd9+8EB6CkQumpgkCVKvofzPo6NruaMm7wxrW6+owDfkTIk8Y9LSMOLETtcHiIqYE9aXb0JRAS3RLwxnxwQ6SxAxVld+CzhQ4VTAsX8A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BN9PR12MB5273.namprd12.prod.outlook.com (2603:10b6:408:11e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 15:43:51 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%8]) with mapi id 15.20.5880.014; Wed, 7 Dec 2022 15:43:51 +0000 Message-ID: <7046cb75-75e7-8be6-9efc-f37b70a1f2df@amd.com> Date: Wed, 7 Dec 2022 15:43:47 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2] net/memif: change socket listener owner uid/gid Content-Language: en-US To: Junxiao Shi References: From: Ferruh Yigit Cc: dev@dpdk.org In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0174.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::17) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BN9PR12MB5273:EE_ X-MS-Office365-Filtering-Correlation-Id: 30bb9d31-7f71-4bfb-f013-08dad869d6cd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Sk9LAa3vIDikVwGhnyJsnMHzEEVHTWdJdSRhfKDkts3rfmWa+qOPSmyah34wK1MkEONIm8us0OaarR/NrMCchZ5YV/cfgU6Ec1C8zvRDRKaTDQ5oBxiJZQtDW9gYrIslpYYcqym1lk04lT9LZlWAEqM+UfsEU8wAaDcq/XM8Lq4sTCteUGl31laxKBsqGNUbVEiAmpG4CHxgbNLzPZh+MWugqBprVdS4Wc2MMdoGb0x9UOrzzI5xEqIKF7i3o7JLXHC00mKAhpd7qblFs1J+sbex8ya547hrNMlRbbQDRY7561iXSx3G59Vf+AK5Wq85nXXTS5M2pUKv68uqWq3edH3GOKiVpbokpgNQpFEcvnmadafKnWI1omAfe5QGFNp/6fAj3xnCn8itiZg+I2TtsJF08wkFOhbWCFMiOHG6ompA4PzvHTY/NAdrDrLJt3Key+S5JGZXXz+6HnUrwmpeQWc9BmK1zzo3aUYXkAhGwjGCH1urdpYGFE3APmC4kkMpDnrgSUUMwae/tNd1LLhOvU3uO2xaZwHtZypyWKV4i5PSPdtLOHAngKTKQtdFX8NOpES+KZHA9gqRJFyyBNtKfbr8I/wj4hcFH3vTPRnQlWXrKqZYqIXdVrP5k68xDJ0qpVwJyB5QsrdRfRDVWxSI6j2pStAQj/RRab9Ot5p959f8Teiy1TKEl8euou44ZjMg7QlhDI3BOmeaklgUaYWNV+GYkYcXLXkxVLifJXScUiY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(136003)(366004)(376002)(346002)(451199015)(83380400001)(8936002)(31696002)(86362001)(44832011)(2906002)(4744005)(5660300002)(4326008)(41300700001)(478600001)(186003)(26005)(53546011)(6506007)(6666004)(6512007)(66946007)(2616005)(8676002)(66556008)(6916009)(66476007)(6486002)(31686004)(316002)(38100700002)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUFiUUg1dDNpb0N3RXhnc1d3WitsRmJuMlMzb2VZUXFVeHZBTEZXajdZQm1N?= =?utf-8?B?N1FhcUdwUXhzM2JtNDdBdW9rRXBKam5GRStKSExxckRkMHJNU1pEM3NBWVFV?= =?utf-8?B?djVUaU1wVitVQlJzdzhMeUE0dUtuWlpuOVcxQ3g5ZUhuUnRjL3Z2Tjd1TFZZ?= =?utf-8?B?b05RdmV2ZUhpNzBEUEdkejhoQnRDalA4cVQzR2JXOFNEN2MyNVFkMjU4UEV0?= =?utf-8?B?SWxaaUg1RmJNNURScGtzOFU2akoyVFduWjVldVJDWGZLN0VycGhQREt3M2N6?= =?utf-8?B?QVFOZHFJbjZNVlRoWlBRTStoa0JVdW1GV2cwQkVHS1dFZ2tiRmFSRkg4dUQv?= =?utf-8?B?bFROUnBYaTkxS1plUndwbWcxQnRUMjBlWE9ReFBYT2xGUWNPNXBSbFpOb004?= =?utf-8?B?bk5ORXpKaFJQbFgrOGl4MkVZcG9NUEJFSFlEbWJVbHE1b3dFMzV1NjhGMXFu?= =?utf-8?B?UGVUN0FpR2xpM2JLcUlvQW8xbkVlWGlOd3psR3NvUGI5WWdJc3NzYU11RHpQ?= =?utf-8?B?bHFOY2ptMjU3Zk4vdC9OSWdDYmhrK0txdUpIL2crTWtoci8zdnRmclp4T05B?= =?utf-8?B?U3B2dDE1SDRsMm1EK3RSbjdiQys5dFRDZ0ptTk9KektDcGl2U2RKUkhNNkpT?= =?utf-8?B?OXFUZ1V0bmIxRnZmdlZ0WEpZTUlxSVRGaGQzbXgzajFZM0ZuQVpsa0pzWGpt?= =?utf-8?B?bk81bVBMTStlU2twcTBOVTk1TGd6ZUYrNzJCVTlSbmtkdHY2YjUxQk9KMEdM?= =?utf-8?B?RWVTZUpodEtzUCtnd1lxOU1LZ2g5TFdFZFBoYWtmTnROOUN1SDhaMENiczVB?= =?utf-8?B?Zkl6SGJMaGltYUdUMFdoQThONVdWK1RIRHBDdU9ab3RUUWZhb1lMSmhaQm5h?= =?utf-8?B?VXEyRS9DMHFoazl2TDh1NTlkRG9nYnZ1YU0yaDBqaWd0aUZldUpIYkpidUlh?= =?utf-8?B?VURTa2luWVFsYWp3RVh4WTRtYXpmc0cvQmwvWGpFL3F2WWQrQlhsYzhZbE9E?= =?utf-8?B?dVhqQjFQbzhKVmJwVzdvTnFPcENpWDFLUXhoMGk5S2xkQ0l0OVNxVldTMDFQ?= =?utf-8?B?TnFEdk8zQkRpeExKeC9NVEIzOWFkelQxOHZtSUZOaCtYZG1rZjhEQm53Yitn?= =?utf-8?B?QzFPa2VHUGNaZWdvaHVHOW1ZTC9tRkR1clZoeVNyYjkyM29oOFJXMDMrRlds?= =?utf-8?B?VUh3WVJuM0JoREJKbHNqeWttMEFjWExhZ283VnZIN3hYSTVDY0VNQW5VN1Ux?= =?utf-8?B?Mjd1dzcrQVAyYk5ydjVMQVN4ZzF1dTlDMHBTT05ldzRGdWlILzZVVXpJWGFK?= =?utf-8?B?RW5NdkZuUS9xcy9lc1dtYUNvWEllT0xNZUpydWVSOHdBT3pUWkhkNVZXTmgr?= =?utf-8?B?b3IwNDdmRXRLZjJnTTZNZDhDUDdVT241QzNGOEpLTWxNMCtUMmJ6RkVWTnhy?= =?utf-8?B?TlE0djEzSmo0Yzh1R2Z5WXJTMVpxWG1ZenBUYW9WUkd5bi9TTzhWcGxDNUZO?= =?utf-8?B?T09QTVFlMVV2MXZmT3hPSWRIU3ZwbGZCblYrdlh1YTl1Sm9TY2tSV3NNZE9r?= =?utf-8?B?Vlg1aHFtdm9tMHdiZG0wKzNaVlZaQS9ZS2FldEZTc0srRHRLUzVFZTg4WEk5?= =?utf-8?B?OVpBZ1ZFQjdFTTRYMjR1WnA2Zk1XeVQ4Wk15d1NUYzBYNnNuUUZTNXhQT0tV?= =?utf-8?B?aEVJRTlKc2s0NWt3a05RR3ZJalZLd3pZd292eEtxalJSaG1pcVpHUWJhVE40?= =?utf-8?B?RjdIdHJGZ2NjSDVQTTdaNFZkbmx5VUk1UnhwdW9DRUJ6TXM3VWNNaHJ3ME5X?= =?utf-8?B?djN4NDVaYzM1NUZwQmpSNWdINlYreVVNRE02MXhtN1VFSjBkT3pKRmJPUkdW?= =?utf-8?B?UExKMjg2d0dhRVJsSVVTTEFZVHRIUmxUNzllVUZFNmVsUmtUMnp1V2FoOVhX?= =?utf-8?B?b1RkK3ZUSXJ5U0RBMnZNVXd4WG9WbjdwMnZmTjFNejB0N3d4ZWRBY2UvOHdw?= =?utf-8?B?OWw0ZC9sVEwyVFlqSXZRUFZDdHJ5T0RtTTl0clVOWmg1S2p4eTUvZFVpUFZ1?= =?utf-8?B?U2x5OVB2L3FYSmtXZnJrNlIwR0tpaVFNMW8yWFdnZzRGbk10dGRDSEdrUGRE?= =?utf-8?Q?P2MSYWfGVGHGEoWBWCZj+/Jdx?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30bb9d31-7f71-4bfb-f013-08dad869d6cd X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2022 15:43:51.5519 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 82rX4wKslv0wR07kYIN8AqAzyLBCPkGY6xXV9fzeQJjVuscGJJLXsqawQx/h8BYh X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5273 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/7/2022 2:41 PM, Junxiao Shi wrote: > This allows a DPDK application running with root privilege to create a > memif socket listener with non-root owner uid and gid, which can be > connected from client applications running without root privilege. > Do you have an easy way to test unprivileged memif client? > Signed-off-by: Junxiao Shi <...> > @@ -1827,47 +1859,58 @@ rte_pmd_memif_probe(struct rte_vdev_device *vdev) > flags |= ETH_MEMIF_FLAG_SOCKET_ABSTRACT; > > kvlist = rte_kvargs_parse(rte_vdev_device_args(vdev), valid_arguments); > + if (kvlist == NULL) { > + MIF_LOG(ERR, "Invalid kvargs key"); > + ret = -EINVAL; > + goto exit; > + } Thanks Junxiao for updating this, but since it is not really related to this patch, can you please separate it to another patch?