From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0074.outbound.protection.outlook.com [104.47.36.74]) by dpdk.org (Postfix) with ESMTP id DA3691B1B0 for ; Tue, 26 Sep 2017 11:21:34 +0200 (CEST) Received: from MWHPR03CA0046.namprd03.prod.outlook.com (10.174.173.163) by MWHPR03MB2703.namprd03.prod.outlook.com (10.168.207.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Tue, 26 Sep 2017 09:21:33 +0000 Received: from BY2FFO11FD007.protection.gbl (2a01:111:f400:7c0c::149) by MWHPR03CA0046.outlook.office365.com (2603:10b6:301:3b::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11 via Frontend Transport; Tue, 26 Sep 2017 09:21:33 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD007.mail.protection.outlook.com (10.1.14.128) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.35.14 via Frontend Transport; Tue, 26 Sep 2017 09:21:32 +0000 Received: from [10.232.134.49] (B35197-11.ap.freescale.net [10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v8Q9LUkU000852; Tue, 26 Sep 2017 02:21:31 -0700 To: Pablo de Lara , CC: References: <20170913072026.29734-1-pablo.de.lara.guarch@intel.com> <20170922075519.28342-1-pablo.de.lara.guarch@intel.com> <20170922075519.28342-8-pablo.de.lara.guarch@intel.com> From: Akhil Goyal Message-ID: <704b3160-6a7f-a30a-1072-de23d15a06f1@nxp.com> Date: Tue, 26 Sep 2017 14:51:29 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170922075519.28342-8-pablo.de.lara.guarch@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131508912932465803; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7966004)(336005)(39380400002)(346002)(376002)(39860400002)(2980300002)(1109001)(1110001)(339900001)(3190300001)(199003)(189002)(377454003)(24454002)(316002)(76176999)(50466002)(53936002)(50986999)(54356999)(6246003)(106466001)(498600001)(58126008)(356003)(2950100002)(110136005)(77096006)(81166006)(36756003)(8676002)(230700001)(23676002)(229853002)(85426001)(4326008)(86362001)(65826007)(5660300001)(68736007)(104016004)(33646002)(47776003)(105606002)(31686004)(97736004)(53546010)(83506001)(65956001)(2906002)(64126003)(65806001)(81156014)(305945005)(31696002)(8936002)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR03MB2703; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD007; 1:IDgjx71Y5eqwdHTVoirxss4+ivc2K/ULsrGe472HVRQZYmuNoVVFMoldv8+orTJf0+Wi06iqdNhteLnw8XaEIW9A2RJjS7cWfkQaegG+PE6/K9RqJKaTX/PV2n6zcr7W X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 25e7462c-227a-4a05-c022-08d504bffa84 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:MWHPR03MB2703; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2703; 3:t+RnlfVb58G6OYZ5gaEeuo8JMaW/BIKqsAkz0uSSBp+cr0zuFtyFxxXpezrhwpRGVnVcJ3ecg+Je5R4hxCy8VjTR+u+BmPNSeJxeuMbsoMH0q3iUfilLj8w4/JcGm63rjhNzAulqloJOp+XHFutjqVt79OmpfNy59PbXMplxO8RdZJSJ6B8CBCLhFhiZJZpXyIJfqCLmUKJ7vavGjpsCiBiW3qGSdrBIcCRq9ZqhS+BC2PsCYW0KCq3td1z3qefrhmYCaxxJkrIqMR05LXgzSkHCh1g04KGDPThBYvc2HchkqpqG3n9XRNxv5e+ghb/VsvTH3yTODXmy9fqtpQlzE7FymAdoLh/u8jh/HQuUPwA=; 25:gi8ZJ2xxdgbJs9Dwc7ZJPzhqMK1fXeyUwU1JQMbH5qUqS0Y3nSjYoFyYhmN4+fHbfTwdos2mgit/IyT6/arBU6CFGkTKXTfCvGQ/RBbRLzNBCcDUK1Cp9KHTgeeMtcsTbzsgGzVE1yLWe5wCsZ6imUygEawwlSu7PoD/yN+O7j+bMm3bOrFYg+sKG9/FIUp1fix5U9wEV8DaJHONQ4d85XnrA8valo/tPknsvRkCqSZhUI6cgBq3FJv/T9BG/B398ugPPicxxxYt/9kfV8qNQ+cs1Y94rNDUyTRZ3hisolPsPJRpGQ4gvYfGW1v8LXGt3qKAXjxzDhTeWvT9nNUvmg== X-MS-TrafficTypeDiagnostic: MWHPR03MB2703: X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2703; 31:KUCrknpV0DZB+3oForrQwOPsxEeQvr5T8cBLg8q8fMdEfSez1SArID++ND7BbA/UixBBst5wJQ1W9N08b4h71PjElthV2G5Tupc3SQKh27vcj/rxSgJbin44LrWrRA/7ph4jp/aEie7WKwhA4ihCVYPNhcp/bLLY8ROlPqA+hR39Lt/quab9lFtWFt7RBO5ntHLELgeAQNpPOFGzBW0X1RcgELGoWPH1sQh0cNKh5hA=; 4:2bfT2WnjsXFQ5Xp/BOf+h5N24YtRntQ5mMK+y5j0zXL2WY2wvuEkNavezCfUts4gL4BKdTFoayb7ksu6GKkgjUeEvgulDO5W4icHE9s9vnDEdQh5fqn9Eb4qoJb/7V3eThXSPi4zXbfsHhO3MYs8FBM1rrbM/uUg8smBAc/9SgVkX/SPsMHTdP0yn3uFhwQ89nrwDzpht4I81J94xijcgqexfMI0/mFOpTACoXvrAC9kcPKAjWRsjEVsX6b26T7c/pta51OgM8By84OiQ5kj1o236lmdnTA+c4mZhg6jvP4= X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(6055026)(6096035)(20161123561025)(20161123559100)(20161123556025)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123563025)(20161123565025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR03MB2703; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR03MB2703; X-Forefront-PRVS: 0442E569BC X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjAzTUIyNzAzOzIzOmJyb0xaU085WExnNXpya2hhTUo0aGd1T1R2?= =?utf-8?B?TWVmaW8yMUx3UEJQTzFvajNMQ0VXWHZoNVVhazAxQi91V0JibVQ0OFptTkNt?= =?utf-8?B?UnYwZ3d2a0pPUkp3UHh4ZFNOWXdJZDM1UnNKb1E1NGJPb2hUTzFIUjZYQkFh?= =?utf-8?B?c2dvVlNlc0ZxT0hwV0Q1SUpneUsrZUZPYitMTEdodi9KMW1WVzl4UXpzcENw?= =?utf-8?B?cHdDeEV0R2R0Y0tPQjcvN3lUQ2lWMEhCdWRVQ3BMU3FvOU9xbVk2KzRES3dN?= =?utf-8?B?bU9neWltQ3Q4NW1pZldpZFg0SURjdElZd1ByMHdaQmNueDg5cElhd1JTUjZ3?= =?utf-8?B?RkNIYlVVN0JBelBpenpUb3BvS3RrdzNwZFBESmVldDY4N09aS0xvWExzU2Fv?= =?utf-8?B?bm5JcENMTXdZcDRjQlVKUU1GVUJtNzU2MjMvOE80cGVRQk5ZNENIRjNuczVH?= =?utf-8?B?a2RpUFY4NWJkSEZxZVdrOWpqQnFpeldSaE9ldG11b2RFN0hONDM5WUsvU2Y4?= =?utf-8?B?MGlRRDFKc1dVemt2YnVhV09GTytvZHRlclhiendETTg0ejRncUJpQXU5aDFo?= =?utf-8?B?RWFPZGRuRi9DVXJGUUdQT2dJOW03aTJVWjRxd0o2Q29tZDJFN080ZStKVloy?= =?utf-8?B?ME5XYjZseDRmZ0pXU29lbUxLWFdSNm1HcEhwUnhNS1huZmZVT2plQ2U2ejNW?= =?utf-8?B?WnFmRXFUdHlPUFlZRWtNd2dOb2l5R0RTUXhGZ2pyTGdIa0JiMjVoazFFcm96?= =?utf-8?B?bmJZOUg2YUwzenBmVllaMFBPbCtFTVNmZ1VnaW9RSWF1YW5RbWJKNkJzbTdW?= =?utf-8?B?eGxQS1krazdpdWMzQlhOaE4wRk9FbEZlVHpzN2FIcS8vOE45VTMxK3htUFU4?= =?utf-8?B?Z2RJVldjMER0Z1B3SnZFVG4vdmRKRVozTXFRMTM0eUZjME1mNzN6VVJqSkhQ?= =?utf-8?B?YzBCZHpoWXdFdWR6cXZmMzBlZ3JTcXVOSVJaZDhMYjVqbWZYOW1GbTd5VlYz?= =?utf-8?B?clZyV2gxNkZlMzhVK1ZZbGZLQ1hkT1F5UHdPb21HdjBSZWhpRHNmblQwdXlr?= =?utf-8?B?QkhWRXRxdTY5bW9SL0g4V25BRE9vdGU5ZTB0bHlLYzRnNUVyQU1hMGM2a3Y4?= =?utf-8?B?TEJvNElXeGN3L2JvaVNHOUM3eFdRNEI1R2tiakxmRjZIbUNVa2VRdEcrdWY0?= =?utf-8?B?N3BVcENRdGw5RVNVd0V0M09pN1h5RXlWbGU3SDR0aU9BcUUwS1hKYm5xU09k?= =?utf-8?B?VFREQUlhRWJ3bUJtUWY0NGpmY2sySUFaZmJOMm42akpVQ1BWN0pFLzZid2tI?= =?utf-8?B?WU9GZnZ3M2MrTXZ6aWpkb3VQbitzcTI5dThiOFVJVnAvaUJiSDJVOWZ6Q3lJ?= =?utf-8?B?cGpXRFJodjJSM09uVHVsSVZCRzU5SmQ5cWFvOHdQT1NqSlREN25xUjZEZ0Z3?= =?utf-8?B?YWxCUWZnMkpsdkdNMVpIdUdnNGkydDNHNGc5dUNvb3dvOXpCam9UY0VFTlVX?= =?utf-8?B?RjZ0Z29vYlptRFlDbUU2QlNVbWRySnBGaURiMElQbkp0UlN0UnRxWHRUMndm?= =?utf-8?B?bnh5OU9iMjlHbkZEK0YvTEpZSkJrbHZBTTBDbTdVdHFxbXZMMjVTOENVQ2dq?= =?utf-8?B?MDFaU2RUOWpQK0NRWmQ3LzduZFhBaXhudG1rZll4T24ra3hrTUFDcU16SjRa?= =?utf-8?B?UGhWVFMwLzVTTlhDVFhOT1kybDhVQ0ZHd3JBejJvcWNzMVJidFhxRVk4amFK?= =?utf-8?B?c1ZScERCdWFSYlJyR052ZmxUOTlFMS9LSnE2dFovVnpGMnVPdHk2N0pyYzI4?= =?utf-8?B?YnBIRTYvcnVnRGk1S01jZUlQVDBsTEJmK3Y5RTMvMHpod2RhRGlZR0IvOWVJ?= =?utf-8?Q?M19xPgijkOE=3D?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2703; 6:g466qoJPmgAc9UyqI3CPa9C+8jngbK73wpRcYPQ2mmxFP69YvKy1+ucn6YdomA4bk4xXFVKP1w2onPRCUbWHtGS20Shk2x6Ce35qCOUsGK1f3q9dVokkKZDGCGxHGwmBsQ/8F7OvVrTG8yqn6bYZdx6jAYZS5xvVLraTD1OVcQkTr5rpXXBaxEvYin/Vk+jUx6zgwcS+blEWVqcr5nYlZOem3/GwaXoLRo1+boge8wBMbOj/HXI5n4m+wdD1OtKC9qpbEdJGv60rxUcQixD6k5XjH7t6ecH6o5uFkNT2TUBOSzc2hI7i1DvSQEB+oHTIM4xZAinZoAH/ADvMCTjtSw==; 5:WpeBvNN/x4xYc1uaRyZ9iNh75/wtGxDd1zzsa/944RUDyhxURnqHX+2aQUuYykXWsUS6tyNaHGH50vTMLVHtYnp+nmLv4+GEfe1kADWDO+vSGQ5MP02iDfoRrdvSxL1jl+qQ//yWhcwkI1ADTXWKXQ==; 24:eEG35e7skkIMk0zEd0Fteq8PUwYmDjcSWGng+XEU1EFDp+0K6KTAOHeIyHlBXzDOsZeA7vAXKdCpuW4UurVQh8u+Q34jLwx0DIzlLDwCr4M=; 7:x+L3sxSPHkXFxjMmWIh/Ab3eTua64n2+fp/9mZWb44Pv3qfOxI/HGGaKJpKnc+FjhqUyJvAKZhv1TI0sgzPPOcqUI7OFeE0w2/JiNuEOFMHSHfgmx4cphdtGvBukXf7tItPpl/NH8hAicZrygp7VH6LviCGyax3g4ZhKeSsNPHF6Z3wN/TnBS6hQAwYRIZogd0OjtkhGqNGSMvsfMZcmuArWtRJtRV8c2JkUxAPKXM4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2017 09:21:32.9189 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2703 Subject: Re: [dpdk-dev] [PATCH v3 7/7] app/crypto-perf: use single mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Sep 2017 09:21:35 -0000 On 9/22/2017 1:25 PM, Pablo de Lara wrote: > In order to improve memory utilization, a single mempool > is created, containing the crypto operation and mbufs > (one if operation is in-place, two if out-of-place). > This way, a single object is allocated and freed > per operation, reducing the amount of memory in cache, > which improves scalability. > > Signed-off-by: Pablo de Lara > --- > app/test-crypto-perf/cperf_ops.c | 96 ++++-- > app/test-crypto-perf/cperf_ops.h | 2 +- > app/test-crypto-perf/cperf_test_latency.c | 361 +++++++++++----------- > app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 364 +++++++++++----------- > app/test-crypto-perf/cperf_test_throughput.c | 358 +++++++++++----------- > app/test-crypto-perf/cperf_test_verify.c | 367 +++++++++++------------ > 6 files changed, 793 insertions(+), 755 deletions(-) > The patch set looks good to me. Except for one comment in the 6th patch of the series and one comment as below. Is it possible to move the common code at a single place for all the latency, cycle_count, throughput, verify cases. I can see a lot of duplicate code in these files. -Akhil