* [dpdk-dev] [PATCH] devtools: remove ethdev ABI exception
@ 2021-02-01 18:08 David Marchand
2021-02-01 19:03 ` Ferruh Yigit
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: David Marchand @ 2021-02-01 18:08 UTC (permalink / raw)
To: dev
Cc: ferruh.yigit, dodji, Ray Kinsella, Neil Horman, Maxime Coquelin,
Bruce Richardson, Steven Webster, Thomas Monjalon
Now that the ethernet driver dev_ops structure definition is not
exported anymore, there is no need for an exception.
abidiff will only consider structures defined in the installed headers
(passed with --headers-dirX options).
Fixes: df96fd0d7395 ("ethdev: make driver-only headers private")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/libabigail.abignore | 2 --
1 file changed, 2 deletions(-)
diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
index ab5db240e7..6c0b38984e 100644
--- a/devtools/libabigail.abignore
+++ b/devtools/libabigail.abignore
@@ -13,8 +13,6 @@
name_regexp = _pmd_info$
; Explicit ignore for driver-only ABI
-[suppress_type]
- name = eth_dev_ops
[suppress_function]
name_regexp = rte_vdev_(|un)register
--
2.23.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: remove ethdev ABI exception
2021-02-01 18:08 [dpdk-dev] [PATCH] devtools: remove ethdev ABI exception David Marchand
@ 2021-02-01 19:03 ` Ferruh Yigit
2021-02-05 16:48 ` Thomas Monjalon
2021-02-01 20:39 ` Maxime Coquelin
2021-02-02 8:49 ` Kinsella, Ray
2 siblings, 1 reply; 5+ messages in thread
From: Ferruh Yigit @ 2021-02-01 19:03 UTC (permalink / raw)
To: David Marchand, dev
Cc: dodji, Ray Kinsella, Neil Horman, Maxime Coquelin,
Bruce Richardson, Steven Webster, Thomas Monjalon
On 2/1/2021 6:08 PM, David Marchand wrote:
> Now that the ethernet driver dev_ops structure definition is not
> exported anymore, there is no need for an exception.
> abidiff will only consider structures defined in the installed headers
> (passed with --headers-dirX options).
>
> Fixes: df96fd0d7395 ("ethdev: make driver-only headers private")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: remove ethdev ABI exception
2021-02-01 18:08 [dpdk-dev] [PATCH] devtools: remove ethdev ABI exception David Marchand
2021-02-01 19:03 ` Ferruh Yigit
@ 2021-02-01 20:39 ` Maxime Coquelin
2021-02-02 8:49 ` Kinsella, Ray
2 siblings, 0 replies; 5+ messages in thread
From: Maxime Coquelin @ 2021-02-01 20:39 UTC (permalink / raw)
To: David Marchand, dev
Cc: ferruh.yigit, dodji, Ray Kinsella, Neil Horman, Bruce Richardson,
Steven Webster, Thomas Monjalon
On 2/1/21 7:08 PM, David Marchand wrote:
> Now that the ethernet driver dev_ops structure definition is not
> exported anymore, there is no need for an exception.
> abidiff will only consider structures defined in the installed headers
> (passed with --headers-dirX options).
>
> Fixes: df96fd0d7395 ("ethdev: make driver-only headers private")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> devtools/libabigail.abignore | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
> index ab5db240e7..6c0b38984e 100644
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -13,8 +13,6 @@
> name_regexp = _pmd_info$
>
> ; Explicit ignore for driver-only ABI
> -[suppress_type]
> - name = eth_dev_ops
> [suppress_function]
> name_regexp = rte_vdev_(|un)register
>
>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: remove ethdev ABI exception
2021-02-01 18:08 [dpdk-dev] [PATCH] devtools: remove ethdev ABI exception David Marchand
2021-02-01 19:03 ` Ferruh Yigit
2021-02-01 20:39 ` Maxime Coquelin
@ 2021-02-02 8:49 ` Kinsella, Ray
2 siblings, 0 replies; 5+ messages in thread
From: Kinsella, Ray @ 2021-02-02 8:49 UTC (permalink / raw)
To: David Marchand, dev
Cc: ferruh.yigit, dodji, Neil Horman, Maxime Coquelin,
Bruce Richardson, Steven Webster, Thomas Monjalon
On 01/02/2021 18:08, David Marchand wrote:
> Now that the ethernet driver dev_ops structure definition is not
> exported anymore, there is no need for an exception.
> abidiff will only consider structures defined in the installed headers
> (passed with --headers-dirX options).
>
> Fixes: df96fd0d7395 ("ethdev: make driver-only headers private")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> devtools/libabigail.abignore | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
> index ab5db240e7..6c0b38984e 100644
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -13,8 +13,6 @@
> name_regexp = _pmd_info$
>
> ; Explicit ignore for driver-only ABI
> -[suppress_type]
> - name = eth_dev_ops
> [suppress_function]
> name_regexp = rte_vdev_(|un)register
>
eth_dev_ops structure are not exported, so there is no symbol that is actually
changing here. The type definition _only_ will be in DPDK 20.11 public headers,
but is removed in DPDK 21.02.
I find it a little strange that libabigail is baulking when the type is changed
(see 1fe3eef5e9b) but not when it is entirely removed?
Ray K
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: remove ethdev ABI exception
2021-02-01 19:03 ` Ferruh Yigit
@ 2021-02-05 16:48 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2021-02-05 16:48 UTC (permalink / raw)
To: David Marchand
Cc: dev, dodji, Ray Kinsella, Neil Horman, Maxime Coquelin,
Bruce Richardson, Steven Webster, Ferruh Yigit
01/02/2021 20:03, Ferruh Yigit:
> On 2/1/2021 6:08 PM, David Marchand wrote:
> > Now that the ethernet driver dev_ops structure definition is not
> > exported anymore, there is no need for an exception.
> > abidiff will only consider structures defined in the installed headers
> > (passed with --headers-dirX options).
> >
> > Fixes: df96fd0d7395 ("ethdev: make driver-only headers private")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-05 16:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 18:08 [dpdk-dev] [PATCH] devtools: remove ethdev ABI exception David Marchand
2021-02-01 19:03 ` Ferruh Yigit
2021-02-05 16:48 ` Thomas Monjalon
2021-02-01 20:39 ` Maxime Coquelin
2021-02-02 8:49 ` Kinsella, Ray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).