From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9506A052A; Tue, 2 Feb 2021 09:49:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD4A62402E9; Tue, 2 Feb 2021 09:49:36 +0100 (CET) Received: from mail-108-mta57.mxroute.com (mail-108-mta57.mxroute.com [136.175.108.57]) by mails.dpdk.org (Postfix) with ESMTP id 7A7AF2402E3 for ; Tue, 2 Feb 2021 09:49:35 +0100 (CET) Received: from filter004.mxroute.com ([149.28.56.236] 149.28.56.236.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta57.mxroute.com (ZoneMTA) with ESMTPSA id 17761eebdcd0009319.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 02 Feb 2021 08:49:32 +0000 X-Zone-Loop: 30e03f621385a16d8b19fbbe60e15c0f3b40b1d901d3 X-Originating-IP: [149.28.56.236] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter004.mxroute.com (Postfix) with ESMTPS id 255323EAD9; Tue, 2 Feb 2021 08:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8cGLfNixWKftXeSInKfyfRx34+rWlLkhMkfz6Qqhxwg=; b=k52avSB157NlROi3RfR6mzvjDm 1PQmxfG3E0jzFA7/MbG2oEq0BLxdOPDBBkEB8HM1UPEGA/hCW10dnMlNWeYt8RuIaDvq0kgfntVVM 8sM0tENbAMbumMq59A61lxdzYr98VGO1f7bAphOMSShLWQNZ/02/37uV7KV3forv9kK7o73udgilG Q/VZOY++SzwUQ1iqmRt6J3PDHta8UZxvjFe8pu599qX91CH2TA4IGVdpMwNIK0Srel5lzNY3SHLiZ BCJrGmYwUkwtDLXUU7cX2mPwpN/8999XOKReO5K9dbbd52pbsl5EQSVEfogSNjyJWV0LNXRfXu4sv 4B/rSZnA==; To: David Marchand , dev@dpdk.org Cc: ferruh.yigit@intel.com, dodji@redhat.com, Neil Horman , Maxime Coquelin , Bruce Richardson , Steven Webster , Thomas Monjalon References: <20210201180852.1624-1-david.marchand@redhat.com> From: "Kinsella, Ray" Message-ID: <7052e621-1dac-df77-6070-f75b5a12367c@ashroe.eu> Date: Tue, 2 Feb 2021 08:49:27 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210201180852.1624-1-david.marchand@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH] devtools: remove ethdev ABI exception X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01/02/2021 18:08, David Marchand wrote: > Now that the ethernet driver dev_ops structure definition is not > exported anymore, there is no need for an exception. > abidiff will only consider structures defined in the installed headers > (passed with --headers-dirX options). > > Fixes: df96fd0d7395 ("ethdev: make driver-only headers private") > > Signed-off-by: David Marchand > --- > devtools/libabigail.abignore | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > index ab5db240e7..6c0b38984e 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -13,8 +13,6 @@ > name_regexp = _pmd_info$ > > ; Explicit ignore for driver-only ABI > -[suppress_type] > - name = eth_dev_ops > [suppress_function] > name_regexp = rte_vdev_(|un)register > eth_dev_ops structure are not exported, so there is no symbol that is actually changing here. The type definition _only_ will be in DPDK 20.11 public headers, but is removed in DPDK 21.02. I find it a little strange that libabigail is baulking when the type is changed (see 1fe3eef5e9b) but not when it is entirely removed? Ray K