From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id 91D605585
 for <dev@dpdk.org>; Wed, 21 Sep 2016 23:29:27 +0200 (CEST)
Received: by mail-wm0-f53.google.com with SMTP id w84so217478180wmg.1
 for <dev@dpdk.org>; Wed, 21 Sep 2016 14:29:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=uT6Jgs4Riz9EmzerhslN+ywyQKkiA8TQCYbrqOWEqzc=;
 b=gS97QdqQBK4zAK1ubC0/Ee9AmfkK63fsSafAYLnjR6zsQ8/XUJq/WUZtqpR49JrlNz
 MYKJm3Hf+Ez18SGrjkmJNw7Hyb0BPvvkmTZWq8B4r+L95GCzoM9FVzqwho9LNZ7qtkbJ
 3I3OHkgAUL9imxVJU1v9DpHwhxEvoTbyy+555KFMRnic1DwzruNbHTEM706OJub6JRYH
 0BNpcy2QJNVurryx5C1U+YWCiq+6BbbLEdhmkXubtBTRQYaa9PLskDp1h6WUaF1UYB6h
 aFp0iEZqgBhoh7aVKHL39aAahkj0cxuNMXxBfa8ST44cwdLaPT3PqijuECcB8KvhI6kl
 H/QA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=uT6Jgs4Riz9EmzerhslN+ywyQKkiA8TQCYbrqOWEqzc=;
 b=gZQyTa/5auYHIuTTRUws5C9Y1kP8A+VskPbtDmBVu+T8TTHw1MN7CPBRrsCoN1irc7
 zaf7Y6L70eCM2sXl2IHCaxfI7wxCSskKLRsvM7MCr9PWUxkS9Ibn+x1zkkuZO/+iSAcy
 mfdZoW8mBJdL/4CStPavYWdSjtlXf9lT/ZPFOnL8FS6kug9tt0T82c+HkFsPlzXTYudV
 uKmTiOgC11Dnk6g84HykULOt5R9VKTulIEr8GLcA2djX6WB3ROni7NItmPeiQnm5PrOH
 vbSZcGIHuOs4QcKkJq+yku2gnsL+ckkwS1pwwQc5U02En7fysPZPO993SPS5IUS+XSKh
 bjeA==
X-Gm-Message-State: AE9vXwPv7lndK7UWTcnlc58Rc6O/FZZxKJMWJO1d/IVW6XXGoIokvaU4ic+/Bce9/AEB1g5u
X-Received: by 10.28.59.7 with SMTP id i7mr5220392wma.127.1474493367336;
 Wed, 21 Sep 2016 14:29:27 -0700 (PDT)
Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net.
 [82.235.116.147])
 by smtp.gmail.com with ESMTPSA id w71sm34419028wmw.17.2016.09.21.14.29.26
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 21 Sep 2016 14:29:26 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org, Masoud Hasanifard <masoudhasanifard@gmail.com>
Date: Wed, 21 Sep 2016 23:29:25 +0200
Message-ID: <7057001.BY3tcUaArR@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C9F8E0E@IRSMSX108.ger.corp.intel.com>
References: <1474105404-27654-1-git-send-email-masoudhasanifard@gmail.com>
 <E115CCD9D858EF4F90C690B0DCB4D8973C9F8E0E@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] hash: Correctly set the compare function.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Sep 2016 21:29:27 -0000

2016-09-19 18:36, De Lara Guarch, Pablo:
> Commit titles start with lowercase ("correctly") and without a dot at the end.
[...]
> I think this is a fix, so probably it should contain the following "Fixes" line in the commit message:
> Fixes: 95da2f8e9c61 ("hash: customize compare function")
[...]
> Good catch! Two comments inline.
> Could you send a v2 with those two things added?

I can do these trivial changes when applying.
Pablo, do you ack?