Re: [dpdk-dev] [PATCH v5 05/11] lib/librte_vhost: merge Oliver's mbuf change

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2014-09-30 02:41, Xie, Huawei:
> I would rework the patch according to your comment.
> I don't get clear about this comment. Do you mean that recreate the patch set
> based on the example that already has this mbuf change?

Yes

> Some of the background you might not know:
> I fully understand your concern here to make it a better patch and I fully agree
> with you total comments. 
> This is really a special case. You know it is transform of thousand lines of code with modifications.
> Sometimes a simple change could take me more than one day to rework the patch, lines of lines manual check. 
> I have already spent more than one week of time merely  on the patch format itself. :(.

I know. I think you are learning (the hard way) how to use git.
As Ouyang said in this thread, you should use "git rebase" 
and especially the --interactive mode to update your changes.
And you should make small commits at first. It's easier to squash
commits than splitting them.

> Could we possibly treat it specially when we have comment whether the patch can be split/merged better? 

I thought it many times because I see it causes you many troubles.
But I still think that vhost is an important feature and we probably
want to be able to understand what are the reasons behond the changes
by looking at the git history. That's why I'd like you to make smaller
refactoring commits with explanations in commit logs.

That's said, we should continue working together on it.
Send me your drafts and I'll help you to split them. The part I cannot do
by myself is about the explanations in commit logs.

Thanks
-- 
Thomas