From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id CAD0E6A89 for ; Tue, 30 Sep 2014 06:39:55 +0200 (CEST) Received: by mail-wi0-f178.google.com with SMTP id ho1so3474575wib.5 for ; Mon, 29 Sep 2014 21:46:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=/BgmB0Penusqbvo3DaZ57VfSxWdFpy04GBmeys5CHD8=; b=fMWTdRhksOGWcQ0pOjkX+no9q24C7cbeVWQ53A04MsrSrFdhdVsTEavKe8EgMVfoPH lG1JJrPSyROO1rmdyvjmaksA93LPP3nSPmMpFfQsrAI4/Hqksg28LyFsxT/gtEYQCwKC DC4AsrL6o/646iOXFZ74Q/nI9A2/vvg3oxwHsF2U3k6pUYuFkyIfVqd36yiz44XXAExI O8trTwBg5vLMvWUFx8e/FXICk+FLKar78Yg5Qhr50xouP0QyEaBwUKIJPEpWw8Sq5J0+ RV05vk+Kot0nl03g5OuxFWFzpxdeeYxUhxy3aXlkZezZN/VLMMl98zIDSocj4DRVmbMo 6vLw== X-Gm-Message-State: ALoCoQlWHsmw6qj4jH0iLbA7sHIg8/bdkwauoZ5w3aKOxNP3XkKN04OvKghLORiXQreOfqrwJPXC X-Received: by 10.194.246.2 with SMTP id xs2mr48065916wjc.33.1412052394758; Mon, 29 Sep 2014 21:46:34 -0700 (PDT) Received: from xps13.localnet (14.21.90.92.rev.sfr.net. [92.90.21.14]) by mx.google.com with ESMTPSA id wk5sm8948598wjb.12.2014.09.29.21.46.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Sep 2014 21:46:34 -0700 (PDT) From: Thomas Monjalon To: "Xie, Huawei" Date: Tue, 30 Sep 2014 06:46:18 +0200 Message-ID: <70634298.6WfLhqUcss@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: References: <1411724758-27488-1-git-send-email-huawei.xie@intel.com> <9382804.Ypo5if4EZ6@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 05/11] lib/librte_vhost: merge Oliver's mbuf change X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Sep 2014 04:39:56 -0000 2014-09-30 02:41, Xie, Huawei: > I would rework the patch according to your comment. > I don't get clear about this comment. Do you mean that recreate the patch set > based on the example that already has this mbuf change? Yes > Some of the background you might not know: > I fully understand your concern here to make it a better patch and I fully agree > with you total comments. > This is really a special case. You know it is transform of thousand lines of code with modifications. > Sometimes a simple change could take me more than one day to rework the patch, lines of lines manual check. > I have already spent more than one week of time merely on the patch format itself. :(. I know. I think you are learning (the hard way) how to use git. As Ouyang said in this thread, you should use "git rebase" and especially the --interactive mode to update your changes. And you should make small commits at first. It's easier to squash commits than splitting them. > Could we possibly treat it specially when we have comment whether the patch can be split/merged better? I thought it many times because I see it causes you many troubles. But I still think that vhost is an important feature and we probably want to be able to understand what are the reasons behond the changes by looking at the git history. That's why I'd like you to make smaller refactoring commits with explanations in commit logs. That's said, we should continue working together on it. Send me your drafts and I'll help you to split them. The part I cannot do by myself is about the explanations in commit logs. Thanks -- Thomas