From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 72230593E for ; Thu, 16 Oct 2014 17:03:31 +0200 (CEST) Received: by mail-wg0-f51.google.com with SMTP id b13so3982543wgh.22 for ; Thu, 16 Oct 2014 08:11:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=A5yp3sPA7w0qCz1g8Fxq2GuLikfCourOwViK7BMZn2A=; b=jvsCd22PgNhxrBn9m1V7RfbN1ROSJjKw31i2RpqBD1LdEgvvTuJqdfHuqoxFqKBWCI hcouhMQj3WqCdkFU0ijMcx2etV1Mtoj1QESMAhIMwv9LgCltYY8+7R02jNLd9nJ/Lzv3 vDKWUVuDHmMZbsY496zAypOwaEEABVeAJxh0OIFY2LXgU54gxNGE/8ELeOIre44bTNl0 dk8D68mTczV9+nTDvIA12cR312c3LJ1d3bzPRVFzBoBmrdG26TYgKYpLHBN6TeuL0rF+ iT4eOUSnX3k0T1tTihytZhc46pVFUKkEQNASajSABfSUR57UQrSrGtfx6XDgz8IEZUEy 7LiA== X-Gm-Message-State: ALoCoQnZ7FSPzof8fP9vY61DQgTZ/tP2Q/1I6T3MvpSfCJpFysKLsUeI9XtLWoAqgbE8ZpxrEeoP X-Received: by 10.180.207.8 with SMTP id ls8mr6709925wic.83.1413472285021; Thu, 16 Oct 2014 08:11:25 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id k10sm27762759wjb.28.2014.10.16.08.11.23 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Oct 2014 08:11:24 -0700 (PDT) From: Thomas Monjalon To: "Wu, Jingjing" Date: Thu, 16 Oct 2014 17:11:03 +0200 Message-ID: <706738222.dRzKs86Sa3@xps13> Organization: 6WIND User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; ) In-Reply-To: References: <1411628369-29532-1-git-send-email-jingjing.wu@intel.com> <9BB6961774997848B5B42BEC655768F8B06167@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/4] lib/librte_ether: new filter APIs definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Oct 2014 15:03:31 -0000 2014-10-10 07:28, De Lara Guarch, Pablo: > > > > > Define new APIs to support configure multi-kind filters using same > > > > > APIs > > > > > - rte_eth_dev_filter_supported > > > > > - rte_eth_dev_filter_ctrl > > > > > > > > > > As to the implemetation discussion, please refer to > > > > > http://dpdk.org/ml/archives/dev/2014-September/005179.html, and > > > > > control packet filter implementation is based on it. > > > > > > > > This patch is also present on the patchset Support flow director > > > > programming on Fortville. > > > > Should this patchset be rejected then or just this patch? In second > > > > case, could you send a v2 without this patch? > > > > > > I think this patch does not only present on the flow director patchset, but > > > also on mac vlan support patchset, vxlan patchset, and so on. All of them > > are > > > using the same new filter APIs. If any patchset is applied, others may > > require > > > some modification (just as you said to remove this pacth). > > > > > Additional, without the patch, this patchset cannot work separately. More > > than one features depend on the new filter APIs, but none patchset contains > > the new filter APIs is applied currently. That's why each patchset has such > > patch. > > I see, then probably the best idea would have been send this patch separately, > and just say that these patchsets depend on this patch, basically because > if you try to apply all these patches, you are going to get failures. Yes, sending a separated patch and explicitly base your patch on this one would be really easier to understand. And more generally, it's easier when things are explained. You won't have to pay for the extra words you put in your cover letter ;) There is another problem with this patch: there are many versions around with different logs and even different authors! -- Thomas