From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24272A0C47; Tue, 6 Jul 2021 11:04:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E06B40688; Tue, 6 Jul 2021 11:04:38 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id B77594067E for ; Tue, 6 Jul 2021 11:04:37 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id B14695C00DE; Tue, 6 Jul 2021 05:04:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 06 Jul 2021 05:04:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= emfZ4CBnc0mbRBMRLQeXVDD7a5C/r6n/qV8puSEG5zA=; b=KV+gpX7tsotxtI1F 2pJOksLl01xoKOGdpUtzCawr29R6mt7tEamMskEoqoHEz7LBY/fO6zcp22TnQOf5 H1jYGtHdfGKSDy/moQRvWd5QYDsTDf/IWBiiP4larvYQi95g1XgYcdMJW3Jn3rfQ 3znN7C4NjxMyThGeVx5hx0gsW1LntBtedI/TguZqA6+LfkKzh6U0idLz6REKxbbY xVaB0vfj8xcOIGab0ZtAA9a0FdLmHVClbTjCoQVOW0L/GmnWvSHt69WKIxjrWgJg OQjG/looOctdzvmZWDyZVC9NFa2vcPoehhVKQWC0nMA7rZdG3EcjrZdq5k9T/jlP m7r3GA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=emfZ4CBnc0mbRBMRLQeXVDD7a5C/r6n/qV8puSEG5 zA=; b=madgJGHMIfJfaYAydnb613F6XBf0Oe0FwJxaPrgYmpvG+T31rIWO+y2Ns OvzVKoCTxvrQm/a86/lYskPC16ILUqDP7CyrE5RgAdAJwI40aphhM6lYzkYtLviA q+CLsiqWOk4D2xDfD3v384+pdCO8ZlvvjB8skLKTFQFRxQ7z1C95A5+ExNg2VB26 Z3eukiMpXe25Rb5lAV63kOf3a1wKnQ6jOzpoIa0yByq2rUxlNqlBJ/t5PX84Bv5l Mmix3AFPj6AHi0g9knisSVWkJxvFBd5t4PGGGYIel3OU7PeSyt4EOo7piCfIRB3l qbQLsdPgHk9cVhiKfqPTkTKjcgVPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeejiedgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 6 Jul 2021 05:04:33 -0400 (EDT) From: Thomas Monjalon To: Shiri Kuzin , Akhil Goyal Cc: "dev@dpdk.org" , "matan@nvidia.com" , "suanmingm@nvidia.com" Date: Tue, 06 Jul 2021 11:04:31 +0200 Message-ID: <7069657.2s6s7tpXrN@thomas> In-Reply-To: References: <20210509160507.224644-1-matan@nvidia.com> <20210701132609.53727-15-shirik@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] [PATCH v5 14/15] test/crypto: add mlx5 crypto driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/07/2021 10:47, Akhil Goyal: > > +static int > > +mlx5_testsuite_setup(void) > > Please see how other drivers are enabled in this test app. > We no longer allow PMD specific testsuite. > Please see the cn9k/cn10k PMD which recently got merged. > static int > test_cryptodev_cn9k(void) > { > return run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_CN9K_PMD)); > } > > The cases which are not supported by mlx5 crypto PMD will get automatically skipped > If all capabilities and feature flags are set properly. > > The cases should be generic enough to be used by other PMDs as well. > @Thomas Monjalon: This patchset is adding PMD specific test cases again > which we removed in past 3-4 releases. Good catch Akhil. Indeed tests should be generic.