From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23785A034F; Wed, 24 Feb 2021 12:02:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6F921607AC; Wed, 24 Feb 2021 12:02:02 +0100 (CET) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mails.dpdk.org (Postfix) with ESMTP id 962624069B for ; Wed, 24 Feb 2021 12:02:01 +0100 (CET) Received: by mail-wm1-f52.google.com with SMTP id x16so1405598wmk.3 for ; Wed, 24 Feb 2021 03:02:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AI+/oLu5DCau5uHMNXQOD6YZOoi94TN1FRgfUFpuq2g=; b=gtMX5v/PJXRijYvkLSmZuRgau9uiv1Dy0FLrmoB5fpT3diOMLweDc9ozISph15Q9Wi 6cnzHzik+U37nrNoT1DbDBDGwEw+nImP3SwSetS6+BShEFZg+XMfo6h1ZgOLgapeF07m yy4JgstJJoTd89EwdKWkYtL+6WpAH4qZNfTMA/epTY0vlvtaqGREK2Kl+/Wx6iBDf6Dp O/dAO650J3I39FBvsdzuEGHSajMk4nLGELharo7jRX/cAywV+3Z8qNbbEzcrLcUsOM7T eoU5HRMVrI75h/mSmkCPCdUpD8r+CzPCX+PiWagEmb/JipBkFouPGlJp1EBkxy+qUQSM RAoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AI+/oLu5DCau5uHMNXQOD6YZOoi94TN1FRgfUFpuq2g=; b=qNx72gyphzr0e2JeP1T5axfOlfhO3CwbTPjdBy/y3PoCwR6gfGA9+g4FOM29SJioQW v4iEPWP6Ly8N9I+QIIIycmasWUYdYteQ9dGK4ek9t8dFZ4ohy1rWIA7qHpKE/5xaUTym yC2TddlL3mr65qroHxl96rq5PphQNnHXzCOhNGFBMidducrVt+Iav/SOvHb9D1+pepgA Vj7RNGUqedB9wosZBOWtjQ7s7vpXMIpOxnDVlcLA9CGXsIgjZMK9uQ9VuGWHoNGTO3AR +euoZKsSNAfxHmxfPH2ccndHQK3bog0ZJxAeiqamIdSB78G7+kp0M6vie6IDTPEgx98e Iv2Q== X-Gm-Message-State: AOAM531kxEBKUaY7tCKI0tshnSoC1oKm4zb4mJiyMA1s2QRfmxM5Uzop ybx+YVDjCHAs9fKMl9R0O16j X-Google-Smtp-Source: ABdhPJyOGNGlaK6AlY/kFlXyoD2EShtzjFW9Kt7XhzcvmMlByItSqQdcSC6A77mIEoSMlbXD1nko5Q== X-Received: by 2002:a7b:c412:: with SMTP id k18mr3170789wmi.37.1614164521409; Wed, 24 Feb 2021 03:02:01 -0800 (PST) Received: from [10.16.0.39] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id w11sm2712291wru.3.2021.02.24.03.02.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Feb 2021 03:02:01 -0800 (PST) To: dev@dpdk.org, oulijun , Thomas Monjalon References: Cc: =?UTF-8?Q?Juraj_Linke=c5=a1?= , Bruce Richardson , linuxarm@openeuler.org, ferruh.yigit@intel.com From: Thierry Herbelot Message-ID: <70792902-0237-0a45-9479-5e97bf3d02c7@6wind.com> Date: Wed, 24 Feb 2021 12:02:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Message: 4 > Date: Wed, 24 Feb 2021 11:24:27 +0100 > From: Thomas Monjalon > To: oulijun > Cc: ferruh.yigit@intel.com, dev@dpdk.org, linuxarm@openeuler.org, > juraj.linkes@pantheon.tech, bruce.richardson@intel.com > Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon > kunpeng920 SoC build > Message-ID: <5309744.5Ik2CEZAj8@thomas> > Content-Type: text/plain; charset="UTF-8" > > 24/02/2021 10:17, oulijun: >> >> ? 2021/2/24 15:41, Thomas Monjalon ??: >>> 24/02/2021 02:34, oulijun: >>>> >>>> ? 2021/2/10 17:41, Thomas Monjalon ??: >>>>> 03/02/2021 13:46, Lijun Ou: >>>>>> From: Chengchang Tang >>>>>> >>>>>> Because of the '9ca2f16' have merged, the current hns3 >>>>>> pmd driver can not be directly complied on the kunpeng920 >>>>>> server board. Therefore, we need to fix the meson build. >>>>>> Besides, add kunpeng 920 SoC meson cross compile target. >>>>>> >>>>>> Fixes: 9ca2f16faa7f ("config/arm: isolate generic build") >>>>> >>>>> Why do you think this patch is fixing the one above? >>>>> It looks just a new config, not a fix. Am I missing something? >>>>> >>>> I'm sorry to see you so late. In the meantime, we are celebrating the >>>> Spring Festival. This patch fixes the problem. If the patch is not >>>> added, the latest version cannot be directly compiled on the Kunpeng 930 >>>> server board.In addition, the cross compilation configuration file is added. >>> >>> Please can you explain what was removed which breaks your compilation? >>> >> I understand that implementation_id is identified in 9ca2f16. If the >> configuration file does not contain implementation_id, it will be >> displayed as unsupported. >> >> The error as follows: >> config/arm/meson.build:227:2: ERROR: Problem encountered: Unsupported >> Arm implementer: 0x48. Please add support for it or use the generic >> (-Dmachine=generic) build. >> >> Besides, we use the -Dmachine=generic, the bug is not resolved. >> the cmd as: >> meson build or meson -Dmachine=generic build > > What is the result of a generic build? Hello, Following dpdk commit 91c730fd4e093cd, the generic compilation for Arm is selected with '-Dmachine=default' The comments in config/arm/meson.build should be updated to follow the change in default machine name: https://git.dpdk.org/dpdk/tree/config/arm/meson.build#n241 https://git.dpdk.org/dpdk/tree/config/arm/meson.build#n256 Regards Thierry > >