From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
 [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id E38767F70
 for <dev@dpdk.org>; Thu, 18 Dec 2014 17:40:34 +0100 (CET)
Received: by mail-wi0-f173.google.com with SMTP id r20so2389001wiv.12
 for <dev@dpdk.org>; Thu, 18 Dec 2014 08:40:34 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=1+y9QullhNB6fZDgNxFfYFRRz+7m3JtJthkjntubTlE=;
 b=LGJtB0RnceULDVSl9hlH3bBAtG9XRcuAnI2RCI+xn9+mGIOJqBy3v52zCdeEwK86dw
 tkVi0Gd8eNMMUqEZYnxEKfp6B72t4BTJR81lIKJG9YvH92pXZ93w4AulQcMJl1mMeTrO
 gKiF1PKHWnwu1WzON1ab4AmCr1w6vtOpj5KuHhsDLihDrv0fgog4V76AOMy0fmzBkTX6
 GonyauNiT/4aNn0dIhZ+LCVrJILDiZuvR28mV0RY88bWw3JaPisECkouBjybZ9gv5D0D
 srP/c6Og0HinqaipFSESKCLapWa76GGByJTWV1DhFOWwPspg76Za9YMwN7jPQkvw3lyl
 nvSg==
X-Gm-Message-State: ALoCoQl6J3oM1gLl41KmfZigkx1ECzsUPDZ+xf2zPH/QUW3kARQ1rBlkntueVe1Txb5K/2mJOl4i
X-Received: by 10.180.83.129 with SMTP id q1mr6839760wiy.8.1418920832159;
 Thu, 18 Dec 2014 08:40:32 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id f7sm10566933wiz.13.2014.12.18.08.40.30
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 18 Dec 2014 08:40:31 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu, 18 Dec 2014 17:40:05 +0100
Message-ID: <709461311.gdq8zXb54j@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <20141218081712.62ebca0c@urahara>
References: <1418835808-18803-1-git-send-email-nhorman@tuxdriver.com>
 <20141218081712.62ebca0c@urahara>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] xenvirt: Fix build break on
	cmdline_parse_etheraddr call
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Dec 2014 16:40:35 -0000

2014-12-18 08:17, Stephen Hemminger:
> On Wed, 17 Dec 2014 12:03:28 -0500
> Neil Horman <nhorman@tuxdriver.com> wrote:
[...]
> > The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt.  This
> > patch makes the needed correction to avoid a build break
[...]
> 
> If we could fix the header incompatiablities then the driver could use
> a standard library like ether_aton() instead of dragging in the unnecessary
> cmdline library.

Right.
A first fix was done to remove conflict with netinet/in.h:
	http://dpdk.org/browse/dpdk/commit/?id=d07180f211
But there still are conflicts with netinet/ether.h and maybe more.
I suggest to fix it in the release 2.0.

-- 
Thomas