From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail5.wrs.com (mail5.windriver.com [192.103.53.11]) by dpdk.org (Postfix) with ESMTP id CE9465911 for ; Tue, 28 Mar 2017 13:39:42 +0200 (CEST) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id v2SBddJk010655 (version=TLSv1 cipher=AES128-SHA bits=128 verify=OK); Tue, 28 Mar 2017 04:39:39 -0700 Received: from ALA-MBC.corp.ad.wrs.com ([fe80::fcbe:9b7:1141:89a1]) by ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) with mapi id 14.03.0294.000; Tue, 28 Mar 2017 04:39:38 -0700 From: "Legacy, Allain" To: Yuanhan Liu CC: "mtetsuyah@gmail.com" , "maxime.coquelin@redhat.com" , "dev@dpdk.org" , "Peters, Matt" , Thomas Monjalon Thread-Topic: [PATCH] vhost: change mbuf allocation logs to debug Thread-Index: AQHSp4+zZeFE6H7K2EablnK89acMGaGqH/+g Date: Tue, 28 Mar 2017 11:39:37 +0000 Message-ID: <70A7408C6E1BFB41B192A929744D8523968F8CC8@ALA-MBC.corp.ad.wrs.com> References: <20170327162930.54281-1-allain.legacy@windriver.com> <20170328064841.GZ18844@yliu-dev.sh.intel.com> In-Reply-To: <20170328064841.GZ18844@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [128.224.140.166] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] vhost: change mbuf allocation logs to debug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 11:39:43 -0000 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Tuesday, March 28, 2017 2:49 AM <...> > > In order to prevent this condition, but > > still enable debugging, the logs are being changed to debug logs to ens= ure > > they are not emitted unless the CONFIG_RTE_LIBRTE_VHOST_DEBUG > option is > > enabled. >=20 > That basically means you will never see them in real life. I'm suggesting > to add a new log API, RTE_LOG_ONCE. Sounds good? Rather than a log what is really needed here is a stat/counter, but this li= brary does not have the infrastructure in place to support reporting datapa= th errors via stats back to the application. Are there any plans to add a = stats infrastructure or a desired design for what that would look like?