From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by dpdk.org (Postfix) with ESMTP id 97C762C18 for ; Wed, 28 Mar 2018 15:12:33 +0200 (CEST) Received: from ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id w2SDC5Bl020521 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 28 Mar 2018 06:12:05 -0700 (PDT) Received: from ALA-MBD.corp.ad.wrs.com ([169.254.3.201]) by ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) with mapi id 14.03.0361.001; Wed, 28 Mar 2018 06:12:00 -0700 From: "Legacy, Allain" To: "YIGIT, FERRUH" , "LU, WENZHUO" , "WU, JINGJING" , "John W. Linville" , Shepard Siegel , Ed Czeck , "John Miller" , "Peters, Matt" , Harish Patil , "Rasesh Mody" , Ajit Khaparde , Somnath Kotur , Rahul Lakkireddy , Hemant Agrawal , Shreyansh Jain , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , "Evgeny Schemeilin" , John Daley , "Hyong Youb Kim" , "ZHANG, QI" , "WANG, XIAO" , "XING, BEILEI" , "ANANYEV, KONSTANTIN" , Shijith Thotton , Srisivasubramanian Srinivasan , Adrien Mazarguil , Nelio Laranjeiro , Yongseok Koh , Jacek Siuda , Tomasz Duszynski , Dmitri Epshtein , Natalie Samsonov , Jianbo Liu , Alejandro Lucero , Tetsuya Mukawa , Santosh Shukla , Jerin Jacob , Shahed Shaikh , "RICHARDSON, BRUCE" , Andrew Rybchenko , Matej Vido , Pascal Mazon , Maciej Czekaj , Maxime Coquelin , "BIE, TIWEI" , Shrikrishna Khare , "HORTON, REMY" , Ori Kam , "DE LARA GUARCH, PABLO" , "NICOLAU, RADU" , Akhil Goyal , "KANTECKI, TOMASZ" , "DUMITRESCU, CRISTIAN FLORIN" , Thomas Monjalon CC: "dev@dpdk.org" , "YIGIT, FERRUH" Thread-Topic: [PATCH] ethdev: replace bus specific struct with generic dev Thread-Index: AQHTxfLbfKisC7iHgkywMgA2eUDjUqPloH4w Date: Wed, 28 Mar 2018 13:11:55 +0000 Message-ID: <70A7408C6E1BFB41B192A929744D8523BA9D1C03@ALA-MBD.corp.ad.wrs.com> References: <20180327174052.266285-1-ferruh.yigit@intel.com> In-Reply-To: <20180327174052.266285-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [128.224.140.231] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 29 Mar 2018 09:59:04 +0200 Subject: Re: [dpdk-dev] [PATCH] ethdev: replace bus specific struct with generic dev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 13:12:34 -0000 > -----Original Message----- > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Tuesday, March 27, 2018 1:41 PM <...> > Subject: [PATCH] ethdev: replace bus specific struct with generic dev >=20 > Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it > although it is common for all ethdev in all buses. >=20 > Replacing pci specific struct with generic device struct and updating pla= ces > that are using pci device in a way to get this information from generic d= evice. >=20 > Signed-off-by: Ferruh Yigit > --- > Cc: Pablo de Lara >=20 > There is no deprecation notice sent for this update but in this release e= thdev > info already updated and ABI already broken, it can be good opportunity f= or > this update. > --- > app/test-pmd/config.c | 11 ++++++++++- > app/test-pmd/testpmd.h | 24 ++++++++++++++++++------ > drivers/net/af_packet/rte_eth_af_packet.c | 1 + > drivers/net/ark/ark_ethdev.c | 4 +++- > drivers/net/avf/avf_ethdev.c | 2 +- > drivers/net/avp/avp_ethdev.c | 2 +- Acked-by: Allain Legacy