From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail5.wrs.com (mail5.windriver.com [192.103.53.11]) by dpdk.org (Postfix) with ESMTP id 606271B4FF for ; Wed, 20 Jun 2018 12:58:36 +0200 (CEST) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id w5KAsKQw014931 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 20 Jun 2018 03:54:42 -0700 Received: from ALA-MBD.corp.ad.wrs.com ([169.254.3.237]) by ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) with mapi id 14.03.0399.000; Wed, 20 Jun 2018 03:54:10 -0700 From: "Legacy, Allain" To: "YIGIT, FERRUH" , Neil Horman , "MCNAMARA, JOHN" , "Marko Kovacevic" , "John W. Linville" , "Peters, Matt" , "Ravi Kumar" , Ajit Khaparde , Somnath Kotur , Rahul Lakkireddy , "LU, WENZHUO" , "ZHANG, QI" , "WANG, XIAO" , "XING, BEILEI" , "ANANYEV, KONSTANTIN" , Adrien Mazarguil , Nelio Laranjeiro , Yongseok Koh , Tomasz Duszynski , Dmitri Epshtein , Natalie Samsonov , Jianbo Liu , Alejandro Lucero , Tetsuya Mukawa , Santosh Shukla , Jerin Jacob , Rasesh Mody , Harish Patil , Shahed Shaikh , "RICHARDSON, BRUCE" , Andrew Rybchenko , "SINGH, JASVINDER" , "DUMITRESCU, CRISTIAN FLORIN" , Matej Vido , Maciej Czekaj , Maxime Coquelin , "BIE, TIWEI" , "WANG, ZHIHONG" , Yong Wang , "Thomas Monjalon" CC: "dev@dpdk.org" , "YIGIT, FERRUH" Thread-Topic: [PATCH] ethdev: add new offload flag to keep CRC Thread-Index: AQHUB+9oT2QIhenQLEq+SP4UWf2LWKRo+dBA Date: Wed, 20 Jun 2018 10:54:09 +0000 Message-ID: <70A7408C6E1BFB41B192A929744D8523BAA7A6F6@ALA-MBD.corp.ad.wrs.com> References: <20180608225709.19473-1-ferruh.yigit@intel.com> <20180619180230.72585-1-ferruh.yigit@intel.com> In-Reply-To: <20180619180230.72585-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [128.224.140.228] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ethdev: add new offload flag to keep CRC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2018 10:58:36 -0000 > -----Original Message----- > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Tuesday, June 19, 2018 2:03 PM <...> > Subject: [PATCH] ethdev: add new offload flag to keep CRC >=20 > DEV_RX_OFFLOAD_KEEP_CRC offload flag added. PMDs that supports > keeping CRC should advertise this offload capability. >=20 > DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release default > behavior in PMDs are to keep the CRC until this flag removed >=20 > Until DEV_RX_OFFLOAD_CRC_STRIP flag is removed: > - Setting both KEEP_CRC & CRC_STRIP is INVALID > - Setting only CRC_STRIP PMD should strip the CRC > - Setting only KEEP_CRC PMD should keep the CRC > - Not setting both PMD should keep the CRC >=20 > A helper function rte_eth_dev_is_keep_crc() has been added to be able to > change the no flag behavior with minimal changes in PMDs. >=20 > The PMDs that doesn't report the DEV_RX_OFFLOAD_KEEP_CRC offload can > remove rte_eth_dev_is_keep_crc() checks next release, related code > commented to help the maintenance task. >=20 > And DEV_RX_OFFLOAD_CRC_STRIP has been added to virtual drivers since > they don't use CRC at all, when an application requires this offload virt= ual > PMDs should not return error. >=20 > Signed-off-by: Ferruh Yigit > --- For net/avp: Acked-by: Allain Legacy