From: "Legacy, Allain" <Allain.Legacy@windriver.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
"Qi Zhang" <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Neil Horman <nhorman@tuxdriver.com>,
Remy Horton <remy.horton@intel.com>, Ori Kam <orika@mellanox.com>,
Bruce Richardson <bruce.richardson@intel.com>,
"Pablo de Lara" <pablo.de.lara.guarch@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Tomasz Kantecki <tomasz.kantecki@intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
"Peters, Matt" <Matt.Peters@windriver.com>,
Ravi Kumar <ravi1.kumar@amd.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>,
John Daley <johndale@cisco.com>,
Hyong Youb Kim <hyonkim@cisco.com>,
Gaetan Rivet <gaetan.rivet@6wind.com>,
Beilei Xing <beilei.xing@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Matan Azrad <matan@mellanox.com>,
"Shahaf Shuler" <shahafs@mellanox.com>,
Yongseok Koh <yskoh@mellanox.com>,
"Tomasz Duszynski" <tdu@semihalf.com>,
Dmitri Epshtein <dima@marvell.com>,
"Natalie Samsonov" <nsamsono@marvell.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Alejandro Lucero <alejandro.lucero@netronome.com>,
Tetsuya Mukawa <mtetsuyah@gmail.com>,
Santosh Shukla <santosh.shukla@caviumnetworks.com>,
Rasesh Mody <rasesh.mody@cavium.com>,
Harish Patil <harish.patil@cavium.com>,
Shahed Shaikh <shahed.shaikh@cavium.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Jasvinder Singh <jasvinder.singh@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Jan Remes <remes@netcope.com>,
Keith Wiles <keith.wiles@intel.com>,
Maciej Czekaj <maciej.czekaj@caviumnetworks.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>,
Yong Wang <yongwang@vmware.com>,
Amr Mokhtar <amr.mokhtar@intel.com>,
Declan Doherty <declan.doherty@intel.com>,
Chas Williams <chas3@att.com>, David Hunt <david.hunt@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
"Harry van Haaren" <harry.van.haaren@intel.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx
Date: Tue, 18 Sep 2018 13:05:51 +0000 [thread overview]
Message-ID: <70A7408C6E1BFB41B192A929744D8523BABE9DB7@ALA-MBD.corp.ad.wrs.com> (raw)
In-Reply-To: <20180910113445.GA6418@jerin>
> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Monday, September 10, 2018 7:35 AM
> To: Ferruh Yigit
> Cc: Wenzhuo Lu; Jingjing Wu; Bernard Iremonger; John McNamara; Marko
> Kovacevic; Qi Zhang; Xiao Wang; Neil Horman; Remy Horton; Ori Kam; Bruce
> Richardson; Pablo de Lara; Radu Nicolau; Akhil Goyal; Tomasz Kantecki; John
> W. Linville; Legacy, Allain; Peters, Matt; Ravi Kumar; Ajit Khaparde; Somnath
> Kotur; Rahul Lakkireddy; Hemant Agrawal; Shreyansh Jain; John Daley; Hyong
> Youb Kim; Gaetan Rivet; Beilei Xing; Konstantin Ananyev; Matan Azrad;
> Shahaf Shuler; Yongseok Koh; Tomasz Duszynski; Dmitri Epshtein; Natalie
> Samsonov; Stephen Hemminger; K. Y. Srinivasan; Haiyang Zhang; Alejandro
> Lucero; Tetsuya Mukawa; Santosh Shukla; Rasesh Mody; Harish Patil; Shahed
> Shaikh; Andrew Rybchenko; Jasvinder Singh; Cristian Dumitrescu; Jan Remes;
> Keith Wiles; Maciej Czekaj; Maxime Coquelin; Tiwei Bie; Zhihong Wang; Yong
> Wang; Amr Mokhtar; Declan Doherty; Chas Williams; David Hunt; Anatoly
> Burakov; Harry van Haaren; Xiaoyun Li; Thomas Monjalon; dev@dpdk.org
> Subject: Re: [PATCH v2] ethdev: make default behavior CRC strip on Rx
>
> -----Original Message-----
> >
> > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag.
> > Without any specific Rx offload flag, default behavior by PMDs is to
> > strip CRC.
> >
> > PMDs that support keeping CRC should advertise
> DEV_RX_OFFLOAD_KEEP_CRC
> > Rx offload capability.
> >
> > Applications that require keeping CRC should check PMD capability
> > first and if it is supported can enable this feature by setting
> > DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in
> rte_eth_dev_configure()
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Acked-by: Tomasz Duszynski <tdu@semihalf.com>
> > ---
> > v2:
> > * fix flag check
> > * add KEEP_CRC flag into "show port cap #"
> >
> > Note "show port cap #" and
> > "show port # [r/t]x_offload capabilities/configuration"
> > does same thing, in long term I suggest removing "show port cap" one
>
For AVP devices
Acked-by: Allain Legacy <allain.legacy@windriver.com>
next prev parent reply other threads:[~2018-09-18 13:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 14:45 [dpdk-dev] [PATCH] " Ferruh Yigit
2018-09-03 13:59 ` Andrew Rybchenko
2018-09-04 5:13 ` Shahaf Shuler
2018-09-04 5:17 ` Shahaf Shuler
2018-09-04 5:54 ` Andrew Rybchenko
2018-09-04 8:06 ` Ferruh Yigit
2018-09-04 6:29 ` Tomasz Duszynski
2018-09-04 10:12 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-09-04 10:02 ` Shahaf Shuler
2018-09-14 11:37 ` Ferruh Yigit
2018-09-19 7:34 ` David Marchand
2018-09-19 18:04 ` Ferruh Yigit
2018-09-10 7:13 ` Maxime Coquelin
2018-09-10 10:40 ` Jan Remeš
2018-09-10 11:34 ` Jerin Jacob
2018-09-18 13:05 ` Legacy, Allain [this message]
2018-09-11 8:05 ` Hyong Youb Kim
2018-09-24 17:31 ` [dpdk-dev] [PATCH] doc: announce CRC strip changes in release notes Ferruh Yigit
2018-09-24 17:01 ` Thomas Monjalon
2018-09-24 17:12 ` David Marchand
2018-09-25 15:03 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70A7408C6E1BFB41B192A929744D8523BABE9DB7@ALA-MBD.corp.ad.wrs.com \
--to=allain.legacy@windriver.com \
--cc=Matt.Peters@windriver.com \
--cc=ajit.khaparde@broadcom.com \
--cc=akhil.goyal@nxp.com \
--cc=alejandro.lucero@netronome.com \
--cc=amr.mokhtar@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=chas3@att.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.hunt@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=dima@marvell.com \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=haiyangz@microsoft.com \
--cc=harish.patil@cavium.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=hyonkim@cisco.com \
--cc=jasvinder.singh@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=johndale@cisco.com \
--cc=keith.wiles@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=kys@microsoft.com \
--cc=linville@tuxdriver.com \
--cc=maciej.czekaj@caviumnetworks.com \
--cc=marko.kovacevic@intel.com \
--cc=matan@mellanox.com \
--cc=maxime.coquelin@redhat.com \
--cc=mtetsuyah@gmail.com \
--cc=nhorman@tuxdriver.com \
--cc=nsamsono@marvell.com \
--cc=orika@mellanox.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=radu.nicolau@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rasesh.mody@cavium.com \
--cc=ravi1.kumar@amd.com \
--cc=remes@netcope.com \
--cc=remy.horton@intel.com \
--cc=santosh.shukla@caviumnetworks.com \
--cc=shahafs@mellanox.com \
--cc=shahed.shaikh@cavium.com \
--cc=shreyansh.jain@nxp.com \
--cc=somnath.kotur@broadcom.com \
--cc=sthemmin@microsoft.com \
--cc=tdu@semihalf.com \
--cc=thomas@monjalon.net \
--cc=tiwei.bie@intel.com \
--cc=tomasz.kantecki@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=xiaoyun.li@intel.com \
--cc=yongwang@vmware.com \
--cc=yskoh@mellanox.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).