From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0011743C9E; Wed, 13 Mar 2024 11:37:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD3F440633; Wed, 13 Mar 2024 11:37:11 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2052.outbound.protection.outlook.com [40.107.243.52]) by mails.dpdk.org (Postfix) with ESMTP id AD2CA402B8; Wed, 13 Mar 2024 11:37:10 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UVN74zlesaeUsuQWWf0qJNyZOCYeJhIwArtBcQvs4fov+mNX0ArRN7pOdrKvYB9KbPXr/vT/vBDjwMI2DkQiVaMajLR/KVIhpADe/i0PLaeKR/FclwTDl7EBEgjsiB+mSVc89tR4wAnmgfKeK2cV8HCaOKeXmtbBZTOKEJHHGphUveAGp7H2732O7ijwpn7SJFAo6uDJJ39SQQLesFx7g0NAsEqukjz1lV/1nH9McN1NxaCaPVHIZXsrZYrRlb13pwIa/Or7R/00QnFYXnFCTv7xUxn3ENW9KpHMpsHgxdV+BR8jbjIy8+AD/yFoPRimCuTs+EcbMU0ytwv1uA5V8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ftSS+bwVWRLt9w709iNtHnQZZyMaSYyqKPH+XnaEvVE=; b=gZ18Xq+8lAy8mpwSAUCWceBTeUSBR/ncZqJSVBFeb+KHHiJF7GP6GWh1zaW2tXz1nEXPj9qnR96v6zeL21Senl+PpoKDoR5ApU8Nxb7F8yautfM5CaqQh8p/naUiSIs3z1LC837QTPmWwqC1fayuqpb4+Jsua8gPT5PhuyORUA6uY2JGpYRNsJuO8ZbDi5d7FOZTrJe4su++HuPzi2qcGyMb5ygguQ5Qtxf771LDSTd75DiRfheDYvcub5ZmPO1RBPYUplfJYlanbFr/fwvm2Ky2YLBOfM5oc1HWPMAMwH6zjJdZuTro6xmNoYKIZeW/weinYVY6z+JQkbVpGJqVtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ftSS+bwVWRLt9w709iNtHnQZZyMaSYyqKPH+XnaEvVE=; b=fhrS0lv3VRpBqWy6/ZUHKpfAX1yCFqtP8I2GSWgeg/Iara++mM6xUVOoeHnvog2ob1g8ydo9ihH7F1YhvvUpw7vMnTLciQXdHVoS5Psp9Lh8pERjfsIrpiXMovDUts1YphDTN62e7xUrWVQLQWy1211BZGIoXy/zVgtiu/fR0Go= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB7520.namprd12.prod.outlook.com (2603:10b6:208:42f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36; Wed, 13 Mar 2024 10:37:08 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.035; Wed, 13 Mar 2024 10:37:08 +0000 Message-ID: <70c06f94-bba1-48f3-8c59-9e523ff0498d@amd.com> Date: Wed, 13 Mar 2024 10:37:03 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] app/testpmd: fix burst option parsing Content-Language: en-US To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, Aman Singh , Yuying Zhang , Ivan Ilchenko , Andrew Rybchenko , Bernard Iremonger References: <20240308144841.3615262-1-david.marchand@redhat.com> <20240308144841.3615262-3-david.marchand@redhat.com> <92e9792e-9054-4c8e-a409-739176707175@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DUZPR01CA0327.eurprd01.prod.exchangelabs.com (2603:10a6:10:4ba::17) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB7520:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c574b96-4a0b-465f-04aa-08dc43498860 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fiE5SnlDtqosNDPeJX687NQfO0zUDdzC5ez/k1rC8ov2+9w1naQk/WvRBMy9V6YljB671DUXP+YCx7ZtbmyoOygh2jooD+Aa+aMwecYEozHCdxtszkG980ITvO/f4xZo5PXujyUjS1PAFcSIk2FRLbiR71IH9q5LJ7xpJ8eTWfdZr8+5+rMhq+d8m5Dv1+3kZ6RC512CL8MJK7z02QBI/WeU32kXlrKS/GPchrcqFC7LRSg8XZ3ASDl11XaTlro0rjSSG/0b10sHVui/LgML8jOgank6QGxoNQxB+T7q+tpYahvYj5BvXyykTy0YMdx/bcHH+xR6iyF7orW6/XNHTvhYR9+lKUnQ9FrE0pKDYP6IIMJQt1yA1iOoCkfUIGzoLlRFp0zcq8tFcbnI6Z8v60SKsRrfQaEiSvdzzHcuO2JL8JhFQYXA9f+9fJ+MvFgkEispbtmrBy2PyfFMC15Y43McAvaBjVxwtJ5skBmZGNHCtKvH2s824YUpOEQwolmTiBGbs2k9vvIlrFOeZD8xnLkkp+fwqDsFY7p8iW8Ytu0HkukAGb4KzBDlQHJ/DZP++A7fQwba+vopFFazL1hPUdhlmkZMY+QPWP7z/lFCOj7dbPnxU6VibzWqdmlUT5s884nW6BzeBJbEvrnskjggv7bvqdoCchSiXUdVcotdDXU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UG1iZk1PSEtYVTVpUTVYSEtaby8wSGkxbTZQb3lpNFJQbHJWSjArOGx2RUs1?= =?utf-8?B?djdyVjdNYkFNRzNGMmlEamk3bWRoZ2kzR3o2R0JWSklhZXlpcHREMlFFVGE3?= =?utf-8?B?S2FYMFhiT2FJNjlhWEZWbVU4cUFISlc1a0dmVENsQS9md2s4TEpNNVFiZFFh?= =?utf-8?B?ZG5FYllKZlRNUDBFTnVrc0FLQzhCaldPSHNNZ3Fac0ZDQnUrZnFVRGhnK3d2?= =?utf-8?B?QmNFbmpPYktVRHh3Yit6d1dxczF3SWZqTlNMZnN1U1hLSW1xajVLU3hPUWxN?= =?utf-8?B?NG5JVUI2cFhlVUdaampKcnhtcFczTlN3bWFLYjhtcndtYzdtQWxMUVdqLzNN?= =?utf-8?B?ZVdOZy9uaTBkZjJldnBrZjc3RGNKVnBhYUpJSEVQRFJvUzBDTFIyc2ZuZDRD?= =?utf-8?B?eVdVMFp0Rnl0clNLUXVSUzlHVEJkNGhoUzdyUGVqampEMEpIRk9RM2VqVmxy?= =?utf-8?B?dmg3Q3VxcXM3WUpES3c2MFZNK1Z6WEIvYTR0LytseWd1UjBPQVN5U1RNM0F1?= =?utf-8?B?Qytyeksvb2hSMW93ek9nbU5QSnppYVlGR2JMOStiVzZEaWswdFFOYlVyZWlt?= =?utf-8?B?eGdmREFhVWpmRE9Uc1FCYWhCVTA4enpram0xR00veFg2T05OSGVRdnRWU3Fu?= =?utf-8?B?Z0tGTlpXT1cwTmN3OFJtQjNYa3ZiYytGOFQ1VjRiNFRmaEoyTGErenpiUG5t?= =?utf-8?B?TzR0TVlReXJ2ckFic0FyRHNxVHgxQU1sZ0M4T1VZMXIyZzFMZ3BsbExWUThh?= =?utf-8?B?dVJGY05UWGZKMHdxL040b2k0ZC81MjJwQnNqS0V5QnorWWk5Qk82MWEvTXdX?= =?utf-8?B?bE1OTmxiK0ZSc0hOSXlNMDRZSVV0T29tQ05pdXhuWVYxZlRmMFRyWFZLdjRW?= =?utf-8?B?akFES3ZvVk4ydDFhUGp4VUNUcnRmUGVLL2xYWmdmZFBuYXFudzhLZS9UMTFw?= =?utf-8?B?UExMdS80M3JhZDlIV2JkcjRXYTFqc1Axazd6Zi9oRVFzWEsyd3c4SzA5ejA1?= =?utf-8?B?aUFtSGp1bHNvNXNDSWw3SGZkaEVwSGx1UGd4Rm15bWVqOGRtRGo3dUZTLzYy?= =?utf-8?B?eWVPK2h2VXk2NVpXNE1kdzFzcmUwS2dIOFNwNmR3bkVERFdEYlNqK2xDN3Yy?= =?utf-8?B?anNaaDhuckxqMTBHWlRRR1BIK1crM01jai9JRDFsNCtVNy96cFVXY0xnNndF?= =?utf-8?B?SnRLVkp1TWs1dldXUEhmS0ZBVzNySVN1MEdJWDRNb2JZVU51Vll5UjNQT3la?= =?utf-8?B?NXZvenZ5OXd4VTJscXRDdytwWW5qZmhsVlpVcFVZandEY25DbkJCVDRNMUJM?= =?utf-8?B?OEdkRXFMb25qQVJDbVhPdnR1cndDd1E1RDJtZWoxaTB4RkdDa3dzTmlvbksr?= =?utf-8?B?YUVvRlk2MEt4TlRrUjdYVndpTjlrNHQ3ejBRZDVFank1c2pMVmJuWDRhWFc1?= =?utf-8?B?QnRzT2VSTitNeHFzaXovRFJoZmFJZU56QWREdXQxeDd6eVFZbDA0ZytUYTFW?= =?utf-8?B?MUFqdElGTnplck9CZGd0WGVyUXRvcUVORWwyRGhTakJDTTdzQVdiOU0yWVJI?= =?utf-8?B?Y0ZmQnQxZVR6SitPSmtTYlZTS1ZSNzRKd3p0Ymdsd0Y2RWZ6WVJSN2tZS1Bs?= =?utf-8?B?TDlJWWxyMGdvdnhZN2xZQmlIdEtiM0hIMVI4RXVGWkltVXg1dEV1QUorenJ3?= =?utf-8?B?TEZyTDdBMXF4T3pxSkJLU2dVY3M4bVBydlJ1VnVKaWFkUXg5MjdWNHNQQTNh?= =?utf-8?B?S2FhWmNlSlBFMnowWmtnL1VJTXB6R01yU1FmbFZ2ODhXZ0tqM1U2RGRwc1Ar?= =?utf-8?B?ZFNzc2I2cmNUS1JVSWxLRnlVdGNzaThyMlhMNjFIeVdyREhaTDdWNitoNnR6?= =?utf-8?B?Q0JmbmNpeWZXLzFvaUhScHgxaW1lT0daQnR2K3NhMHgzRzU3VkxzMVhzOFN1?= =?utf-8?B?RWNBMVhoeEVYcm5SMlROcXpXcUNDN2FhTGNMZ2htNkFacTNNelhSK0YvYm55?= =?utf-8?B?WFhwSVRZSFBDOEZ3TVJac1YxQ0IraEFMWGtNeUtaTStHVlplc2xPNys2dkYy?= =?utf-8?B?cnlFaWdha29YQlBpMEJaQTZWcGN0NFBiY2xqeDhIeFRUdElEeGRoYUdxVitT?= =?utf-8?Q?V3zmaVdee5nbMasdNttbIDLva?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c574b96-4a0b-465f-04aa-08dc43498860 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 10:37:08.1397 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6ShTZh/YOe47VwQpLe+0QKBCgj6krqA9eZLUZV/KjZIQpIwLUs855XE49rUcwMz+ X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7520 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/13/2024 7:24 AM, David Marchand wrote: > On Tue, Mar 12, 2024 at 5:47 PM Ferruh Yigit wrote: >> >> On 3/8/2024 2:48 PM, David Marchand wrote: >>> rte_eth_dev_info_get() is not supposed to fail for a valid port_id, but >>> for the theoretical case when it would fail, raise an error rather than >>> skip subsequent options. >>> >>> Fixes: 6f51deb903b2 ("app/testpmd: check status of getting ethdev info") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: David Marchand >>> --- >>> app/test-pmd/parameters.c | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c >>> index d715750bb8..8c21744009 100644 >>> --- a/app/test-pmd/parameters.c >>> +++ b/app/test-pmd/parameters.c >>> @@ -1128,9 +1128,9 @@ launch_args_parse(int argc, char** argv) >>> 0, >>> &dev_info); >>> if (ret != 0) >>> - return; >>> - >>> - rec_nb_pkts = dev_info >>> + rec_nb_pkts = 0; >>> + else >>> + rec_nb_pkts = dev_info >>> .default_rxportconf.burst_size; >>> >>> if (rec_nb_pkts == 0) >> >> 'eth_dev_info_get_print_err()' already fail, but it may not be very >> clear to the user, >> OK to print a failure log, but setting 'rec_nb_pkts = 0;' as above also >> will generate an error message that also may be confusing to the user. >> >> What about print an explicit error message for the >> 'eth_dev_info_get_print_err()' failed case? > > rte_exit(EXIT_FAILURE, "Failed to retrieve device info, this is > probably a driver bug. " > "To workaround this issue, please provide a value between 1 > and %d\n", MAX_PKT_BURST); > > Does it work for you? > > 'eth_dev_info_get_print_err()' already logs error about getting device info, but driver recommended 'burst' setting failed information is missing. What about more direct, "Failed to get driver recommended burst size, please provide a value between 1 and MAX_PKT_BURST"