From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91CBD43C0C; Thu, 7 Mar 2024 17:06:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6CA324067E; Thu, 7 Mar 2024 17:06:40 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2085.outbound.protection.outlook.com [40.107.223.85]) by mails.dpdk.org (Postfix) with ESMTP id 7647640272 for ; Thu, 7 Mar 2024 17:06:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dcikHx+edGU/CSjquaF91SWCpNAk1Lr9cyJauT0wo9d9vpa7/19EltsvnZQDTW95JtsNdaNPLe4F4clJ3uwcRZw6FXMK07hR2zUW9u7I+oZZ+t/W/ZyAM8jhAMXNHFfTJecP6f2Y/EboeKneMO9inChkr0ZSUJdaIFT2ke4Y8ITvj2YXwjs+TdALEcUIiB6r9Rl22ZI9d+wztwRlvOZrwKPguGjHwFlffnTiiQivcLN1X8SJ1P4pU9eYhnQFDCJyzK/D6icJNnXTqSrUJ3RVePWLn3QYB+YQxZ+GcFWAHIiqTOq3kuZ36JMSBX5eSSjRDEVHvh4akSKgXgNhdGZeew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LVleBAkAVK/pLdziEnvGei+1VYB4dnlk9q87zlni00s=; b=Q+ikfkqgLO5X40oa4toAbqX7MOoBpQp7L2EaQKLMGlYrNdYYRCacmercHvHV2/K63GzTH8o5kN5fHQoRDDs1yBXlDY7KXtmZBgFidAb0xovLkNfJcUOFJSslg4O7cWWC4pNCG/DArCciOO2NFc+rE5LDEgdvCaFGtuJyKIyjlQfsSeWyRiUYsvBspgQPdUWn2WMGEJyNtXOt+hemzeS5VlOMRFW94TXZbAXABD8GTtXLWOrAJ2ioU2wSfa7mrwg7O+dOxWr+/49p/qgGX+iUaCEubs3uZ/nIdBPPXF/GapOS4Uj51sdk0/TS3oPXqnTFXo13cnWDK4OslJLcV2JBRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LVleBAkAVK/pLdziEnvGei+1VYB4dnlk9q87zlni00s=; b=W2ncCGB0wmJiKt2fiu/W6+ElmGLpbhZszOV0TauigRhA+kMoJ+rFzGm2lTYurRk+7zIFAKlBHjIc3ySZ15ZWHI+Yld3azSBMhoRGJGy32GFjKkCLbCR0nWXgI8T8AThKoe3hN1gjJl7ks62eVtg6xZYzPNTGuC5chcGwmnxHzx8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from PH7PR12MB8596.namprd12.prod.outlook.com (2603:10b6:510:1b7::6) by CYXPR12MB9318.namprd12.prod.outlook.com (2603:10b6:930:de::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38; Thu, 7 Mar 2024 16:06:33 +0000 Received: from PH7PR12MB8596.namprd12.prod.outlook.com ([fe80::5f0d:af7:7f6b:9b9c]) by PH7PR12MB8596.namprd12.prod.outlook.com ([fe80::5f0d:af7:7f6b:9b9c%5]) with mapi id 15.20.7362.024; Thu, 7 Mar 2024 16:06:33 +0000 Content-Type: multipart/alternative; boundary="------------SlPWQ8udOCa0PRxiBeQh3EaD" Message-ID: <70c24acc-531b-41db-9ae2-7ec008b6a7a4@amd.com> Date: Thu, 7 Mar 2024 21:36:26 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] app/dma-perf: calrify incorrect NUMA config Content-Language: en-US To: fengchengwen , dev@dpdk.org Cc: ferruh.yigit@amd.com, neerav.parikh@amd.com References: <20240306150204.1375-1-vipin.varghese@amd.com> <29fd85f4-d8bf-cd4e-f56c-8fd835e97e0e@huawei.com> From: "Varghese, Vipin" In-Reply-To: <29fd85f4-d8bf-cd4e-f56c-8fd835e97e0e@huawei.com> X-ClientProxiedBy: PN2PR01CA0119.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:27::34) To PH7PR12MB8596.namprd12.prod.outlook.com (2603:10b6:510:1b7::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR12MB8596:EE_|CYXPR12MB9318:EE_ X-MS-Office365-Filtering-Correlation-Id: 3b01557c-ff0a-4fb0-82a1-08dc3ec08ed9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qXeZGeGrz+ezjDD7xi1BB7tgmupn6f+JBBCmSGgFDRm+gEtEJ6OD4iF0vctRgtTGH7dSSGYzW1bYScs2Q4UYUfkPpgqu74KmL/tdoUCKUF2ivDCKR2s/tXGXJtz2HpsS9DOfJsoris7Don5Dz2CYXOgEiux4jW2BPFvBBeU3mMHrhdcpEY5pBALiDciqRGRK4+xuEVYoelocPX2n9Ls7Y+x5FOntZl09Rpv8KKplphp67srCvREJfNTMRQDX+N5yez+INjK2IFmO860iPlQRNMQxzfAjI6w8Z39luqYy369QN4OQ67F0ldYViQShon/ZL8Sa2FXRU/z+Lh/nz8kaWEmownVKfs3ippkXebgNwnqh9gtdEcpAQK8r4QqiQ7BB7dN5QJK6h7rXRWh/nFeWbeCPcY1KyQOsrkA1RX/4v+dbSv+VqDw+ZPwtJhlP/lnl7ZCwxU+IvLyDhlZzacRB8rUKvmAkUbEQMSiky+cxghl0fQI0QiWv90V/pNqx8dvayjY4ZVLEAZKRJJqcqkUXAoaOe43MIiyrSjDyyATLpK+aHxzaMwoKJOMxn8EHMXqnzNLecKVN2Ht2CuTbrt+bSjrPR3HpqsuLvJaOJx9gD4J5owz4OGM1KIgEq3+FsukNK8pBQanxikC2/gl0ORCPkKuWoszoW/qEEWHvWJrK+a4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR12MB8596.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bThmcFVEOHFISURHUTVOU2h4dUhYWXZQSDdIS3ovbEM1R2RLV1hXS1Zwb1Qr?= =?utf-8?B?VE9EdEN5QThnSGZsdFo1algrbkdJWHJjWXpsUVFIL3FReFJiYmpMaGJrbkIx?= =?utf-8?B?TXpDTERoWmIrRzdwcU42TzA0YXZieFdxZ0xTQ0dFZWxrTFVZTkorbGVpVlIw?= =?utf-8?B?ZEM1WVllY0JRRHhwS1FKeDlkNXBNVVhObnJzVTRnc0lSd0NuUDh6OHpxTTlJ?= =?utf-8?B?WHBBbXNvUGJGTHJpK0N2dnIzeERjR3pIUFk0SlV4NGtFbm9SZmxnREhRUUpm?= =?utf-8?B?ZEhMcTlxUDgvMXBZcTFZUjJjN1MxZ08zMVgzb3EyQXd4L1lWSGsxcUJLaitJ?= =?utf-8?B?dzlzazVIeXNURjBQb21oNS92RmxrS1g3a29lWXlQNUxMMkxDSFQvNW5Ra04w?= =?utf-8?B?ZDBUMHpQQzJuNVBFMU1wdllwSTJIR3lhUTBaMTJXM0I1bEZUWU9FMUliTXBu?= =?utf-8?B?K1lndHhJcEdpdE54VVpybkY2SEZBMlc5T3FYSmpKbmE0U0pEVWVNanVDQXJv?= =?utf-8?B?SVpXc0JjWUl2Vlg5T1pLOGo4bWR6RTQ2NnZqYXltM29CQUlXRmw3Q3RKY2Zl?= =?utf-8?B?L0FmSHpEYkR2T3NNK1BuZ1BOTFRKMXNFbmxwcG82TGhJSG1nOVZwRjdlVmRV?= =?utf-8?B?cG43QVptRWVIb1ZmbXQ0WU44MHJHRGJWQUsxS3p5SDBBTWswSTFSYXc5eGRp?= =?utf-8?B?cFV4dmxFelA3c2FXMWhZcUs4YjRONndCc2xiVjNYVitFWTBrZDZoYTJsS0p6?= =?utf-8?B?Vkl1YWxtWDRCTEluaWZPZUFaOTl1bHNMQWpXQnNiaXNOREkvcEh6OTBQWGIx?= =?utf-8?B?RmN2MDBiNXhnb2s0cFM3alBRT082MFNBRzFlNjlpK1FnTUhiZ1pnSVpEdC9B?= =?utf-8?B?aEE5UFRhTFVrNFUzK3RTNVAxeURlcUNMRVkrNlVVbEhxdEFTNlQ0L3Brc0l1?= =?utf-8?B?S1VFbSthSkhMcXFrTkxvVFdZQmR4TzQrSVAzcGZLdW5adDBxTFNYbFJNcHpt?= =?utf-8?B?eGFTZTNJUFVudXJrQzlLR3JrV0ZNTStTUUNiMHY0RnlrYzh2WG9hS2s3cTh0?= =?utf-8?B?NFo4SDR5Z0c3ZG5yYnBjY0xpMXB4aUZqQkh1QWZQOWg3WVU0YkNCUHIzZTJ3?= =?utf-8?B?RkhlK0hwUHV4VlhEdVBIVjBIeDl1ZENyRmpLOGtKUUI3a0tuVjl3eUR3QU44?= =?utf-8?B?c3pINUR4aXZ0a3RpeVd4cmpxcXhEZXIxZWJsNk5DV3E2dXk3UFk2S1M3MjFX?= =?utf-8?B?VU94NU8wckZRTW9pdHFCWTQ0Wldkc2pZT2pyQ3lGV2J2RlRkZ1JsZExsWVVv?= =?utf-8?B?QXF0NFNyWnB3dW4zai93QTAxTkFjSEZIdHBvVkpsU1Q2SmtZZEx0VzBmak1X?= =?utf-8?B?V3dHLyttS2hvUkVnRlhGQXEwQS80M0hENGZBZFpnYlZzRGJQNkdZeTVidzc0?= =?utf-8?B?TmRXVStwVHdkOW8xdnJiRUtodlJoNGcrWkxmdTVZKys4b3RjdkcrS2F4ZS9F?= =?utf-8?B?d0l6RFJuNVovcW9YeUUwdUEwUkxjblF4bzBpOURPaVJDMFQ0cnhmbWJPMTBR?= =?utf-8?B?OFpacDg1OWt2Mkg5L0VLenJPK2NmYk5jU1lMTC9qL3VoZDMrOXdKUVE5SGFo?= =?utf-8?B?VC9MMm9Bc0lmTjFmUzIwNE4yZ283bFRGYlc3Rzk4YkJoNVl5aUF3dWhWN29B?= =?utf-8?B?dUVjWmpZYkFsYnNNSlh5TTJ0bHlXTTJqKzQreHdqQkl0V1p1dkxLWFo4bmp6?= =?utf-8?B?VTlmU1E1Rjc0V2duMmszQ3NVVCtTVFdVUzk1b1l3ZFF5b2hrT1ZvUXJlaURS?= =?utf-8?B?WTVYd1A2clV5QkU2Y01ITWFnOXhQRjdHSFRwakR6T1BDbjQvcTdMK3ZLL1dH?= =?utf-8?B?dDhnT0NTVkN0WEkrck4rR2thUzV3U0IvdmNJVE1CaHFxRnZCTWRIM0ZlOUZl?= =?utf-8?B?OW1PTUlTV09rUUhMaktCNTdwSER5Umpla1JqeDVsM21VRWtzWElMb0h1d1Zx?= =?utf-8?B?VXRVQ1VCZnNoQ3Y0Z1VCYUFVc29taXZrdkhicUxxVTJkMWR0cUxFVDArYVFU?= =?utf-8?B?ZWptRHNxRTRuSkVhSjNVTUhaNzIwOHZ4bzhLbGxsSDZuOFJiMGhuKzhJNWdx?= =?utf-8?Q?f7XnhJQo1WmgndM1xL1q1WPMw?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b01557c-ff0a-4fb0-82a1-08dc3ec08ed9 X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB8596.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 16:06:33.4558 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +y6eSwhJKTiTCFjdTX+ktTxhIsqvnAgXZpj3slEgYse9pRCtQPmv0pIs8LNqXQRz2jeitZgf2TkcV/HTEAlW4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9318 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------SlPWQ8udOCa0PRxiBeQh3EaD Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> - printf("Error: Source or destination numa exceeds the acture numa nodes.\n"); >> + printf("Error: %s numa exceeds the available numa nodes.\n", >> + (cfg->src_numa_node >= nr_sockets) ? "Source" : "Destination"); Thank you for comments, please find my reasoning as `change is added to address spelling issue of acture numa to available numa` > There are three cases to invoking: > 1) src_numa_node >= nr_sockets > 2) dst_numa_node >= nr_sockets > 3) both src_numa_node and dst_numa_node >= nr_sockets As per my testing, following scenarios are explored 1) if src-numa is incorrect, we get error message as `source is incorrect numa` 2) if dst-numa is incorrect, we get error message as `destination is incorrect numa` 3) if both src-numa and dst-numa are incorrect, we get error as `source is incorrect numa`, fixing source and rerunning `destination is incorrect numa` (which is expected) > > It could cover cases 1&2 in your commit, but could not cover case 3. I am happy to make changes to reflect the third scenario also. But please note as shared, the real intention is to fix ` acture numa` to something meaningful. > So I think we should keep original implement. I humbly disagree, based on the explanation as shared above. I can share v2 patch to address 1. acture numa 2. soruce or destination or src & destination --------------SlPWQ8udOCa0PRxiBeQh3EaD Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit


<snipped>

-             printf("Error: Source or destination numa exceeds the acture numa nodes.\n");
+             printf("Error: %s numa exceeds the available numa nodes.\n",
+                             (cfg->src_numa_node >= nr_sockets) ? "Source" : "Destination");

Thank you for comments, please find my reasoning as `change is added to address spelling issue of acture numa to available numa`

There are three cases to invoking:
1) src_numa_node >= nr_sockets
2) dst_numa_node >= nr_sockets
3) both src_numa_node and dst_numa_node >= nr_sockets

As per my testing, following scenarios are explored

1) if src-numa is incorrect, we get error message as `source is incorrect numa`

2) if dst-numa is incorrect, we get error message as `destination is incorrect numa`

3) if both src-numa and dst-numa are incorrect, we get error as `source is incorrect numa`, fixing source and rerunning `destination is incorrect numa` (which is expected)


It could cover cases 1&2 in your commit, but could not cover case 3.
I am happy to make changes to reflect the third scenario also. But please note as shared, the real intention is to fix ` acture numa` to something meaningful.
So I think we should keep original implement.

I humbly disagree, based on the explanation as shared above. I can share v2 patch to address

1. acture numa

2. soruce or destination or src & destination


<snipped>

--------------SlPWQ8udOCa0PRxiBeQh3EaD--