From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 754CA2B84 for ; Fri, 16 Nov 2018 09:42:36 +0100 (CET) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20181116084235euoutp02a5e6b1d81537234074edf006d2592157~njjTf02oR2732927329euoutp02S for ; Fri, 16 Nov 2018 08:42:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20181116084235euoutp02a5e6b1d81537234074edf006d2592157~njjTf02oR2732927329euoutp02S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1542357755; bh=zPnUrTSPo/rY1XCXBGFRErHKDfqPazkaw7xohWJyDnk=; h=To:Cc:From:Subject:Date:References:From; b=BC1KxdAzUYe8EdA0pLZi/ddWxXLpPF96WkhAVhHN5GXdkMv5a7cp7YQnpj8FVV6Rv biQVuNfteu+z1rMj7QQOYxO06wkL0QAEi4AlPUykuneLPUGxvmU2vcHEG7ou8zadM9 MkSGzXBVV4xnGCZB0NkAtIGgZ4PcIJhc2LDeHBy4= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181116084234eucas1p1ae8c2acf7957314342a32413f36ed8c2~njjS_hO4l0754707547eucas1p1a; Fri, 16 Nov 2018 08:42:34 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 52.02.04441.AF28EEB5; Fri, 16 Nov 2018 08:42:34 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20181116084233eucas1p2ae806fd36b2fa1ea77d1a450facb0922~njjSNORU40726607266eucas1p23; Fri, 16 Nov 2018 08:42:33 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20181116084233eusmtrp205d97c8f87379482c32e2d2c4146a73d~njjR73PAh2961029610eusmtrp2H; Fri, 16 Nov 2018 08:42:33 +0000 (GMT) X-AuditID: cbfec7f2-5c9ff70000001159-82-5bee82fac775 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 3F.E1.04128.9F28EEB5; Fri, 16 Nov 2018 08:42:33 +0000 (GMT) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20181116084232eusmtip2ed2ebca248bd614cab1bb12b1bc56250~njjRTDQu62053520535eusmtip2V; Fri, 16 Nov 2018 08:42:32 +0000 (GMT) To: "dev@dpdk.org" , Thomas Monjalon , Ferruh Yigit Cc: "ovs-dev@openvswitch.org" , Konstantin Ananyev , "Stokes, Ian" , Kevin Traynor , Ophir Munk , Shahaf Shuler , Eelco Chaudron From: Ilya Maximets Message-ID: <70d58383-da8b-4c15-a8c4-f6f853268486@samsung.com> Date: Fri, 16 Nov 2018 11:42:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJKsWRmVeSWpSXmKPExsWy7djPc7q/mt5FG2xbx2fx7tN2Jos7V36y WdzZe5rd4kr7T3aLjQ/Pslq8/7OIxWLtoQ/sFpOmnGC0mPvpOaPF7TleFp8enGBx4Pb4tWAp q8fiPS+ZPJ5NP8zkcezmNHaPZzf/M3q833eVzaNvyyrGAPYoLpuU1JzMstQifbsEroz+ZVNZ Cxo5K5qWvmFuYJzC3sXIwSEhYCKx+Y1qFyMXh5DACkaJT/teMkI4XxgldnTfZodwPjNK/Dn+ jamLkROso3XrDVaIxHJGiX97XkI5HxklWl6uYgepEhEolDh/8hYLSIJZYBWTROvzLlaQBJuA jsSp1UcYQWxhAQuJ8z/ngdm8AnYS7yfdAFvBIqAqseLQZTYQW1QgQqLj/mo2iBpBiZMzn7CA 2MwC4hJNX1ayQtjyEtvfzmEGWSYhcIpd4vvduSwQt7pIXPnwjBnCFpZ4dXwLO4QtI/F/53yo f+ol7rdAfC0h0MEoMf3QP6iEvcSW1+fAwcQsoCmxfpc+RNhR4vXBBayQ0OOTuPFWEOIGPolJ 26YzQ4R5JTrahCCqVSR+H1wOdYGUxM13n6Eu8JDY0HmTbQKj4iwkn81C8tksJJ/NQrhhASPL Kkbx1NLi3PTUYsO81HK94sTc4tK8dL3k/NxNjMAEdvrf8U87GL9eSjrEKMDBqMTDa1D+NlqI NbGsuDL3EKMEB7OSCG8597toId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rzVDA+ihQTSE0tSs1NT C1KLYLJMHJxSDYycs+VOaisl7vO2V5H+dp/3XGwO/6ZVjxfOsW6ZvGp+qWLItshVukbv+cJd nxxfNuH7GZ5zNsFrXIV3FufvjpvOMMVanmVPVUt+Rvx0nqZiruBzmVnmfyO0FtTXNnR9fB9f KjLhDb+GRmm18uMbk4+rpX2dsI1/n9nNXF+5XTtVpqUrG7tzX1ZiKc5INNRiLipOBAClG6pg XAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCIsWRmVeSWpSXmKPExsVy+t/xe7o/m95FG3w7LWXx7tN2Jos7V36y WdzZe5rd4kr7T3aLjQ/Pslq8/7OIxWLtoQ/sFpOmnGC0mPvpOaPF7TleFp8enGBx4Pb4tWAp q8fiPS+ZPJ5NP8zkcezmNHaPZzf/M3q833eVzaNvyyrGAPYoPZui/NKSVIWM/OISW6VoQwsj PUNLCz0jE0s9Q2PzWCsjUyV9O5uU1JzMstQifbsEvYz+ZVNZCxo5K5qWvmFuYJzC3sXIySEh YCLRuvUGaxcjF4eQwFJGiYYZr5khElISP35dYIWwhSX+XOtigyh6zygxe0UHC0hCRKBQ4uz5 X8wgCWaBNUwSP7qugCXYBHQkTq0+wghiCwtYSJz/OQ/M5hWwk3g/6QYTiM0ioCqx4tBlNhBb VCBC4uzLdVA1ghInZz4Bm8MsoC7xZ94lZghbXKLpy0pWCFteYvvbOcwTGAVmIWmZhaRlFpKW WUhaFjCyrGIUSS0tzk3PLTbSK07MLS7NS9dLzs/dxAiMwW3Hfm7Zwdj1LvgQowAHoxIPr0H5 22gh1sSy4srcQ4wSHMxKIrzl3O+ihXhTEiurUovy44tKc1KLDzGaAj00kVlKNDkfmB7ySuIN TQ3NLSwNzY3Njc0slMR5zxtURgkJpCeWpGanphakFsH0MXFwSjUwOpc2/AmZoxh1VVbnWM+d +Q5bIkNurTdxvLdN+GjBgeQn2RIfnspzKcce3jb7k77sRs1JmrN9H146/mbGVys7eeHmCa4s S775VU66MOP8Pw6WhXOqHF9s3L5yHbu875lZC06u9tE5y6w3vzPhw7fwmd1Rv9/fjjTe+PDy q5wrEcXrs/Plzl7Z8FKJpTgj0VCLuag4EQAf4OPu1wIAAA== X-CMS-MailID: 20181116084233eucas1p2ae806fd36b2fa1ea77d1a450facb0922 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181116084233eucas1p2ae806fd36b2fa1ea77d1a450facb0922 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181116084233eucas1p2ae806fd36b2fa1ea77d1a450facb0922 References: Subject: [dpdk-dev] Direct using of 'rte_eth_devices' in DPDK apps. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Nov 2018 08:42:36 -0000 Hi, While discussing the ways to enable DPDK 18.11 new features in OVS there was suggestions to use 'rte_eth_devices[]' array directly. But this array is marked as '@internal' and also it located in the internal header 'lib/librte_ethdev/rte_ethdev_core.h' with the following disclaimer: /** * @file * * RTE Ethernet Device internal header. * * This header contains internal data types. But they are still part of the * public API because they are used by inline functions in the published API. * * Applications should not use these directly. * */ >>From the other hand, test-pmd and some example apps in DPDK source tree are using this array for various reasons. So, is it OK to use this array directly or not? In general we need to change the API, i.e. make 'rte_eth_devices' part of a public API. Or change the test-pmd and example apps to stop using it. One more related question: Is it OK to access internal device stuff using 'device' pointer obtained by 'rte_eth_dev_info'? This looks really dangerous. It's unclear why pointers like this exposed to user. Thoughts? Best regards, Ilya Maximets.