RE: [RFC PATCH v1 00/15] merge DTS core files to DPDK

["Juraj Linkeš" <juraj.linkes@pantheon.tech>]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, April 7, 2022 9:34 AM
> To: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Cc: Jerin Jacob <jerinjacobk@gmail.com>; David Marchand
> <david.marchand@redhat.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; ohilyard@iol.unh.edu; Tu, Lijuan
> <lijuan.tu@intel.com>; dpdk-dev <dev@dpdk.org>
> Subject: Re: [RFC PATCH v1 00/15] merge DTS core files to DPDK
> 
> 07/04/2022 07:04, Jerin Jacob:
> > On Wed, Apr 6, 2022 at 8:26 PM Juraj Linkeš <juraj.linkes@pantheon.tech>
> wrote:
> > >

First of all, thanks for the feedback. We've already done a bit of a pre-review and this is where we decided we want the feedback from the rest of the community. We understand it's going to take time which is why we wanted to get feedback sooner than later.

> > > These are the basic libraries that other libraries depend on.
> > > There's also the basic framework functionality related to test execution.
> > >
> > > Juraj Linkeš (15):
> > >   dts: merge DTS dep/tclclient.tgz to DPDK
> > >   dts: merge DTS dep/tgen.tgz to DPDK
> > >   dts: merge DTS dts to DPDK
> > >   dts: merge DTS framework/__init__.py to DPDK
> > >   dts: merge DTS framework/asan_test.py to DPDK
> > >   dts: merge DTS framework/checkCase.py to DPDK
> > >   dts: merge DTS framework/dts.py to DPDK
> > >   dts: merge DTS framework/exception.py to DPDK
> > >   dts: merge DTS framework/logger.py to DPDK
> > >   dts: merge DTS framework/packet.py to DPDK
> > >   dts: merge DTS framework/project_dpdk.py to DPDK
> > >   dts: merge DTS framework/serializer.py to DPDK
> > >   dts: merge DTS framework/utils.py to DPDK
> > >   dts: merge DTS main.py to DPDK
> > >   dts: merge DTS version.py to DPDK
> >
> > merge->import
> >

Ack. I'll keep this in mind when composing commit messages in the future.

> > >
> > >  dts/dep/tclclient.tgz         |  Bin 0 -> 199327 bytes
> > >  dts/dep/tgen.tgz              |  Bin 0 -> 134392 bytes
> >
> > Some top level comments:
> > - I think, we should not check in binary files.
> 
> +1
> 

Thanks, we'll make sure to make this a requirement - it makes sense to us as well.

> > - git commit comment should much more than "dts: merge DTS xxxx to
> > DPDK" where the commit log should have details on check in.
> 
> +1

Right, this is part of the broader question of how exactly are we going to move the whole thing. More below.

> 
> > -Add the documentation from the first patch and update the
> > documentation per patch based on the content.
> 
> +1
> 
> More comments:
> 
> - Please don't send so many patches, it looks like spam.
> - Please let's start small with the very minimal code to run a dummy test.
> - Split by file does not make sense

This is very useful. We started with splitting up DTS into logical chunks, but it's not quite what you have in mind. We'll move things around and send just the first part (containing just a dummy test (is a smoke test ok?) with the necessary code). Now that we have a better understanding of the first step we'll produce a more complete patch set, with proper commit messages and files in each commit.

> 
> The process is going to be very long.
> The techboard said in the past that we must have a very careful review of an
> import piece by piece. So please be patient.
> Thank you
> 
>