From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0F63DA05D3 for ; Thu, 23 May 2019 10:56:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 05B602B9E; Thu, 23 May 2019 10:56:28 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A112EA69 for ; Thu, 23 May 2019 10:56:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 May 2019 01:56:25 -0700 X-ExtLoop1: 1 Received: from jdcole-mobl1.amr.corp.intel.com (HELO [10.252.22.10]) ([10.252.22.10]) by orsmga003.jf.intel.com with ESMTP; 23 May 2019 01:56:23 -0700 To: Nicolas Dichtel , dev@dpdk.org Cc: Olivier Matz , Didier Pallard References: <20190522154143.8041-1-nicolas.dichtel@6wind.com> From: "Burakov, Anatoly" Message-ID: <70ffa3f2-e80c-d7d8-1405-eb9b950761a8@intel.com> Date: Thu, 23 May 2019 09:56:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190522154143.8041-1-nicolas.dichtel@6wind.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] librte_eal: ease init in a docker container X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 22-May-19 4:41 PM, Nicolas Dichtel wrote: > move_pages() is only used to get the numa node id, but this function > is not allowed by default in docker (it needs CAP_SYS_NICE and an update of > the seccomp profile). > get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in > the default seccomp profile. > > Note that the returned value of move_pages() was not checked, thus some > errors could be hidden (if the requested id was 0). > > Signed-off-by: Nicolas Dichtel > Reviewed-by: Olivier Matz > Reviewed-by: Didier Pallard > --- Acked-by: Anatoly Burakov Still, should at least specify Cc: stable, if not Fixes tag too (since ignoring return value of move_pages() is technically a bug). -- Thanks, Anatoly