From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C94EA034F; Mon, 22 Mar 2021 15:59:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12BCA40040; Mon, 22 Mar 2021 15:59:57 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 428D24003D for ; Mon, 22 Mar 2021 15:59:56 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id CFEEC7F45C; Mon, 22 Mar 2021 17:59:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru CFEEC7F45C DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1616425195; bh=6AYlmoXgaUPXTV9bNeoYq7OKfv8TfgLZyxe8vbUoMJM=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=GzwfdtrPIWoznzECEHRAq6Syzc3kBXTk7V9ycfsJ3B/kyE85iybDE4Cz3Lg7sImeV SidNmFJeJriDujheWE8mzjHultBJYkls/VLfD520lhoqUYAcV2cF8YSSIsnewbNJfQ PR1ZMns8OJbVQCioH3iFvfN+iEHTyx+gwAnzj2f8= To: Bing Zhao , NBU-Contact-Thomas Monjalon Cc: Ori Kam , "ferruh.yigit@intel.com" , "dev@dpdk.org" References: <1615967952-228321-1-git-send-email-bingz@nvidia.com> <4868470.BFrr8Tzbyp@thomas> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <7101c740-84d4-3da4-61a3-d45aa9168ba1@oktetlabs.ru> Date: Mon, 22 Mar 2021 17:59:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] ethdev: introduce action context APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/17/21 7:10 PM, Bing Zhao wrote: > Hi Thomas, > >> -----Original Message----- >> From: Thomas Monjalon >> Sent: Wednesday, March 17, 2021 4:29 PM >> To: Bing Zhao >> Cc: Ori Kam ; ferruh.yigit@intel.com; >> andrew.rybchenko@oktetlabs.ru; dev@dpdk.org >> Subject: Re: [RFC] ethdev: introduce action context APIs >> >> External email: Use caution opening links or attachments >> >> >> 17/03/2021 08:59, Bing Zhao: >>> The new functions rte_flow_action_ctx* that were added will >> replace >>> the curret shared functions rte_flow_shared_action_*. >>> - rte_flow_shared_action_create >>> - rte_flow_shared_action_destroy >>> - rte_flow_shared_action_update >>> - rte_flow_shared_action_query >>> + rte_flow_action_ctx_create >>> + rte_flow_action_ctx_destroy >>> + rte_flow_action_ctx_update >>> + rte_flow_action_ctx_query >>> >>> When creating a action context, it could be shared among different >>> flows or different ports. Or it could also be used by a single >> flow. >>> The name "shared" is improper in a sense. >> >> Is it the only reason for the change? >> I better understand "shared" even if it is sometimes not shared. > > Another reason is as written in the description of commit message, currently the update interface use the rte_flow_action as the input parameter. It would limit the ability of updating, since rte_flow_action only have the "conf" w/o any mask or flag bits. > > If only part of the fields need to be updated, it couldn't meet the needs. Sorry, it is too vague. Context in the RFC looks insufficient to understand it. Please, provide more details and real-life examples.