From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Andriy Berestovskyy <Andriy.Berestovskyy@caviumnetworks.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()
Date: Fri, 07 Apr 2017 14:15:47 +0200 [thread overview]
Message-ID: <7103767.xpENpphzvJ@xps13> (raw)
In-Reply-To: <1491562925-27247-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com>
2017-04-07 13:02, Andriy Berestovskyy:
> At the moment rte_eth_dev_configure() behaves inconsistent:
> - for normal frames: zero max_rx_pkt_len uses a default
> - for jumbo frames: zero max_rx_pkt_len gives an error
>
> This patch fixes this inconsistency by using a default value
> if max_rx_pkt_len is zero both for normal and jumbo frames.
>
> Signed-off-by: Andriy Berestovskyy <Andriy.Berestovskyy@caviumnetworks.com>
> ---
>
> Notes:
> v3 changes:
> - use a default only if max_rx_pkt_len is zero
Looks good.
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
It is a small API change but it is fixing an inconsistency,
so I think it can be integrated in 17.05-rc2 as is.
Any different opinion?
next prev parent reply other threads:[~2017-04-07 12:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 17:06 [dpdk-dev] [PATCH] ether: fix configure() to use a default for max_rx_pkt_len Andriy Berestovskyy
2017-03-24 11:52 ` [dpdk-dev] [PATCH v2] ether: use a default for max Rx frame size in configure() Andriy Berestovskyy
2017-03-27 6:15 ` Yang, Qiming
2017-03-27 8:38 ` Andriy Berestovskyy
2017-04-07 8:24 ` Bruce Richardson
2017-04-06 20:48 ` Thomas Monjalon
2017-04-07 8:09 ` Andriy Berestovskyy
2017-04-07 8:34 ` Thomas Monjalon
2017-04-07 8:55 ` Andriy Berestovskyy
2017-04-07 11:02 ` [dpdk-dev] [PATCH v3] " Andriy Berestovskyy
2017-04-07 12:15 ` Thomas Monjalon [this message]
2017-04-07 12:29 ` Bruce Richardson
2017-04-07 14:18 ` Andriy Berestovskyy
2017-04-07 14:47 ` Thomas Monjalon
2017-04-07 15:27 ` Andriy Berestovskyy
2017-04-20 22:25 ` Thomas Monjalon
2017-04-24 14:50 ` Andriy Berestovskyy
2017-07-31 22:33 ` Thomas Monjalon
2018-05-22 22:30 ` Thomas Monjalon
2018-05-23 5:21 ` Shahaf Shuler
2018-05-23 5:23 ` Jerin Jacob
2018-05-24 9:20 ` Andriy Berestovskyy
2019-01-23 18:36 ` Ferruh Yigit
2019-01-25 21:15 ` Andriy Berestovskyy
2017-04-10 14:30 ` [dpdk-dev] [PATCH 1/3] examples/ip_fragmentation: limit max frame size Andriy Berestovskyy
2017-04-10 14:30 ` [dpdk-dev] [PATCH 2/3] examples/ip_reassembly: " Andriy Berestovskyy
2017-04-10 14:30 ` [dpdk-dev] [PATCH 3/3] examples/ipv4_multicast: " Andriy Berestovskyy
2017-04-21 0:21 ` [dpdk-dev] [PATCH 1/3] examples/ip_fragmentation: " Thomas Monjalon
2023-06-08 16:51 ` [PATCH v3] ether: use a default for max Rx frame size in configure() Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7103767.xpENpphzvJ@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=Andriy.Berestovskyy@caviumnetworks.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).