From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 6F5291BE24;
 Thu, 20 Dec 2018 19:20:42 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
 [10.5.11.12])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id A105A7E44E;
 Thu, 20 Dec 2018 18:20:41 +0000 (UTC)
Received: from [10.36.112.60] (ovpn-112-60.ams2.redhat.com [10.36.112.60])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 837A13844;
 Thu, 20 Dec 2018 18:20:39 +0000 (UTC)
To: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>,
 zhihong.wang@intel.com, tiwei.bie@intel.com, dev@dpdk.org
Cc: stable@dpdk.org, ogawa.yasufumi@lab.ntt.co.jp
References: <201812190440.wBJ4cabt027283@ccmail04.silk.ntt-tx.co.jp>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <711710d0-c31e-23c2-affa-21db73a7f275@redhat.com>
Date: Thu, 20 Dec 2018 19:20:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.1
MIME-Version: 1.0
In-Reply-To: <201812190440.wBJ4cabt027283@ccmail04.silk.ntt-tx.co.jp>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.27]); Thu, 20 Dec 2018 18:20:41 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH] net/vhost: fix double free of MAC addrs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Dec 2018 18:20:42 -0000



On 12/19/18 5:37 AM, Hideyuki Yamashita wrote:
> The common data freeing has been moved to rte_eth_dev_release_port(),
> so freeing mac_addrs like this in eth_dev_close() is unnecessary and
> will cause double free.
> 
> Fixes: e16adf08e54d ("ethdev: free all common data when releasing port")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
> Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> ---
>   drivers/net/vhost/rte_eth_vhost.c | 1 -
>   1 file changed, 1 deletion(-)
> 

Applied to dpdk-next-virtio.

Maxime