From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Chenbo Xia <chenbo.xia@intel.com>, dev@dpdk.org
Subject: Re: [PATCH] examples/vhost: fix port init failure in mergeable mode
Date: Tue, 16 Nov 2021 10:14:45 +0100 [thread overview]
Message-ID: <71299887-865b-f165-1d9c-1dd25578716c@redhat.com> (raw)
In-Reply-To: <20211104051102.7155-1-chenbo.xia@intel.com>
On 11/4/21 06:11, Chenbo Xia wrote:
> When the example starts in mergeable mode with an i40e port,
> it fails to launch because the examples use default mtu MAX_MTU
> to configure ethdev. The root cause is some devices have Ethernet
> frame overhead and then MAX_MTU will be larger than device's max
> mtu, so the ethdev configure will fail.
>
> This patch checks the device's max mtu before setting the ethdev
> configuration. If the device has a max mtu, use that value to
> configure.
>
> Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length")
>
> Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
> Reported-by: Xingguang He <xingguang.he@intel.com>
> ---
> examples/vhost/main.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index 58e12aa710..09fb2382bf 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -273,6 +273,13 @@ port_init(uint16_t port)
>
> tx_rings = (uint16_t)rte_lcore_count();
>
> + if (mergeable) {
> + if (dev_info.max_mtu != UINT16_MAX && dev_info.max_rx_pktlen > dev_info.max_mtu)
> + vmdq_conf_default.rxmode.mtu = dev_info.max_mtu;
> + else
> + vmdq_conf_default.rxmode.mtu = MAX_MTU;
> + }
> +
> /* Get port configuration. */
> retval = get_eth_conf(&port_conf, num_devices);
> if (retval < 0)
> @@ -631,8 +638,6 @@ us_vhost_parse_args(int argc, char **argv)
> return -1;
> }
> mergeable = !!ret;
> - if (ret)
> - vmdq_conf_default.rxmode.mtu = MAX_MTU;
> break;
>
> case OPT_STATS_NUM:
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2021-11-16 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 5:11 [dpdk-dev] " Chenbo Xia
2021-11-05 7:32 ` Xia, Chenbo
2021-11-05 9:00 ` Maxime Coquelin
2021-11-16 9:14 ` Maxime Coquelin [this message]
2021-11-16 10:25 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71299887-865b-f165-1d9c-1dd25578716c@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).