From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E850A0560; Tue, 18 Oct 2022 16:15:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B21640395; Tue, 18 Oct 2022 16:15:07 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4DF714021D for ; Tue, 18 Oct 2022 16:15:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666102504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5bmELfR64VpyEQYwZYTwzpdguFV1bA7YiPxNWC3o3fg=; b=OxAxKDSHQ+BzXFIOB3IVhI81t0YfnVXrK3afyxuE/EAZma8n0wpi74m+0eIxtb+JiZdv9c 7FLodTeoJivxyDE/3OdZ4Q2A/r7Axp/4DpP1FdIdIO4dpMeJQMcKG3PsYm/Qo6090jjsi0 dDT2szIDKnlhDiEQjQ0yetSWoXTUnwY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-327-Hu04Zb3yOsyYyUSt508DmA-1; Tue, 18 Oct 2022 10:15:01 -0400 X-MC-Unique: Hu04Zb3yOsyYyUSt508DmA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C26B329AA38A; Tue, 18 Oct 2022 14:15:00 +0000 (UTC) Received: from [10.39.208.29] (unknown [10.39.208.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 79A922022C2B; Tue, 18 Oct 2022 14:14:59 +0000 (UTC) Message-ID: <713353b8-828c-bdcd-956e-162171fd68d6@redhat.com> Date: Tue, 18 Oct 2022 16:14:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 To: Andy Pei , dev@dpdk.org Cc: chenbo.xia@intel.com, rosen.xu@intel.com, wei.huang@intel.com, gang.cao@intel.com References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1666094871-25721-1-git-send-email-andy.pei@intel.com> <1666094871-25721-13-git-send-email-andy.pei@intel.com> From: Maxime Coquelin Subject: Re: [PATCH v8 12/12] vhost: improve vDPA blk device configure condition In-Reply-To: <1666094871-25721-13-git-send-email-andy.pei@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/18/22 14:07, Andy Pei wrote: > To support multi-queue, configure device > after call fd of all queues are set. > > Signed-off-by: Andy Pei > Signed-off-by: Huang Wei > --- > lib/vhost/vhost_user.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c > index e0ff79d..9902ae9 100644 > --- a/lib/vhost/vhost_user.c > +++ b/lib/vhost/vhost_user.c > @@ -2972,6 +2972,7 @@ static int is_vring_iotlb(struct virtio_net *dev, > bool handled; > uint32_t request; > uint32_t i; > + uint16_t blk_call_fd; > > dev = get_device(vid); > if (dev == NULL) > @@ -3181,9 +3182,15 @@ static int is_vring_iotlb(struct virtio_net *dev, > if (!vdpa_dev) > goto out; > > - if (vdpa_dev->type == RTE_VHOST_VDPA_DEVICE_TYPE_BLK > - && request != VHOST_USER_SET_VRING_CALL) > - goto out; > + if (vdpa_dev->type == RTE_VHOST_VDPA_DEVICE_TYPE_BLK) { > + if (request == VHOST_USER_SET_VRING_CALL) { > + blk_call_fd = ctx.msg.payload.u64 & VHOST_USER_VRING_IDX_MASK; > + if (blk_call_fd != dev->nr_vring - 1) > + goto out; > + } else { > + goto out; > + } > + } > > if (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED)) { > if (vdpa_dev->ops->dev_conf(dev->vid)) Reviewed-by: Maxime Coquelin Thanks, Maxime