From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 1EF5F47CD for ; Mon, 14 Mar 2016 00:10:50 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id n186so85194370wmn.1 for ; Sun, 13 Mar 2016 16:10:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=WS/5UT9zQXE5mSsnnSqNLTbUMEZ1c0SSZcJ15L3OmVo=; b=ylv4k/en1EsB2c7eDxRK4sokmm54VIL28HoqZ+lZxlXFcDvq5osfitmQo0CIQCWrrU StlkWBkVDlLdgy4DedKv6fIMm809Yiyb8PASVtIAmb+zivOg3QQnOEezi0L2FsoosUmJ ZjZVni2Zt/igkWVwIyqHInWRiViJXIr2EFhoF9HTe7GJwOOPZpE7hHxjFF9srmXEW4UT kca/NIUMao42JpDabw/jJky/G+/wxj3XxpU3lIhU6UEO3xCQWZJiSNZyb7X+ztwU4aYm nxwHg9EKvuHF5KWcuHqvQgcVC9OmaWSOHaL+m8R3QScPPUnhg3/gjqx0HUksXsQUlT6u ghHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=WS/5UT9zQXE5mSsnnSqNLTbUMEZ1c0SSZcJ15L3OmVo=; b=LL6eLRwbxEWMMsqqwH5ST2wg+v+VrB4E8x9nmpf+R+l+yGg1oO1ZF4EbmYkgOBlaz/ e9HnNfBQKAe3yHcU0esVGQa9tngtCO+VUPm1uG6sXLdEg4DrrJQofODR4D5PBsMzlRHW O3PrpecOucJBaTQp294XDDkuvsYBAmqNVCDIhncAUgCnBty5IcsmUtqd6G3Y4Ih2MwhU ZIYhxR6THfS0fdys2l4xy2PvtlvFJfnptQgb4OwqWJ0MUMNXK3vXQcfbdtMi4HL2BPGB QkW7+uP6b1t2rSIQo39bLVvo62KvdcmnvweG/aelOgBj1WEXBfllxAZ2kwCm0GHeCuUx LHnw== X-Gm-Message-State: AD7BkJLoUvwvA2+AMZrRXWe13UmZe7g7TqURgJZXXkYmK/mqj5gxzZYRgbTtv2YEAf35A9xx X-Received: by 10.28.172.132 with SMTP id v126mr14660120wme.28.1457910649962; Sun, 13 Mar 2016 16:10:49 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id c128sm13403692wma.11.2016.03.13.16.10.48 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 13 Mar 2016 16:10:49 -0700 (PDT) From: Thomas Monjalon To: "Dumitrescu, Cristian" , Stephen Hemminger Cc: dev@dpdk.org Date: Mon, 14 Mar 2016 00:09:27 +0100 Message-ID: <7147300.0jXl9hpqrT@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891264796D475@IRSMSX108.ger.corp.intel.com> References: <1448822809-8350-1-git-send-email-stephen@networkplumber.org> <4107462.qD4IMYcbAE@xps13> <3EB4FA525960D640B5BDFFD6A3D891264796D475@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/3] sched: patches for 2.2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Mar 2016 23:10:50 -0000 2016-03-13 22:47, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2016-03-08 07:49, Dumitrescu, Cristian: > > > Regarding Stephen's patches, I think there is a pending issue regarding the > > legal side of the Copyright, which is attributed to Intel, although Stephen's > > code is relicensed with BSD license by permission from the original code > > author (which also submitted the code to Linux kernel under GPL). This was > > already flagged. This is a legal issue and I do not feel comfortable with ack-ing > > this patch until the legal resolution on this is crystal clear. > > > > > > I also think the new files called rte_reciprocal.[hc] implement an algorithm > > that is very generic and totally independent of the QoS code, therefore it > > should be placed into a different folder that is globally visible to other > > libraries (librte_eal/common ?) just in case other usages for this algorithm > > are identified in the future. I suggest we break the patch into two separate > > patches submitted independently: one introducing the rte_reciprocal.[hc] > > algorithm to librte_eal/common and the second containing just the > > librte_sched changes, which are small. I am thinking ahead here: once we > > have the 2x64-bit multiplication solution in place, we should not have > > rte_reciprocal.[hc] hanging in librte_sched folder without being used here, > > while it might be used by other parts of DPDK. > > > > Let's keep the improvement as-is to test it in the first release candidate. > > We can move the code and/or fix the file header later. > > > > Series applied, thanks. > > Hi Thomas, > > I am OK with this, as long as Stephen commits to fix the copyright in the > header file There is no copyright issue. Just an Intel mention in the disclaimer. > and move the rte_reciprocal.[hc] into a common area like > librte_eal/common in time for the next release candidate. If it is moved as a public API, it must be better documented. If it stay here, it must be removed from SYMLINK-y-include.