From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AB81A00C5; Mon, 6 Jul 2020 09:04:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 44C301D6DA; Mon, 6 Jul 2020 09:04:04 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 983431D632 for ; Mon, 6 Jul 2020 09:04:02 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id E6A115804B7; Mon, 6 Jul 2020 03:04:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 06 Jul 2020 03:04:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= K3m+m/BbXgUWa+YCZRK/Nq4+0kjbRu55wAn4hJ/bnao=; b=PKnGk9b3izqd5vOK waAg/T+V5y8Go7G1goYx//FlfO1LFfzAZd/ssD+GAMvt4QHrItP03iMBZ229wuKh icWGXK1H6tbpt1duVRM2whx/E54omRivg9VLPaIUTsw1CM95Da5vGJGrydwaKzpO AAhS+yWm/LmzngklwXnUB3dor6u22Jxl753NRRnpZ55k9bWLMFA9EJFUM/dNVwf3 3PZWsFy36HtEwx9ONQPoyxh/GwOIMAHHzqq0wM1AeQmz39F4cOg0FfHiLBxFvyFl aOht7TgK1CkByFR0LH3lPHUkscT1gt9wrLS82Q45l4gRMvV04ut4rQPzk4PfFfQw GVjVeg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=K3m+m/BbXgUWa+YCZRK/Nq4+0kjbRu55wAn4hJ/bn ao=; b=vL1P9oOfZO89kE8oOLGJ1SAsxUkym9ji/T60VJaK/ov+CVAD0CKELG8QW HB+CD4zI5Ujc0kag5onLjLV+AoCWlJNC+PjiQgdq2UJ9CKwzxCd/QyALaiT3M2F1 SMk6zMCspDt8ePDFsr0Vw4MexIY4j3iw6LSduoXazBKUjiIPAsVBPCkVN/6O+u69 XCy3AV3jZopZ/Ibf7FXGrT2uYJ/Q9Hnxxdse/KR4U5ysflez2VwQ0Sj4p0I1IADP 4PyYls1cP6p+2Cv4ugFewFW54LeVT/NfSDrl+Z6omDScvgz2JR5jxrPF8A5YpLSD 97LbGLdXTeTQGhKfF5umsWtJRNQGw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddvgdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B70F6328005D; Mon, 6 Jul 2020 03:03:51 -0400 (EDT) From: Thomas Monjalon To: "bruce.richardson@intel.com" , Ori Kam Cc: "jerinj@marvell.com" , "xiang.w.wang@intel.com" , "guyk@marvell.com" , "dev@dpdk.org" , "pbhagavatula@marvell.com" , Shahaf Shuler , "hemant.agrawal@nxp.com" , Opher Reviv , Alex Rosenbaum , "dovrat@marvell.com" , "pkapoor@marvell.com" , "nipun.gupta@nxp.com" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , "jim@netgate.com" , "hongjun.ni@intel.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , Parav Pandit Date: Mon, 06 Jul 2020 09:03:49 +0200 Message-ID: <7150376.Hi7RSQvopO@thomas> In-Reply-To: References: <1585464438-111285-1-git-send-email-orika@mellanox.com> <6699717.7Ub6e2Nl0Q@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 3/4] regexdev: add regexdev core functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/07/2020 08:07, Ori Kam: > From: Thomas Monjalon > > 02/07/2020 09:46, Ori Kam: > > > --- a/meson_options.txt > > > +++ b/meson_options.txt > > > @@ -30,6 +30,8 @@ option('max_lcores', type: 'integer', value: 128, > > > description: 'maximum number of cores/threads supported by EAL') > > > option('max_numa_nodes', type: 'integer', value: 4, > > > description: 'maximum number of NUMA nodes supported by EAL') > > > +option('max_regexdev_devs', type: 'integer', value: 32, > > > + description: 'maximum number of RegEx devices') > > > > Do we really want to add such option in meson? > > Some other classes do not expose any option here. > > I tend to think it should be hidden. > > If the max is really varying, it should be dynamic. > > By the way, the maximum number of ethdev ports should be made infinite > > with a dynamic array. > > > > Bruce, any opinion please? > > > Why this is just like ethdev: > option('max_ethports', type: 'integer', value: 32, > description: 'maximum number of Ethernet devices') Ethdev is the only class exposing such option. And we already have some requests to replace it with on-demand runtime dynamic size. That's why it's better not exposing such bad config. Anyway we are probably not going to need more than 32 regex engines in the near future. It gives us time to switch to a dynamic model.