Re: [dpdk-dev] [PATCH v4 2/3] ethdev: add optional rxtx callback support

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-02-20 10:06, Bruce Richardson:
> On Thu, Feb 19, 2015 at 05:56:41PM +0000, John McNamara wrote:
> > From: Richardson, Bruce <bruce.richardson@intel.com>
> > 
> > Add optional support for inline processing of packets inside the RX
> > or TX call. For an RX callback, what happens is that we get a set of
> > packets from the NIC and then pass them to a callback function, if
> > configured, to allow additional processing to be done on them, e.g.
> > filling in more mbuf fields, before passing back to the application.
> > On TX, the packets are similarly post-processed before being handed
> > to the NIC for transmission.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Signed-off-by: John McNamara <john.mcnamara@intel.com>
> > ---
> >  config/common_bsdapp                   |    1 +
> >  config/common_linuxapp                 |    1 +
> >  lib/librte_ether/rte_ethdev.c          |  192 +++++++++++++++++++++++++++++-
> >  lib/librte_ether/rte_ethdev.h          |  204 +++++++++++++++++++++++++++++++-
> >  lib/librte_ether/rte_ether_version.map |    4 +
> >  5 files changed, 397 insertions(+), 5 deletions(-)
> > 
> > diff --git a/config/common_bsdapp b/config/common_bsdapp
> > index f11ff39..e9c445e 100644
> > --- a/config/common_bsdapp
> > +++ b/config/common_bsdapp
> > @@ -133,6 +133,7 @@ CONFIG_RTE_LIBRTE_ETHDEV_DEBUG=n
> >  CONFIG_RTE_MAX_ETHPORTS=32
> >  CONFIG_RTE_LIBRTE_IEEE1588=n
> >  CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16
> > +CONFIG_RTE_LIBRTE_ETHDEV_RXTX_CALLBACKS=n
> 
> I no reason why this should not be "y" by default. Those who are not using it
> and don't want the tiny performance impact of it, can turn it off. 

If you are going to change it, I think the shorter name CONFIG_RTE_ETHDEV_RXTX_CALLBACKS
would be sufficient.