From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-we0-f169.google.com (mail-we0-f169.google.com [74.125.82.169]) by dpdk.org (Postfix) with ESMTP id ED4ACB567 for <dev@dpdk.org>; Fri, 20 Feb 2015 11:31:35 +0100 (CET) Received: by wesw55 with SMTP id w55so4813172wes.4 for <dev@dpdk.org>; Fri, 20 Feb 2015 02:31:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=OvkLINpUVHb86DNrZ3SsjBrv47FQqrS1mbqiglhZhFE=; b=IjL0mFx5McZWbFj0UWAMurXYJRHCDRzHpaXX9kQgB3Sx04kU6/RANMrSrocf3+r5Q6 AAnY6n//jKtCg0ISDhAvAu/qTwi2UdBqSfM4z5qDBLpU9n0ucdFied7neNW+DZLcIOx7 KzTVpfoDASAtk7jEo51pDz1hTpxPdebGKWZLrDfItkL2CUXEcOwF+7Z1HCQENqeQCI2U zsD3hESof9a071Ex3inWXLcxUSQ9NNQI9F/T/IPXACk5BnzoJE7VJpgW3gV5yfmt7dl9 iu35iV86M+BmsFYfC6/eXdhjwA/68+HVHxrM02xUURxveklyAGE7npNqN6/6/7dPPNpY ixow== X-Gm-Message-State: ALoCoQncB3XTKOclk2SFCPttMkjAbMZ1URV2TR/Q0mHI9x+W2sM3Mce6UHrHWsMU3pRSAZsjqa4k X-Received: by 10.194.80.40 with SMTP id o8mr17360727wjx.34.1424428295783; Fri, 20 Feb 2015 02:31:35 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id a1sm1746970wiy.10.2015.02.20.02.31.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Feb 2015 02:31:35 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Bruce Richardson <bruce.richardson@intel.com>, John McNamara <john.mcnamara@intel.com> Date: Fri, 20 Feb 2015 11:31:03 +0100 Message-ID: <7158573.4LYx2RfyGr@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <20150220100600.GA17276@bricha3-MOBL3> References: <1424281343-2994-1-git-send-email-john.mcnamara@intel.com> <1424368602-30826-3-git-send-email-john.mcnamara@intel.com> <20150220100600.GA17276@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 2/3] ethdev: add optional rxtx callback support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 20 Feb 2015 10:31:36 -0000 2015-02-20 10:06, Bruce Richardson: > On Thu, Feb 19, 2015 at 05:56:41PM +0000, John McNamara wrote: > > From: Richardson, Bruce <bruce.richardson@intel.com> > > > > Add optional support for inline processing of packets inside the RX > > or TX call. For an RX callback, what happens is that we get a set of > > packets from the NIC and then pass them to a callback function, if > > configured, to allow additional processing to be done on them, e.g. > > filling in more mbuf fields, before passing back to the application. > > On TX, the packets are similarly post-processed before being handed > > to the NIC for transmission. > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > > Signed-off-by: John McNamara <john.mcnamara@intel.com> > > --- > > config/common_bsdapp | 1 + > > config/common_linuxapp | 1 + > > lib/librte_ether/rte_ethdev.c | 192 +++++++++++++++++++++++++++++- > > lib/librte_ether/rte_ethdev.h | 204 +++++++++++++++++++++++++++++++- > > lib/librte_ether/rte_ether_version.map | 4 + > > 5 files changed, 397 insertions(+), 5 deletions(-) > > > > diff --git a/config/common_bsdapp b/config/common_bsdapp > > index f11ff39..e9c445e 100644 > > --- a/config/common_bsdapp > > +++ b/config/common_bsdapp > > @@ -133,6 +133,7 @@ CONFIG_RTE_LIBRTE_ETHDEV_DEBUG=n > > CONFIG_RTE_MAX_ETHPORTS=32 > > CONFIG_RTE_LIBRTE_IEEE1588=n > > CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16 > > +CONFIG_RTE_LIBRTE_ETHDEV_RXTX_CALLBACKS=n > > I no reason why this should not be "y" by default. Those who are not using it > and don't want the tiny performance impact of it, can turn it off. If you are going to change it, I think the shorter name CONFIG_RTE_ETHDEV_RXTX_CALLBACKS would be sufficient.