From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 382AEA0550; Sun, 16 Feb 2020 22:25:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0F4CD2C4F; Sun, 16 Feb 2020 22:25:25 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 46996B62; Sun, 16 Feb 2020 22:25:23 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 001287ED; Sun, 16 Feb 2020 16:25:21 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 16 Feb 2020 16:25:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=qnipTMkV4/UPzefoU25idjyfpMEE2mGnoqnpGjqR7nI=; b=dhvQVXRNByj5 ktxylzHVrmMcYOSAx8zJrDaSqNPIM+B1GGR7aYjiUL3BuvQj9sjmdFy5Eg0wHIrW SQ73lXtWeXd2hYLu3vNNyibyWvUqTo2W6fr7EiGDzBYdy/yiC6YrbMAUxG5ag6y6 xi5crsrertDV67+2Nosygk3uKHy3OhM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=qnipTMkV4/UPzefoU25idjyfpMEE2mGnoqnpGjqR7 nI=; b=3cXEpG9P3IvvD7tr0hGDIv/6cXzrc8e1slpYxb41zZJh0hQCLxASv9Zc5 8ZLj4hZP3fzNnlWcjSffOshWtSL/liswEEY0bkrNZsT89IA2EUr8eJyinSvAuyEb ICqrBl0SS1Y975douNxSPjZZhrT6P0tM7azfuG16htOLVzaHlY1yUeD4uMUQV8Dy O+01ZjTI6ZOxQZN66RnfHQlK6XYHwcuaIFZx28FBcfm7ahKZ47Sd143gGgKoxfNu Ks4GULabcIhkj2gdAp5HjSZc623IZ75vrsLUoKzA7XOoeKPKwtjA+fmGrH/xSc6p xhL9pxXXnncA4AUlXOqK4NwQxpoqg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrjeeggddugeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4A4AE328005A; Sun, 16 Feb 2020 16:25:20 -0500 (EST) From: Thomas Monjalon To: "Power, Ciara" Cc: dev@dpdk.org, "andrius.sirvys@intel.com" , "robin.jarry@6wind.com" , "Pattan, Reshma" , "stable@dpdk.org" , "Laatz, Kevin" Date: Sun, 16 Feb 2020 22:25:19 +0100 Message-ID: <7158825.SKYDtnEIZr@xps> In-Reply-To: <9061c5b6ad93430c86382f8d7661175b@intel.com> References: <20200116172425.19246-1-ciara.power@intel.com> <20200121170310.25382-1-ciara.power@intel.com> <9061c5b6ad93430c86382f8d7661175b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] usertools: fix telemetry python3 compatibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/01/2020 11:11, Laatz, Kevin: > > The client script for use with the telemetry library did not support > > Python3, as the data being sent over the socket was in string format. > > Python3 requires the data be explicitly converted to bytes before being > > sent. Similarily, the received bytes need to be decoded into string > > format. > > > > Fixes: 53f293c9a783 ("usertools: replace unsafe input function") > > Fixes: fe35622659ed ("usertools: fix telemetry client with python 3") > > Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") > > Fixes: 4080e46c8078 ("telemetry: support global metrics") > > Cc: andrius.sirvys@intel.com > > Cc: robin.jarry@6wind.com > > Cc: reshma.pattan@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Ciara Power > > Reviewed-by: Robin Jarry > > > > > Acked-by: Kevin Laatz Applied, thanks