From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 30CBAA04DC;
	Sun, 22 Nov 2020 12:22:31 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id DFFD8FFA;
	Sun, 22 Nov 2020 12:22:28 +0100 (CET)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id F02F02AB
 for <dev@dpdk.org>; Sun, 22 Nov 2020 12:22:25 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailout.nyi.internal (Postfix) with ESMTP id 988005C00AD;
 Sun, 22 Nov 2020 06:22:25 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Sun, 22 Nov 2020 06:22:25 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm2; bh=
 H/kA/iJ7/utaFZuWHuZDlQI4CZ2fS+qZaZIZbq5TUdY=; b=AUcHLU4TVOf7/tat
 TittQjAhXUsExHwtGK2OKUc1KPSYHRn5hgTD5r+k8BSv7xgmL4MV9U06IicYVHx3
 WqgKLa848D2dT0yQoGWzQteh1LI0W8S9zTmUSY6ieVknI2e7nZgoPKtKE5b5rgF/
 TFjLeMlDE0JcpIFiCPog5+PJk8vnW8Yj4WnKAVFcmL9XCVdKX4TQ1gZAEWeH/lgW
 D1Lx0vrXSblLsp4F3Xu+NiEnrm0sRrYVCRlEEuaPlXfQXjCX0X4rj6Y23ul+bgE2
 XUQrsbN7fkHIFtCRVflBuz/efXVhMOW3fWkHkpq5RjOmX6WK/nOXJsMRqStzqTeB
 17vOGA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=H/kA/iJ7/utaFZuWHuZDlQI4CZ2fS+qZaZIZbq5TU
 dY=; b=kNy6lwDN+/AikyxYPZv/M1c1U96wY4uuOgLTosPiSRrcEolY2/Ei1ioB+
 jd/YOO7k4gw1imU/t3hfeotNpOxuk3oOQNsFiAdSDxq8W4vsBolPavKrRgXz7FWw
 C6YbSRWOuEpR8UsnoSFMM/ud1GjCGWUCjH9iP6bvoDF6TXPRWu/ysexSnyZxjqwP
 RNsKyVlbd7ntHel7eGwYlXaap4/5DoYnL+xF+WN4Q4phtrBVtCzKTb7GHcM8KAA6
 y5ZU3oHMReB6JZqEhjKN/WpvjKaILG/RCB4ncABokpNP0k8wkwpCDb9tsMWDoE1i
 UszoetB+c9y/FjfZoweAghI9ZglDA==
X-ME-Sender: <xms:8Em6X5vdqXTyL_y2tJVlbOf3oruNXKTwOhvMku4hLHWkaeaDivvn5A>
 <xme:8Em6Xye5RkbJ3TOYYHFSz5UrnLd3yUAp24rMlygUtVtAVIrB2hNIw-U0chB93vL-g
 _UL14bxGhPDUQJu4w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeggedgvdelucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu
 tdejveehveetnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
 hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
 ohhnrdhnvght
X-ME-Proxy: <xmx:8Em6X8w3yu9xotmPUg993EVa5cPBbBhXnzYkl6Dznl6Ky4DWLuc4Dw>
 <xmx:8Em6XwN2LmRn38HiPAS3Q3UBbzxwSMA-ECTgxUhU7QtJnfHIFdeecQ>
 <xmx:8Em6X5-11gZk16GlhQ8j6NDaRqALMEeiFsormo8-uL8nHUsZTcM-AQ>
 <xmx:8Um6X5zfhShpE5cDuWctMKeJUheHhINNMF8jm1LJbPS-HwxlYOruLA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 04262328005E;
 Sun, 22 Nov 2020 06:22:23 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Yicai Lu <luyicai@huawei.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com, zhoujingbin@huawei.com,
 chenchanghu@huawei.com, jerry.lilijun@huawei.com, haifeng.lin@huawei.com,
 guohongzhi1@huawei.com, wangyunjian@huawei.com
Date: Sun, 22 Nov 2020 12:22:22 +0100
Message-ID: <7177305.MHKvZRkaxW@thomas>
In-Reply-To: <1605706193-17192-1-git-send-email-luyicai@huawei.com>
References: <1605706193-17192-1-git-send-email-luyicai@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] ip_frag: recalculate data length of fragment
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

18/11/2020 14:29, Yicai Lu:
> In some situations, we would get several ip fragments=EF=BC=8C which total
> data length is less than minimum frame(64) and padding with zeros.
> Examples: Second Fragment is "a0a1 a2a3 a4a5 a6a7 0000 0000 ..."
> and Third Fragment is "a8a9 aaab acad aeaf b0b1 b2b3 ...".
> And then, we would reassemble Second and Third Fragment like this
> "a0a1 a2a3 a4a5 a6a7 0000 0000 ... a8a9 aaab acad aeaf b0b1 ...",
> which is not correct! So, we need recalculate the data length=20
> of fragment to remove invalid padings(zero)!
>=20
> Signed-off-by: Yicai Lu <luyicai@huawei.com>

Please add a line "Fixes" to identify the root cause,
it will help to know where to backport.