From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBCFD4404F; Wed, 12 Jun 2024 17:13:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72E5842E5B; Wed, 12 Jun 2024 17:05:11 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id A0F9A42D78 for ; Wed, 12 Jun 2024 17:05:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718204707; x=1749740707; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kloleJBvFRsE4XKo21FTwJKfmO1tW2mJpGhz0IceC/o=; b=O5DOIASRw3m74GZp0lg9SDJnmskciFJFjO0+w5EnyqRUlLntHokIeUyN n9r9M6Vdo3D4WRjL99FXJV2YuHA9j/DwbYIhKE+/Km3rkFW8AQ3EEpUGx YaAJp3/Pd4ss9VyzPQLEUEnqdOZm4YuE6HX6xaKGuE6cPUlO4Yu8j59am ZVTmoK+gKoVKACAFUVvKvOXXtbrcQ3XyW8D1+l8yo4n63cytqIpalAvsa 7Ixbh1YrZPheYPEfxU9MZ1LtKTlU2mAme8QruFrhEvftPTGgfttXVuUjR 70bd5ewggeAbk7NBgjTUNoI9cUJRq3uqVLWZuKTAhdMkkfmOYc1QcB25B A==; X-CSE-ConnectionGUID: fVLjN/hJQeWnHNBGdKF0EA== X-CSE-MsgGUID: TG5ZNYyzTaeGg0tWlnfVAg== X-IronPort-AV: E=McAfee;i="6700,10204,11101"; a="32459552" X-IronPort-AV: E=Sophos;i="6.08,233,1712646000"; d="scan'208";a="32459552" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2024 08:04:52 -0700 X-CSE-ConnectionGUID: wnsSl9q8QoGj8sZG3PBFXg== X-CSE-MsgGUID: rtCxEJ68QteswnbcYlg7bQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,233,1712646000"; d="scan'208";a="39925401" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by orviesa009.jf.intel.com with ESMTP; 12 Jun 2024 08:04:51 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Ian Stokes , bruce.richardson@intel.com, Jacob Keller Subject: [PATCH v2 058/148] net/ice/base: use ICE_PTP_NOP to better indicate no action Date: Wed, 12 Jun 2024 16:00:52 +0100 Message-ID: <717e18aa25fbdb823d329fc40319522057b6c327.1718204528.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20240430154014.1026-1-ian.stokes@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Ian Stokes A couple of E822 PTP functions use ICE_PTP_READ_TIME on the main timer to avoid any side effects when programming a single PHY port. Match the ETH56G code by using ICE_PTP_NOP instead, which better reflects the intended behavior. Signed-off-by: Jacob Keller Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_ptp_hw.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/base/ice_ptp_hw.c b/drivers/net/ice/base/ice_ptp_hw.c index 7424b8d6f4..22b3fe917a 100644 --- a/drivers/net/ice/base/ice_ptp_hw.c +++ b/drivers/net/ice/base/ice_ptp_hw.c @@ -4192,8 +4192,8 @@ static int ice_sync_phy_timer_e822(struct ice_hw *hw, u8 port) if (status) goto err_unlock; - /* Init PHC mstr/src cmd for exec during sync */ - ice_ptp_src_cmd(hw, ICE_PTP_READ_TIME); + /* Do not perform any action on the main timer */ + ice_ptp_src_cmd(hw, ICE_PTP_NOP); /* Issue the sync to activate the time adjustment */ ice_ptp_exec_tmr_cmd(hw); @@ -4320,8 +4320,8 @@ ice_start_phy_timer_e822(struct ice_hw *hw, u8 port, bool bypass) if (status) return status; - /* Init PHC mstr/src cmd for exec during sync */ - ice_ptp_src_cmd(hw, ICE_PTP_READ_TIME); + /* Do not perform any action on the main timer */ + ice_ptp_src_cmd(hw, ICE_PTP_NOP); ice_ptp_exec_tmr_cmd(hw); -- 2.43.0