DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/ice: enlarge ice RXQ rearm thresh to 64
@ 2021-01-06  5:35 Leyi Rong
  2021-01-12  5:11 ` Zhang, Qi Z
  0 siblings, 1 reply; 2+ messages in thread
From: Leyi Rong @ 2021-01-06  5:35 UTC (permalink / raw)
  To: qi.z.zhang, wenzhuo.lu; +Cc: dev, Leyi Rong

We observe performance drop on ice AVX512 data path after stop and
start by using testpmd.

As CPU polling is faster in AVX512 path, L3 contested accesses is
intensified when rxrearm_start is a random value after testpmd
stop/start.

Enlarge ICE_RXQ_REARM_THRESH to 64 to ease the contested asscesses and
fix the performance drop issue.

Signed-off-by: Leyi Rong <leyi.rong@intel.com>
---
 drivers/net/ice/ice_rxtx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ice/ice_rxtx.h b/drivers/net/ice/ice_rxtx.h
index 6b16716063..adfae016a9 100644
--- a/drivers/net/ice/ice_rxtx.h
+++ b/drivers/net/ice/ice_rxtx.h
@@ -31,7 +31,7 @@
 
 #define ICE_VPMD_RX_BURST           32
 #define ICE_VPMD_TX_BURST           32
-#define ICE_RXQ_REARM_THRESH        32
+#define ICE_RXQ_REARM_THRESH        64
 #define ICE_MAX_RX_BURST            ICE_RXQ_REARM_THRESH
 #define ICE_TX_MAX_FREE_BUF_SZ      64
 #define ICE_DESCS_PER_LOOP          4
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/ice: enlarge ice RXQ rearm thresh to 64
  2021-01-06  5:35 [dpdk-dev] [PATCH] net/ice: enlarge ice RXQ rearm thresh to 64 Leyi Rong
@ 2021-01-12  5:11 ` Zhang, Qi Z
  0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2021-01-12  5:11 UTC (permalink / raw)
  To: Rong, Leyi, Lu, Wenzhuo; +Cc: dev



> -----Original Message-----
> From: Rong, Leyi <leyi.rong@intel.com>
> Sent: Wednesday, January 6, 2021 1:36 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com>
> Subject: [PATCH] net/ice: enlarge ice RXQ rearm thresh to 64
> 
> We observe performance drop on ice AVX512 data path after stop and start by
> using testpmd.
> 
> As CPU polling is faster in AVX512 path, L3 contested accesses is intensified
> when rxrearm_start is a random value after testpmd stop/start.
> 
> Enlarge ICE_RXQ_REARM_THRESH to 64 to ease the contested asscesses and fix
> the performance drop issue.
> 
> Signed-off-by: Leyi Rong <leyi.rong@intel.com>


Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel after add cc:stable tag.

Thanks
Qi



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-12  5:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-06  5:35 [dpdk-dev] [PATCH] net/ice: enlarge ice RXQ rearm thresh to 64 Leyi Rong
2021-01-12  5:11 ` Zhang, Qi Z

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git