From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id CA6E21B46B; Thu, 27 Sep 2018 13:49:26 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 30FA9A8BB; Thu, 27 Sep 2018 11:49:26 +0000 (UTC) Received: from [10.36.112.65] (ovpn-112-65.ams2.redhat.com [10.36.112.65]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76B0B1001F5B; Thu, 27 Sep 2018 11:49:24 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Cc: stable@dpdk.org References: <20180921125244.27861-1-tiwei.bie@intel.com> <20180921125244.27861-3-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: <7199aa80-d7a3-c79b-cfdf-0541a9769151@redhat.com> Date: Thu, 27 Sep 2018 13:49:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180921125244.27861-3-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 27 Sep 2018 11:49:26 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 2/3] net/virtio: add the missing supported features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2018 11:49:27 -0000 On 09/21/2018 02:52 PM, Tiwei Bie wrote: > The virtio features VIRTIO_NET_F_CSUM, VIRTIO_NET_F_HOST_TSO4 > and VIRTIO_NET_F_HOST_TSO6 are supported by the virtio PMD. > But they are missing in the supported feature set. And since > below commit: > > commit 4174a7b59d05 ("net/virtio: improve Tx offload features negotiation") > > Virtio PMD will announce the Tx offloading capabilities based > on the features read from the device. And virtio-user won't > report the features which are not in virtio-PMD's supported > feature set. So since that commit, virtio-user won't announce > the DEV_TX_OFFLOAD_UDP_CKSUM, DEV_TX_OFFLOAD_TCP_CKSUM and > DEV_TX_OFFLOAD_TCP_TSO offloading capabilities even if the > vhost backend supports them. > > This patch adds these missing features, and virtio-user will > report them if the backend supports them. > > Fixes: 142678d42959 ("net/virtio-user: fix wrongly get/set features") > Cc: stable@dpdk.org > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_ethdev.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Maxime Coquelin