From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arybchenko@solarflare.com>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id E3F8B1B0F8
 for <dev@dpdk.org>; Mon,  1 Oct 2018 13:25:31 +0200 (CEST)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id
 EE2F5600074; Mon,  1 Oct 2018 11:25:29 +0000 (UTC)
Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com
 (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 1 Oct 2018
 12:25:23 +0100
To: Thomas Monjalon <thomas@monjalon.net>, <dev@dpdk.org>
CC: <gaetan.rivet@6wind.com>, <ophirmu@mellanox.com>, <qi.z.zhang@intel.com>, 
 <ferruh.yigit@intel.com>, <ktraynor@redhat.com>
References: <20180907222727.20521-1-thomas@monjalon.net>
 <20180928162144.1972-1-thomas@monjalon.net>
 <20180928162144.1972-2-thomas@monjalon.net>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <71b916a0-e3ae-3c3a-023b-77ec283a821d@solarflare.com>
Date: Mon, 1 Oct 2018 14:24:40 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <20180928162144.1972-2-thomas@monjalon.net>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
X-Originating-IP: [91.220.146.112]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
 ukex01.SolarFlarecom.com (10.17.10.4)
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24128.003
X-TM-AS-Result: No-0.695700-8.000000-10
X-TMASE-MatchedRID: 5+1rHnqhWUQOwH4pD14DsPHkpkyUphL9WuFm7TqL4eEifM7JMNHW65gC
 Mlq+sZ+fhPVtOdfRbpmwiqg6QcdK5ykk8Bg8KNsBEhGH3CRdKUXwZGE/+dMc1kFN16jLRH0PAsG
 dHhfcaBfi8zVgXoAltkWL4rBlm20vjaPj0W1qn0SrvtPKKgnMGFBSEbfAdggw5cX8jKvh7R25u9
 rQXLIrHpKVyCqjq135nC1z8g5FPSlVcnoIm/DxavxwvuALplH7oKBiVcDBvMqbz1drKbVHgYVyA
 lz5A0zC7xsmi8libwVi6nHReNJA8sM4VWYqoYnhVga+6uzn7TBWXGvUUmKP2w==
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10-0.695700-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24128.003
X-MDID: 1538393131-d88-rBzC24kh
Subject: Re: [dpdk-dev] [PATCH v3 1/4] devargs: remove deprecated functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Oct 2018 11:25:32 -0000

On 9/28/18 7:21 PM, Thomas Monjalon wrote:
> rte_eal_parse_devargs_str() does not support parsing the bus name
> at the start of devargs. So it has been renamed and deprecated.
>
> rte_eal_devargs_add(), rte_eal_devargs_type_count() and
> rte_eal_devargs_dump() were declared deprecated and had their
> implementation body renamed.
>
> All these functions were deprecated in release 18.05.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>

I would say that it is more fair to say that changes related to
rte_eal_devargs_add(), rte_eal_devargs_type_count() and
rte_eal_devargs_dump() fixes b65ecf19 since the changeset
simply removes these functions. May be the ideal solution
is to add changeset which adds these deprecated functions
and simply calls replacement and remove in the next changeset.
But it is too many efforts for nothing, so good to go as is.

Should it be mentioned in release notes (API removal)?