From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B669DA0524; Thu, 30 Jan 2020 15:21:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 98A251C033; Thu, 30 Jan 2020 15:21:16 +0100 (CET) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 085E21BFFE for ; Thu, 30 Jan 2020 15:21:15 +0100 (CET) Received: by mail-wm1-f67.google.com with SMTP id p9so3961240wmc.2 for ; Thu, 30 Jan 2020 06:21:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=ORY6y5Ir4qLKkIM3ux69J4AugUPp00jIDUD/eAJlNRw=; b=nNQZ5Gye8LTx/Jj0Jr4645m4UcEu/y/Xvem2WdFDQ/DYq9zkbMTYQDIKzKoLbXdNAr CGfcJfaLSAi8LixnHp5hoAl/rDYH0qfdSbus4vCn09KTH6+Z0o4ag2EWDWXuuZ3IwYVz OxuB+WHDNKOdlLb91Gw3CKN2G5kGS4P1WPS7WKRrH8WoQghHBKyL2T0Q3AkirMiHtWPP MAJS5icYn/jv+THVzrKKRdIAKrbv/WkMihRaUzvjSGH8q8WuZvqoPtfzyh5nia0kYYhm 8zB1Yf6fcp7LQ15Y/85iLC3ie7Mf6A9dGFBtTGo0NP+7xjjIzcwrczsH73RdXJ5mfDNn KD5w== X-Gm-Message-State: APjAAAVQRwRfR4XMZCwnwMLI7iXUAg85zFgDBHNRdcufdFMzg1TuivXR Q3jpVuI/Sg7sT93zV12A6S0ygA68dJQ= X-Google-Smtp-Source: APXvYqyIaxDGWmNIVkfYNgqy3U2OCIn6vCXOtzqsXSoQgsxZTUDElb4tpTT8EdQ4EIwTLInnLqwnKw== X-Received: by 2002:a1c:bdc6:: with SMTP id n189mr6122982wmf.102.1580394074683; Thu, 30 Jan 2020 06:21:14 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id y185sm6907156wmg.2.2020.01.30.06.21.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jan 2020 06:21:13 -0800 (PST) Message-ID: <71b93a9bbebf1f047f24d3f455eab1bf2712dcf4.camel@debian.org> From: Luca Boccassi To: Thomas Monjalon , Ferruh Yigit Cc: Neil Horman , Cristian Dumitrescu , Eelco Chaudron , dev@dpdk.org, David Marchand , Bruce Richardson , Ian Stokes , Andrzej Ostruszka Date: Thu, 30 Jan 2020 14:21:12 +0000 In-Reply-To: <1929128.8hb0ThOEGa@xps> References: <20200129122953.2016199-1-ferruh.yigit@intel.com> <1948601.PIDvDuAF1L@xps> <1929128.8hb0ThOEGa@xps> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2020-01-30 at 15:17 +0100, Thomas Monjalon wrote: > 30/01/2020 13:57, Luca Boccassi: > > On Thu, 2020-01-30 at 13:33 +0100, Thomas Monjalon wrote: > > > Hi, > > >=20 > > > I disagree with the need of this patch. > > > The symbol was experimental, meaning we can change it. > > > Removing experimental tag is not an ABI break. > >=20 > > Hi, > >=20 > > This symbol change was requested for backport in 19.11.x, and > > experimental or not I'm not too keen on backward incompatible > > changes > > to the public interface in an _LTS point release_. The compromise > > was > > to see if we could support both symbols version, which makes the > > change > > backward compatible. > >=20 > > If you prefer not to have this patch in mainline I'm also fine in > > taking it just for the LTS. I agree with you that it is not > > required > > for mainline releases (although nicer for me if it's a backport > > rather > > than a new change). >=20 > I would like to avoid opening the door for maintaining the > experimental ABI > in the mainline. Please take it directly in the LTS. >=20 > The next question is to know whether we really want to have such > patch in LTS. > Anyway, 19.11.0 has this symbol as experimental. > How adding a non-experimental version of the function in 19.11.1 will > change > the ABI status of the whole 19.11 branch? The problem is not adding the new symbol, but removing the experimental one. Changing the version of the symbol was requested by OVS for inclusion in 19.11. --=20 Kind regards, Luca Boccassi