From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AA5CA0032; Fri, 22 Apr 2022 10:45:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1614B4067B; Fri, 22 Apr 2022 10:45:08 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id AC1D340042 for ; Fri, 22 Apr 2022 10:45:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650617105; x=1682153105; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=GfzjXlkwy+WEo+s0MUyyHREMqnzspVGEhyF5Zj85X4M=; b=Nw3dElc88ShFp3UVNJKuPfmr2i2jecoby8wYuzyLfR+rHYqwc9comey+ O8WIJL6yf/t25mAWd0bV40xreEUHuHhHleGFhMkCU+QlRv3UZgwA5oQXZ TeDIlqfUr1SR5YMY1xOwSaIoyjKz9mFqmZqplieq2OSs4Q/d8299r7apd 6x42y/YnPPScstJGsCgtrCZ1/8caZyoP99nuwEh04o/QaWDG6I9Iqq2nM XdJlA3LF3bP+OR+DCAUDENnx7J9FJYpZOCFFToQG/bknVDAEF+cidhGsq xKYlG9co/VKS8MxQKgn1eZLpdus3zAomrKUVpy7Yf8xhuRd0YutheilUo A==; X-IronPort-AV: E=McAfee;i="6400,9594,10324"; a="245195364" X-IronPort-AV: E=Sophos;i="5.90,281,1643702400"; d="scan'208";a="245195364" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2022 01:45:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,281,1643702400"; d="scan'208";a="867305881" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga005.fm.intel.com with ESMTP; 22 Apr 2022 01:45:04 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 22 Apr 2022 01:45:04 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 22 Apr 2022 01:45:04 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 22 Apr 2022 01:45:04 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.48) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 22 Apr 2022 01:45:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iHz+R1NsagkjcHVC3aW2wyuTiOIK+a401kpL0A8qt3f4LtNGz5ZoxrVe2klygcNabC/Go7sD1XpAKcDrXmOnjtRnLk9z36HGuRPZRhNxSM6QKHs12FrMJ3oBc+9zptW7QMtdO0gv403RF/LksMQ7Gh77SXsUxzhRYAXyYL9WT574Lb9bcBh8BVbL29rnuKpDfRxv1UXbWnyAukFSuX8fsGzXyxRt575gSyBh+a4liXNi/CzYk5HkgNCRNKaZptkn2cGiJCun+8sHNanJHaeNJjAs2vkK2ObvUIEir9J+kvL9MFqrNuk8oZseUEEoMjG18Be8Z8BdkQLzq7v6xz2lPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZuK5ktM96U9Jpf03L34z0pxV82HftfOk716/e13D2ww=; b=ZaUP8nwnofGKOVaUSIjgxzWhHofTLGrJGurJ6t1A/CEoy4Ttq+1tqqXt8lNMKt7mYc3lg0meheUie/UvwEXrUiHVRpapzwGKSSzT5fdxSg8TTPUijmD42wppTBizgT8DjtL9c9fLv7IYDbal+oGoLidyIK9rgXC8mmTD0rD7gV1V9P/9NFtv4qRSGScAd1NYzpubtWfWvPgjzta18xS6zDRrsidsa0s+4pdsGOvYN3Q1jLo4EvkLz7NJQsKqvPoFuuUykPN116XmMUiLvhXuNG0GvypFhdgeCQpveEgzCxijamYbVnI99hEn0Kz6G/l5sgtShgxFP28V2jPOVH/CiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5660.namprd11.prod.outlook.com (2603:10b6:510:d5::6) by DM6PR11MB4170.namprd11.prod.outlook.com (2603:10b6:5:19a::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 22 Apr 2022 08:45:02 +0000 Received: from PH0PR11MB5660.namprd11.prod.outlook.com ([fe80::29ba:d832:3fa:95d5]) by PH0PR11MB5660.namprd11.prod.outlook.com ([fe80::29ba:d832:3fa:95d5%2]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022 08:45:02 +0000 Message-ID: <71d24438-1555-809b-9ac2-8f5be80f4a3b@intel.com> Date: Fri, 22 Apr 2022 09:44:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v1 18/19] timer: remove unneeded header includes Content-Language: en-US To: Stephen Hemminger CC: Erik Gabriel Carrillo , References: <20220421190859.264174-1-sean.morrissey@intel.com> <20220421190859.264174-19-sean.morrissey@intel.com> <20220421130827.32634853@hermes.local> From: "Morrissey, Sean" In-Reply-To: <20220421130827.32634853@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0085.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::18) To PH0PR11MB5660.namprd11.prod.outlook.com (2603:10b6:510:d5::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d835c6f0-4f04-49ba-7180-08da243c6405 X-MS-TrafficTypeDiagnostic: DM6PR11MB4170:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jbRASb0umD8hIlbFunbr0D8mjVaJO68Lf3++U1uG5O6Ozxqnfn/ybX9c2znu9nsHdrI+brLy+M8EzJBLKaN8dFAMAOKuz6BNLsCWMo4ZVoc11sh0EqyCOfSLODnXU6NdGFwLs7k/rSut/swAzJH3RqQ5GLJ376kR/Voz7wrNepHF4jbqxYkM36eHIAN/QAg1s0Z1j67nrAPNcPd8K6W7v8F9MALWRs1fO0C2sqyz2sVErp8SzektejhVHyPTiVNbtRj82mrJr3o5sHzL1yp3s+T9eTTXDp9XfZGG65cH1Rh0CYU/zlxyaCk8YF6tRoHptJ4OA8iyzWcikJIMyN2BJQQh55MYSboHfJJibeyXIzvT8qy1wrm6baUQtr5hEMDdaAduBVk1V198o5tGcdPXQmCjueNnCZRfh4MKgkOnCBOA/Z8gVsFe9COSyuyraObqis5b2d5tWrlNZPcDTAkLQSfA4xogLeDOZUvvn57tEOhWF9t/sRQdt6usQUxKXYRAGpDW3NizS+jFkgEryeuZ3nFXkl7vIwZFeofWVkUMT6hK4tnbaQp63pgWHzi4roeaRKvmzNXpgrBXjqhuZ1yB+1yOY2Aoy0Fvu4/k+Yxk/mEhiaZLBvW4C2q5n8wJeaKtMaDXa4aAzPsuSCLzY4zeYYhaTf3YRYSPayPoUahsS8O8F8w+iD+hCJzaPxdKVOzm3ynVAIHpFcQ3pFfbzYL1KmWl/8Y0GNSRoNauIoCe4RI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5660.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(316002)(6916009)(53546011)(6512007)(6506007)(36756003)(6666004)(26005)(2616005)(31686004)(38100700002)(31696002)(82960400001)(86362001)(2906002)(508600001)(66946007)(66476007)(66556008)(4326008)(6486002)(8676002)(186003)(5660300002)(8936002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0NwVFd1Mk1CVnJmMDRoOGZ1U0hqcEc3alFGMGZhUW1yZnQ0QktDYURmM0d3?= =?utf-8?B?dk5CbjdOdnFuRUZ6NE43dnJQVFgxbmRPNDhDbTVmcDR1eUFQUkJHL0ZWTFZR?= =?utf-8?B?RkZLZ3IraUlSd3hLdE9Zamh0OVYwTmRUdzZNVWgxV216M3VIWEtQcGJHdFVW?= =?utf-8?B?N2Y4QnVkMmRONlhzdk4zUVB1VXVHOVBFTW5TVDYrUStqV0JDMzdISmZEYWtU?= =?utf-8?B?QThxM2RURUw3R1p0N2VCaWE1MVRuVmVBL2pNK3JBWEk5b1dDNjYyaFR4Vkl4?= =?utf-8?B?aFZLS1dCUEtBd1RIeFhBeFdzVC95VXBLcng4YnkxbmpLS3lRSFpyTVg4VTZR?= =?utf-8?B?anZxV25hVmF2TFloOVZlZmYzVnNvT2NQc0FFb01yM0NZbmVlTktnUFpMUmdF?= =?utf-8?B?eEM4QytvSkJPRVM1L0pwcGs1dSs0OTFpd016ZFpwc0ptcU5STUgxSkdlMHhS?= =?utf-8?B?MVk2QlB1WU51VndvQmlNUmJrQmxHcmZVRTBrSWZtdjBnUUpGc2srTUJqY2tJ?= =?utf-8?B?MEtONmFOZGVHL2J6MURXd1o1OVptK0xuNm9qOFBDQTVQdFE2UHhWcHdtMTJM?= =?utf-8?B?YUwvQWN5NjhNQ3Bibi85TmFWR3J4cUpsWGZYOGRsOVZZYXcvQXdrZk9IWU5Q?= =?utf-8?B?UFBVTHo5Q3B3clVlNjRzWW5wb2VIMHVQd0Y1OU5sZUtMQjdrdWxETFhWNFQx?= =?utf-8?B?MlZScElWQXVFTzJRZXJoWWhUNUpLQXZ5bzlJamUwQUJYODVHMzNQYVFyYWtT?= =?utf-8?B?R2hKMGtqN0pxMWIzZ2NEcDlLQ1U3VEF5a1RvVVFYc2loM3Y1N1lxSzRvNzhq?= =?utf-8?B?MUFmQmV3bXFjSlpydUpWaU9DeVlrSmFPTEYzZXY3ZUZYaFd0QkdRbEtGSEFM?= =?utf-8?B?WFpKR1krandwS2hnTFAwcTFqaUdYTUNGb09qMk9CcEpOZnFqZlVUSDI5ai9O?= =?utf-8?B?ZXBKSlMybURQM2JOREFPUnVSM3NKSnMzT2NSU3dvYkhzNGw1YnhnMUpaek5X?= =?utf-8?B?OExETGNhZU5kY3hIKzFmQ1NxTlRvMzk3WjlyNXZTRUZUWGRrTFRRYzBOV213?= =?utf-8?B?ZjlIWDcvVzR2aEM5bDgxdC9NRW9Yc0lXZ3phc3htVndpeXdKcGxvRmdqTU1C?= =?utf-8?B?c0d3MFQ2NFl5bWd2dlgvaEpqNTl0Y09PaXBMYnBsYjFVZzlSdG5SOWdtNExk?= =?utf-8?B?Mm5SMVRaN3YveHowR0hXcytGUHI4L016dTNhQll3NjIvYllsNXdvOXd4VWpk?= =?utf-8?B?bUlxZlRYTHFWQVAzSzNDUVltMEFMWUF1eWwrZVI4NVdJSC9qNmljeGFvczQ5?= =?utf-8?B?d1dVV0dZM0E3VjllTG5wWlBkQU5yYXFza29OTUZJSFJzTWJWVDFDcWRGZXFa?= =?utf-8?B?TjBKd2tSYnNSMXNWR09ibTFSUU82alBmVUQ0SFZCSUNlZVFiZ3NsN2txb1JX?= =?utf-8?B?YnRXWHZyQkxhSUt1ZVJQVDJCV2pJMGtxWnZmNmJjSHNqS2lOQjRWNlJsQ0tP?= =?utf-8?B?bWNrL05PZkgxZWtZWHNDY0o5dmpXRnVNREVrU1J6VGlwN0t5blIvUHMxbC9r?= =?utf-8?B?R3dCK2czMFd3M0pJZU9RZ0phTzVBSDR1bDRPQk5kbzZPYUZKZ3hEcTlwUzZs?= =?utf-8?B?a2VlOHZtcDk2c2loSFZibytkbDJoMTA1TE5WRGNrSUpzWnB0ZHV0Z3JEV3JC?= =?utf-8?B?N1BEaGVFNFJCRjJjWUlXK3d5REVHUjBISFQya3RndHJNU2ZrdXdMd0xUaFM4?= =?utf-8?B?NmI1Zmlaay9zQk52eUpjampGcVR2SzQ3TkNFWVkvWjRaOVU3TDZaTDVycUJE?= =?utf-8?B?RzlnMGliK0F3cFpjb3ZPY1BoZjduTUJtSWtScTFSa2dET1hndG0yTDd0aUZr?= =?utf-8?B?MGkreWdtcEZCZDRvdm5yWDA1c3JwZjd0VVFNUjhreUYyMzBEMVh2VjRwWWE4?= =?utf-8?B?bUt4OWYyUGpXb1paa1ZId3dQVThpazNBNkN5TWZiVXVPVUZzTDdlM2FpMWZL?= =?utf-8?B?RVNMMHIra1A3YUNXUzkrbWNZRjlkZUczTzR0NVJ4djFqSWxGOE9lL1M1VHpJ?= =?utf-8?B?N1daZ2Z3NXE0aEtEck82RTYzN1phYWxkQjVvWDBPa1B2allWNHVGc2lNdXdT?= =?utf-8?B?akFRczBLb0QwdWZnajlwaFpQK0R3TjFZU24wN3dvRHE3cUI0RjRRN2RlWjYy?= =?utf-8?B?MUh6c2ZYdmk4MlNUSkw3U2pMYnY5UHRHSTlxTEVKZmtHZGZ3UDZKb0pIenAy?= =?utf-8?B?QmppTlBKYkI5M013Z25Ea1ByTXRhMUxxcEJsbGdMeWVrWVViYzFmb0ZDZHI0?= =?utf-8?B?ZWVISXhXKzJmemgreEVma0c2Rkhha1hXV2NOVldzTTV5WldodzBORU0zVHFw?= =?utf-8?Q?YZw5S1D0P3WJiEzI=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d835c6f0-4f04-49ba-7180-08da243c6405 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5660.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 08:45:02.4135 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /X0V5HKIZlcYyVrzT+4QbRbgXcPT/k1a8/MbZqitmUVDeMgh5We8eKY/wfQvEJQo4i8yRPVekgHYm6xMIXOoNZEnwxWsKJ16b9cUa1mUYmg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4170 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 21/04/2022 21:08, Stephen Hemminger wrote: > On Thu, 21 Apr 2022 19:08:58 +0000 > Sean Morrissey wrote: > >> diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c >> index c51a393e5c..f52ccc33ed 100644 >> --- a/lib/timer/rte_timer.c >> +++ b/lib/timer/rte_timer.c >> @@ -5,12 +5,9 @@ >> #include >> #include >> #include >> -#include >> #include >> -#include >> >> #include >> -#include >> #include >> #include >> #include > This doesn't look right. > > rte_timer.c relies on rte_get_timer_cycles() which is defined in > rte_cycles.h > > Perhaps iwyu is getting confused, or thinking that is already covered > by another include file? IWYU can throw false positives. Please let me fix all build issues with this patchset and get back to you. It could re-introduce the header in question. If not I will investigate where IWYU believes the include is coming from. Typically the headers removed by this tool are usually already included from a daisy chain of includes from another header.