From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BE71F231E for ; Fri, 7 Dec 2018 12:45:24 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Dec 2018 03:45:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,326,1539673200"; d="scan'208";a="116457100" Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.178.128]) ([163.33.178.128]) by orsmga002.jf.intel.com with ESMTP; 07 Dec 2018 03:45:22 -0800 To: Harman Kalra References: <20181206150106.154090-1-hkalra@marvell.com> Cc: "dev@dpdk.org" , "jerin.jacobkollanukkaran@cavium.com" From: Remy Horton Organization: Intel Shannon Limited Message-ID: <71d5a035-1d3b-bd42-59af-70e7932d127d@intel.com> Date: Fri, 7 Dec 2018 11:45:21 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20181206150106.154090-1-hkalra@marvell.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] test/metrics: Fixed a negative case to pass X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Dec 2018 11:45:25 -0000 Git apply choked on the patch but it applied using patch -p0 - I'm guessing this is a problem with patches made using diff rather than git format-patch. The change itself is fine though. :) On 06/12/2018 15:01, Harman Kalra wrote: > Negative test case for passing invalid count size to > rte_metrics_update_values() will pass if count value > is any value greater than 1 because set size wrt to > key id 1 is 1 and passing 0 as no of values to be > updated will not hit the ERANGE check. > > Signed-off-by: Harman Kalra Missing fixline: Fixes: cd3804242901 ("test/metrics: add unit tests for metrics library") Acked-by: Remy Horton