From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 855B3A0096 for ; Fri, 7 Jun 2019 14:25:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D5C31BB78; Fri, 7 Jun 2019 14:25:09 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 571861BB6F for ; Fri, 7 Jun 2019 14:25:08 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A51F33084213; Fri, 7 Jun 2019 12:25:07 +0000 (UTC) Received: from [10.36.117.226] (ovpn-117-226.ams2.redhat.com [10.36.117.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 716157D557; Fri, 7 Jun 2019 12:25:05 +0000 (UTC) To: Haiyue Wang , dev@dpdk.org, qi.z.zhang@intel.com, wenzhuo.lu@intel.com, liang-min.wang@intel.com, daniels@research.att.com References: <1559877042-95011-1-git-send-email-haiyue.wang@intel.com> <1559877042-95011-4-git-send-email-haiyue.wang@intel.com> From: Kevin Traynor Message-ID: <71d71b18-d6cd-8555-4b4a-3837cdaceaa0@redhat.com> Date: Fri, 7 Jun 2019 13:25:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1559877042-95011-4-git-send-email-haiyue.wang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 07 Jun 2019 12:25:07 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add the description for option pflink_fullchk in ixgbevf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 07/06/2019 04:10, Haiyue Wang wrote: > Add the detail description for this pflink_fullchk option, when it will > be used, and it is used for fixing what kind of issue. > You can squash the docs into the 1/2 patch. > Signed-off-by: Haiyue Wang > --- > doc/guides/nics/ixgbe.rst | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst > index 975143f..33812a5 100644 > --- a/doc/guides/nics/ixgbe.rst > +++ b/doc/guides/nics/ixgbe.rst > @@ -82,6 +82,24 @@ To guarantee the constraint, capabilities in dev_conf.rxmode.offloads will be ch > > fdir_conf->mode will also be checked. > > +VF Runtime Options > +^^^^^^^^^^^^^^^^^^ > + > +The following ``devargs`` options can be enabled at runtime. They must > +be passed as part of EAL arguments. For example, > + > +.. code-block:: console > + > + testpmd -w af:10.0,pflink_fullchk=1 -- -i > + > +- ``pflink_fullchk`` (default **0**) > + > + Toggle behavior to get ixgbevf link status quickly by checking the > + mailbox status or not. If set, the VF will check the PF's link status > + and the PF's mailbox running status, which will trigger PF's mailbox > + interrupt generation. Otherwise, just check PF's link status, then no > + mailbox interrupt in PF. > + wait_to_complete is also considered, so doesn't it mean that pflink_fullck is not a toggle in all cases e.g. rte_eth_link_get() will set wait_to_complete=1 and then pflink_fullchk is ignored. At least you should mention if there is some user visible API like this where the flag will not result in the behaviour being toggled. > RX Burst Size > ^^^^^^^^^^^^^ > >