From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56399A10DA for ; Wed, 31 Jul 2019 15:04:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F164E1C1A4; Wed, 31 Jul 2019 15:04:17 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 850841BFE0 for ; Wed, 31 Jul 2019 15:04:14 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 524A014005C; Wed, 31 Jul 2019 13:04:11 +0000 (UTC) Received: from [192.168.1.11] (85.187.13.152) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 31 Jul 2019 14:04:05 +0100 To: Adrien Mazarguil CC: simei , , , References: <1564030646-73951-1-git-send-email-simei.su@intel.com> <1564030646-73951-2-git-send-email-simei.su@intel.com> <291f410f-fc71-191b-8595-4c3d9e970041@solarflare.com> <20190731123040.GG4512@6wind.com> From: Andrew Rybchenko Message-ID: <71fb1ab8-8c5f-ad5d-66a2-33460c9fe891@solarflare.com> Date: Wed, 31 Jul 2019 16:03:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190731123040.GG4512@6wind.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [85.187.13.152] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24812.003 X-TM-AS-Result: No-8.967200-8.000000-10 X-TMASE-MatchedRID: QW5G6BKkLTrmLzc6AOD8DfHkpkyUphL9amDMhjMSdnlG7aLtT3oj+0h4 FFTKCL9h2K1EWxOa8ez0QhBpKIVArDUZn1MYzuPInMQdNQ64xffdXhRKGhNdp8uSXx71bvSLW4T fqkHr7Rsl5kTfl5VWPr1H63AToIZZa+cB6FVlK54k/b03uBR3UFdEEmf6TRVBgfusd6WYS7fBGB 5yWcRYfapN2u9xqSbHgsVUXvYdSxL7zwy3HB5+4rE811R1QfVauSNyZKeaiD5YjtHrjqa8D0LgF maW9jiQmw8YAVpiq86Rk6XtYogiau9c69BWUTGwC24oEZ6SpSkj80Za3RRg8CF0Lc/NmaYNBOKY nLLmAd9Ib3BXb3eV5PjGWAypJ0SNGSCvLi0tcps= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--8.967200-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24812.003 X-MDID: 1564578252-hu3bxOYJWN1C Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add symmetric toeplitz hash support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/31/19 3:30 PM, Adrien Mazarguil wrote: > On Wed, Jul 31, 2019 at 03:08:19PM +0300, Andrew Rybchenko wrote: >> On 7/25/19 7:57 AM, simei wrote: >>> From: Simei Su >>> >>> Currently, there are DEFAULT,TOEPLITZ and SIMPLE_XOR hash funtion. >>> To support symmetric hash by rte_flow RSS action, this patch adds >>> new hash function "Symmetric Toeplitz" which is supported by some hardware. >> Isn't it a question of key to achieve symmetry? >> I.e. hash algorithm (function) is still the same - Toeplitz, but >> hash key makes the result symmetric (i.e. equal for flows in both >> directions - swap transport ports and IPv4/6 addresses). > This is only an option when src/dst are known in advance. > > When doing RSS, HW implementations (such as Mellanox's) implement a modified > Toeplitz XOR'ing src with dst resulting in the same hash both ways > regardless of the key. OK, I see. But generic symmetric Toeplitz is introduced by the patch. What is criteria for other vendor to say that it is supported? What should application expect? The algorithm should be defined. Also interesting question is how does it co-exists with the other patch in the mailing list which introduces way to use source or destination IP/port only.