From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FF1B42D13; Wed, 21 Jun 2023 13:01:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D9D94068E; Wed, 21 Jun 2023 13:01:39 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 9B5A44003C for ; Wed, 21 Jun 2023 13:01:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687345296; x=1718881296; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=/gRI9hekNPBzpMLkrtznJw1WJIxjkhoQDyXllODP48o=; b=KW9tyvrWSpi3ofQh9ziBK3qlNPuG3Hr5vyX1aGQ9LJ5rrEsyoeTVUl/E NiruzZQICjEMOGx+6aabisiy0F6EFWd2P7CIDrkLcIgAtbDdsvG97PfoK bDq99FDal6p70b7Gq9/dJayzNZtTmVDSyj1gLq6WSIhEKrUFtb451/hsP 0HlS4AW7uTWTZ6Dj75cTPEm3MklPTUF25BSQyeKt77UPzg0S3WMPj/avE Yxi7UcOHb3Q5IvO2uWGgtNioeqJ1a1E5Xq23itaCHL8hjPCkNDW4WL/0Q 2XB9AbnPQ063Q43rWcatmYkHXfvQbI+ARHlx/TU4Ekhk+XetalkYY88QH w==; X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="362677983" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="362677983" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 04:01:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="717595808" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="717595808" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 21 Jun 2023 04:01:33 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 21 Jun 2023 04:01:32 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 21 Jun 2023 04:01:32 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 21 Jun 2023 04:01:32 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 21 Jun 2023 04:00:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dx9/rgPO3g+4p4w/+Ksf/I54XDackGHx5LF+xqtHXg2sJgxijCdyAIpGmKwo/Flj3Dj1OtxhpvkXGMOrAMVXqgkW8wpSBE3AxajFbGQd/nnqRaVtQUMFtpTywe62o4JmVg13rrkzuIwt9WkgeX4XvdrpYNSXAosFnoFn0KOEMvfRY1SyeV62R8H9IfTeM50IA9TltAUAe+OYY0TexjN42GexgrWQFrushXsOSjtW/sJJvxvAFgH1Y19pUfqRVfEwfYQIU5k5eMZKGdGY8dB3q9v0OiWi0Nvs2teUg9LSdItWa26PYsz1b3z6LsS8S7VHBC/3nfC3g17LCxpCmNM5vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ED7CLPk6luFabNS9d5akYPn2F1VY13F7u51w1VHeYUw=; b=G5uGA9OVUdfNDPhTuZ2qV/UAB8IW+RUbDDCwmnmh1gyOAXSta89pUTdm2Ehdmp3bKcLkLZjXv+rVqcEc2MlUnfXjDZ31+GbspK1uNmVb4Z2PGIPki2sXBfb2Rqe3vR9uMzF6ly+sRZvTd5OPW8WBjh5f7Q4d8KCXM3L8a0O6uDCbVfTRcMuSz3Q1VRVDOE9v/QWL+WS7/OuGYafANpJP6DPRf8AO4pgf6FonvX6plTUdBRit5jms8raFCqoI1dzE+xTU08aJ9PZutkUB7BoHav2Dpu0rSLJi4q68DhWhLuB432tRaFdtdCWhP6U2KzEzh5w23h3/ThCtNcX6IwKlcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by DM6PR11MB4561.namprd11.prod.outlook.com (2603:10b6:5:2ae::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.21; Wed, 21 Jun 2023 11:00:43 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718%7]) with mapi id 15.20.6521.023; Wed, 21 Jun 2023 11:00:43 +0000 Message-ID: <7202354d-1e72-60fb-7c52-47960db71e9e@intel.com> Date: Wed, 21 Jun 2023 12:00:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.12.0 Subject: Re: [PATCH v14 2/6] test/memarea: support memarea test Content-Language: en-US To: Chengwen Feng , , CC: , , , , , References: <20220721044648.6817-1-fengchengwen@huawei.com> <20230209063610.35501-1-fengchengwen@huawei.com> <20230209063610.35501-3-fengchengwen@huawei.com> From: "Burakov, Anatoly" In-Reply-To: <20230209063610.35501-3-fengchengwen@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB9PR01CA0002.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::7) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|DM6PR11MB4561:EE_ X-MS-Office365-Filtering-Correlation-Id: cb2ce44b-76fa-47a0-6f74-08db7246c1df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xH7vt9ti0pmZIBZM6P/hLJzKtL7003yNTN+vWn0zL/NJI4aQtxghWoRE1KhC8CzDjFiipkpmBGcFvAHMpKKNth+ExmdaT7AjK4zo3C4JvzsGOlFNWtJLQcndnbox44t3WYrfXpF8TfKEKIraFbv9IBDcc683yvaoEsgVpAcPq3XFk1YM9SGsLPe366vfG35yqMerW+b6KGTgTVKIEGWUs6wqwC7/Db+6kKwxsYvuw+0FHzGC15TZhXAQphd8OIm+DJ9DzYr5FWf8l6ZAIeitJwsf6Bj5gB0G47WEcH4ROPxDGL2CamCk9fdpLYbyF2YY13Kpl9N5oKKassjW+Da/wwH6zBi5yByTI3kSSb5Ywmr0xpV3kCUUC5cRM1gZRmKpA3Bjsmc//l0M/x7LQoHSmsd0tDw/aurNWYgoOCMHkdIESmdqi8lfe6syTLU+LhPP231c8VpglE0lNaGADUW2TjuoZmvNr4ipGIUyai42Zne1qrRcdREsLGcitrwuJjNB50UyXZDl8GArVBL4m+tM3BIiKfP8WtVB+wfgCcbqRPr4k0W1l05ofmJAsg0rHWecZiRopf0Zo2m7vXX/vhu0EkiipOcnpwlQXU96/HLdC0BvsjC/ZTzUS25NYZKSDhuWRav/2E/pBah9tZVzBZ2kmQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(376002)(366004)(346002)(39860400002)(451199021)(31686004)(36756003)(66476007)(5660300002)(41300700001)(8936002)(38100700002)(86362001)(66556008)(8676002)(4326008)(316002)(31696002)(82960400001)(66946007)(6486002)(26005)(53546011)(2616005)(6512007)(4744005)(6506007)(186003)(2906002)(478600001)(6666004)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjlYKzVDcUFhVVdpcHZuT1hWQ0lsSG5URXo2ZXhpRTRuNjBjRzI0TTFHVmc1?= =?utf-8?B?a1JXS2llYVFyUXMzT0FQL1U3cW4vZTZFQ2U1bEdack1iOSt0am5kWUhvUEpz?= =?utf-8?B?THRXa0M0SlQyclhFVlJ0Wlh1YmhKNG5TcUViREp6U0svV0FvQ1FXb0FjdjJx?= =?utf-8?B?NW85MlNWZ0ZpUjJjYzliV0hKMnZOUWtYMGptODJDVHl2aDBaajh0eE5LbXFr?= =?utf-8?B?VTIwYjZXcTRkYm52THkrNlhDL2JGL2dJbjRHSGFhWm9SVmk5MEl6V0s3dHRr?= =?utf-8?B?bXdLa2loSWtkRzY1UC95VUZlVXpKbTV6MU9kbzdpQ1NDdFdpTW1Gd1Z6ZDlE?= =?utf-8?B?cWQ5d1g2czJqa1VUZDFFQ2RCU2dwMEt5YkZNRTlvSCtLM0dxSnVJcTFqblo2?= =?utf-8?B?QXRjajBYcVg4WWJwL25FbjJsUEJuL0dMaktidjB6YkE5dGpzVnlsRTNRRzNx?= =?utf-8?B?VHlGZ2VIakZVV2cxQ1hPeFZFZC91ZjJkeVUzRjJJTUtRQ2JjZFE4K2tWclIv?= =?utf-8?B?N1FmbjltSmJHdFBQbEhhZ2xMQThTZU1Da2ZFTXN5UEF6Qlc5VDQyOTIrR2tQ?= =?utf-8?B?N2dJc1Bvc2F6TVlkcDFKK284OTh0dDB5SEVsZjZBZk93NnR5UjN1VWtyNkJI?= =?utf-8?B?d2haNDJlUFMyOVNBY0lsNk02SDJBWWt4bU4rSkk3WUpMNjl5ZnhBK04yQ0N6?= =?utf-8?B?SVI4K3ljZWRVZ3VSb3IwYW45ek0vdnl4aVRjZ2d1ZG9YaTdHbGdHcGFTTVVs?= =?utf-8?B?OFJ3bmpwWVlyMHc4aXVkdy9WYkdUQVYyNVhRb3JLU1FWSmQrQ05IcitpSEFr?= =?utf-8?B?TG5EcWJCbloyejVrbjRTSFgyRCtMMzgvS0hPdkE2RE5BQldmYmxhMUV6Skxh?= =?utf-8?B?RnVFWFI1bjNBeCt5UGVsR3ptem9jUHdKOFBkb3NxR3lCcTdoM2dEWHY5cnVm?= =?utf-8?B?Tk16NFRZSWtWdktLMTdIRVFaTERYcWw3T2JacWNQSEVBYmYzbHNXSklVb2Zr?= =?utf-8?B?K0lhVENWTmlyYXlzMEdxVEJyc2M1eXNoWXhhMENBais3K2RURFh3ZmlMOGNk?= =?utf-8?B?UDhkTURYbktZNUlEbHhoNzR1a2ZoZmNjcTBXZDJoOGN6aW5STno5SUN6TjBN?= =?utf-8?B?azgrbWYzM05WNHhENTljVWppQ3VUeG1reUdQMUZVZkc0WHdoRXFVVHpJeFg5?= =?utf-8?B?eXFxRDVxcnVpVjE0WHd2cjB3OEUvQlg2VWwrUUlxb1NwZ2N1Qy82eG41TmRw?= =?utf-8?B?blJ2TDQ4TzFPOUNoaElNZmw2dFZEV0t3NUpUVnRFbmVjYnZ1aGZ0aFlSMXpn?= =?utf-8?B?UWdsMXJ1TUxibTk1MUdUdnk0bjJoYmt4OVVya2U0RXgxUWloV0svMDd2RmlO?= =?utf-8?B?MDhpais3UkRzdDBNUCtvcHZtSktGSk1RQ3BvQ200LzZETVZxc3Jqby91c1dL?= =?utf-8?B?R0l5bFlCYnlVZ2crS3NsYTRQUWo3ajZVQVhTa2dFcWhscGFKUjlTZ3JVTDUy?= =?utf-8?B?OXd5ZEZobkRoL0ZIdFhjL0I4VlNBQzdURTUwNWJiVGVLZWQ3S0ZIT2NEYWVp?= =?utf-8?B?aUdtL2pMSVQ4NkRqeWhuU093NmNYRktJbmttSGthWmVRWk8rQ3VIaHlaVy85?= =?utf-8?B?eDB4SXhoakovZ1ZBRjV3NTg5ZWVGVEpYTnp0alJ6UFlOdGQxTFRsOTdHQytC?= =?utf-8?B?RVhlS2xxSEhzSU1hdkdvSHlGRzJoU05pTmQ2SFJHSjFCMHhJME5QaWdsSkla?= =?utf-8?B?bU45dXlnQ0tZV2FDQzA0VmJIUEYxQnBITzFFejJvRldMSXRyZzN2OCthc2RQ?= =?utf-8?B?aExmMEw5aGZLbUFTRUpEbjdxQ0Q1SHFMdVkzUktDNFhaYTlGWW9maCt3MG9B?= =?utf-8?B?N0VvZ2ZlVG5DWmIvY3A1SFYramlQbyt4dDhKeUJ3T3ArejRmWFE5bWVBeXZt?= =?utf-8?B?OUswTEpQQTVudDVNaVlRZW9SSno5STVEM044NUcwOXdVS1ZyMFFKMDJWa2tG?= =?utf-8?B?Y1JoS1BwbDR0VERJWWN0Z0FIbnk0c1N0ZDhMTzN5Vmp5UFIyNUxJUDFXRjBR?= =?utf-8?B?MnYrMm11ZXM3eDE5TUJVZktxSFlISmM3UG4wRkZ6azY2KzBRQVMxVmJzclRQ?= =?utf-8?B?UEdiOE1SOEoyL3hxTXU4Z1FVbmtmY0lISTZjYlhEUXJuYkpYV29CSGlZbW5X?= =?utf-8?B?cWc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: cb2ce44b-76fa-47a0-6f74-08db7246c1df X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 11:00:43.1096 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oS46bFwgYfH128bblPMFOtUhl5VQPTYg/rlt7eN1PhzwyXnIxVn48P6nxoeNrALCsRNapIpRUR1O+IsY+kZ0A56oNwjION/86IYdd7D2VCY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4561 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/9/2023 6:36 AM, Chengwen Feng wrote: > This patch supports memarea test of rte_memarea_create() and > rte_memarea_destroy() API. > > Signed-off-by: Chengwen Feng > Reviewed-by: Dongdong Liu > Acked-by: Morten Brørup > --- Hi, > + > +static int > +test_memarea(void) > +{ > + test_memarea_prepare(); > + > + MEMAREA_TEST_API_RUN(test_memarea_create_bad_param); > + MEMAREA_TEST_API_RUN(test_memarea_create_destroy); It looks a lot like you're reimplementing functionality that is already present in the test app, as we already have infrastructure to support test setup, teardown, and running different test suites (see e.g. fbarray or EAL flags tests for example). Is there any particular reason why you didn't go for this approach? -- Thanks, Anatoly