From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF6F2A054F; Tue, 16 Mar 2021 12:09:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A479E2427AC; Tue, 16 Mar 2021 12:09:53 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 378454069F for ; Tue, 16 Mar 2021 12:09:52 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id AF8FF5C00A6; Tue, 16 Mar 2021 07:09:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 16 Mar 2021 07:09:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= w8YkIHxlTucdhBkFI91WS81mG8nFe2OQGnJjI/oKZhU=; b=B9NRXAru/O5tQlSC RvVlck/ITKdXa0XDx3rTWx9Hy9A9Jnqt8WBmUHf9BtTLFGEzMyQv/SxmMMpKMRDR FwLphIMi8Vq65Cn7z2vz9OIlzFODhsrY8k9RiIjUuGJMLX4sgI2WVM0gDcyubU4B 8LYnViw+dJl0PissCs2mpq4BdX8vV1vKWm7XlanMy0MvQVqYWJ4sp4OaGNF0t91n TAOffeSqCFHzmHpn15MPXpBut5vfNkD97jFAgguzTHDv8IIo9b2OyzaoS1Z/9NEQ dIMhjx8nLUeZcRbCKMIllWCThBINwn0Nzf/zXQ9HQ4624Jcf5psNhQpxKiqO8V38 GPZG9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=w8YkIHxlTucdhBkFI91WS81mG8nFe2OQGnJjI/oKZ hU=; b=f6w2INj1s5SYTcOvIf5+dvHLZVE1QrIAXn2FjiC/EaRStSH/Ym154hk02 kaaNtaPKAFRVYnS56IGYS+WgcmqF1uDs5sLc1Rmf5wVOFOfbOIbrEjJ4TNJNHfNe JWtSV0ZHOWfYR3yviFIR/JetxEQacJ8bqJLHkmCENS21V6f6Q5RRo5pVFC/UEQEq 43bx34QmkOZdbgSgqj8H7yla1X1JjrzdF8aohRkmNHs7lkvcANSifpjBXza8Zk4j 7nm/RzVez8/j1kGQQicnGiy3VsACqP3Qpj/SEMjgwKVuh2TXj4ZCbxmwWH4OoxMh ASw4wgZffzM47JC9xi4vgEWcuypYA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefvddgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjedvhefhheeggffhgeeiffetheegudekffegudetledufeejvdeu vdehtddugfdtnecuffhomhgrihhnpehouhhtlhhoohhkrdgtohhmpdhmvghsohhnsghuih hlugdrtghomhenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlh honhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 52B87108005C; Tue, 16 Mar 2021 07:09:50 -0400 (EDT) From: Thomas Monjalon To: Jie Zhou Cc: "dev@dpdk.org" , Dmitry Kozlyuk , "roretzla@linux.microsoft.com" , Jie Zhou , Narcisa Vasile , dmitrym@microsoft.com, pallavi.kadam@intel.com, bruce.richardson@intel.com Date: Tue, 16 Mar 2021 12:09:48 +0100 Message-ID: <7214899.8EVLAoSQA2@thomas> In-Reply-To: References: <1614209812-4331-1-git-send-email-jizh@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXTERNAL] [PATCH] WindowsGSGDoc: Update the meson version to use for Windows DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/03/2021 19:32, Jie Zhou: > Add Dmitry. There are more maintainers to Cc. I recommend using Linux for sending the patches, so you can use the script devtools/get-maintainer.sh with the option --cc-cmd. > From: Jie Zhou > > Meson with Windows clang generates incorrect linker flag "--subsystem,console" instead of "/subsystem:console" which will fail the DPDK build. This is discovered at porting testpmd. > > Meson 0.57.0 has the fix and should be used for DPDK Windows build. > Update the DPDK WindowsGSG DPDK Build document for the proper meson version. Will then sync with ci@dpdk.org to update meson in CI pipeline. > > Signed-off-by: Jie Zhou Why signing with a different email address than the "From"? [...] > https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmesonbuild.com%2FGetting-meson.html%23installing-meson-and-ninja-with-the-msi-installer%2522&data=04%7C01%7Cjizh%40microsoft.com%7C124559f34a4245cef68808d8d91d1508%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637498066227214579%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=oXVIHUzLnN0KkaRED1skiCq3W1LQRJS8H0NAHCCvu6A%3D&reserved=0 That's interesting how your mail server can break a patch :) > -Recommended version is either Meson 0.47.1 (baseline) or the latest release. > +Recommended version is either Meson 0.57.0 (baseline) or the latest release. I am OK with the change. What others think?