From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5027AA0C45; Fri, 26 Mar 2021 18:41:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C882B140DD7; Fri, 26 Mar 2021 18:41:49 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 4AF8440685 for ; Fri, 26 Mar 2021 18:41:47 +0100 (CET) IronPort-SDR: 8C0GZNQA++v1WuoQiQTRZyoEKlS4/Ov449n9yV7B0TPTU8+vNZMQKf6DwNf1QA3p45aBSxJyHj QKGJM8wuOoAg== X-IronPort-AV: E=McAfee;i="6000,8403,9935"; a="190635449" X-IronPort-AV: E=Sophos;i="5.81,281,1610438400"; d="scan'208";a="190635449" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 10:41:33 -0700 IronPort-SDR: v1vDLGSGe5s16eLzXSKtWC5UfTuE9XnKeZI88v/eOG9UYZqPVeON/YiungAbnwFQzmR/LKa+fe 8rlI2Bby96Og== X-IronPort-AV: E=Sophos;i="5.81,281,1610438400"; d="scan'208";a="375557149" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.231.99]) ([10.213.231.99]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 10:41:24 -0700 From: Ferruh Yigit To: Thomas Monjalon , dev@dpdk.org Cc: Ajit Khaparde , Haiyue Wang , Rosen Xu , Hemant Agrawal , Ori Kam , Somnath Kotur , Chas Williams , "Min Hu (Connor)" , Rahul Lakkireddy , Sachin Saxena , Jeff Guo , John Daley , Hyong Youb Kim , Gaetan Rivet , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Yisen Zhuang , Lijun Ou , Beilei Xing , Jingjing Wu , Qiming Yang , Qi Zhang , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Liron Himi , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Rasesh Mody , Shahed Shaikh , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Jiawen Wu , Jian Wang References: <20210311221742.3750589-1-thomas@monjalon.net> <20210321090002.595744-1-thomas@monjalon.net> <20210321090002.595744-2-thomas@monjalon.net> <32280a57-4359-b159-fb98-f9bbb7440e0d@intel.com> X-User: ferruhy Message-ID: <721cc807-be51-6aca-07cb-213c732d5d69@intel.com> Date: Fri, 26 Mar 2021 17:41:20 +0000 MIME-Version: 1.0 In-Reply-To: <32280a57-4359-b159-fb98-f9bbb7440e0d@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: replace callback getting filter operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/24/2021 6:05 PM, Ferruh Yigit wrote: > On 3/21/2021 9:00 AM, Thomas Monjalon wrote: >> Since rte_flow is the only API for filtering operations, >> the legacy driver interface filter_ctrl was too much complicated >> for the simple task of getting the struct rte_flow_ops. >> >> The filter type RTE_ETH_FILTER_GENERIC and >> the filter operarion RTE_ETH_FILTER_GET are removed. >> The new driver callback flow_ops_get replaces filter_ctrl. >> >> Signed-off-by: Thomas Monjalon >> Acked-by: Ajit Khaparde >> Acked-by: Haiyue Wang >> Acked-by: Rosen Xu >> Acked-by: Hemant Agrawal > > Except from following minor issue, > > Reviewed-by: Ferruh Yigit > >> --- a/drivers/net/dpaa2/dpaa2_flow.c >> +++ b/drivers/net/dpaa2/dpaa2_flow.c >> @@ -89,8 +89,6 @@ enum rte_flow_action_type dpaa2_supported_action_type[] = { >>   /* Max of enum rte_flow_item_type + 1, for both IPv4 and IPv6*/ >>   #define DPAA2_FLOW_ITEM_TYPE_GENERIC_IP (RTE_FLOW_ITEM_TYPE_META + 1) >> -enum rte_filter_type dpaa2_filter_type = RTE_ETH_FILTER_NONE; >> - > > Need to remove the 'dpaa2_filter_type' extern from 'dpaa2_ethdev.h' too. Applied to dpdk-next-net/main, thanks. (extern from 'dpaa2_ethdev.h' removed while merging) Only 1/2 merged, 2/2 can be discussed more or merged later.