From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 38C071B629 for ; Fri, 13 Oct 2017 04:51:27 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Oct 2017 19:51:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,369,1503385200"; d="scan'208";a="909488298" Received: from unknown (HELO [10.241.225.21]) ([10.241.225.21]) by FMSMGA003.fm.intel.com with ESMTP; 12 Oct 2017 19:51:25 -0700 Cc: dev@dpdk.org, patrick@patrickmacarthur.net, mark.b.kavanagh@intel.com, stephen@networkplumber.org References: <20171013024644.51248-1-ferruh.yigit@intel.com> To: markus.theil@tu-ilmenau.de From: Ferruh Yigit Message-ID: <72302705-a723-ccb2-05ae-5bc131c0080a@intel.com> Date: Fri, 13 Oct 2017 03:51:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171013024644.51248-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix unknown symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 02:51:27 -0000 On 10/13/2017 3:46 AM, Ferruh Yigit wrote: > This patch partially reverts the commit d196343a258e and adds some > functions from Markus' previous version of the patch [1]. > > igb_uio uses pci_msi_unmask_irq() and pci_msi_mask_irq() kernel APIs > when kernel version is >= 3.19 because these APIs are implemented in > this Linux kernel version. > > But these APIs only exported beginning from Linux kernel 4.5, so before > this Linux kernel version igb_uio kernel module is not usable, > and giving following warnings: > "igb_uio: Unknown symbol pci_msi_unmask_irq" > "igb_uio: Unknown symbol pci_msi_mask_irq" > > The support for these APIs increased to Linux kernel >= 4.5 > > For older version of Linux kernel unmask_msi_irq() and mask_msi_irq() > are used but these functions are not exported at all. > Instead of these functions switched back to previous implementation in > igb_uio for MSI-X, and for MSI used igbuio_msi_mask_irq() from [1]. > > Fixes: d196343a258e ("igb_uio: use kernel functions for masking MSI-X") > Cc: markus.theil@tu-ilmenau.de > > [1] > http://dpdk.org/dev/patchwork/patch/28144/ > > Signed-off-by: Ferruh Yigit Hi Markus, Can you please test MSI interrupts, I used you function but not tested? Thanks, ferruh